public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/37573] [4.4 Regression] gcc-4.4 regression: incorrect code generation with -O1 -ftree-vectorize
Date: Thu, 16 Oct 2008 08:16:00 -0000	[thread overview]
Message-ID: <20081016081451.31371.qmail@sourceware.org> (raw)
In-Reply-To: <bug-37573-15165@http.gcc.gnu.org/bugzilla/>



------- Comment #11 from rguenther at suse dot de  2008-10-16 08:14 -------
Subject: Re:  [4.4 Regression] gcc-4.4 regression:
 incorrect code generation with -O1 -ftree-vectorize

On Thu, 16 Oct 2008, spop at gcc dot gnu dot org wrote:

> ------- Comment #10 from spop at gcc dot gnu dot org  2008-10-16 00:02 -------
> Subject: Re:  [4.4 Regression] gcc-4.4 regression: incorrect code generation
> with -O1 -ftree-vectorize
> 
> On Wed, Oct 15, 2008 at 4:47 PM, rguenth at gcc dot gnu dot org
> > IMHO the fix for the tuplification bug(!) is to strip the ADDR_EXPR that is
> > always present on op0 in split_constant_offset_1 so:
> >
> >    case ADDR_EXPR:
> >      {
> >        tree base, poffset;
> >        HOST_WIDE_INT pbitsize, pbitpos;
> >        enum machine_mode pmode;
> >        int punsignedp, pvolatilep;
> >
> >        op0 = TREE_OPERAND (op0, 0);
> >        if (!handled_component_p (op0))
> >          return false;
> 
> This is exactly what I tried within gdb and it did worked, although
> not as I expected: the base address ends to be &s and not &s.c[0] as
> I expected before.  This then fixes the bug as we end on the same
> base address of the structure.  Then the alias analysis answers that
> the two accesses can overlap.

Yes, but that is another thing.  It also isn't that simple - for any
two accesses you want to disambiguate you have to find a suitable
common base.  Consider &s.c[1] and &s + i, obviously the accesses can
overlap - would you still say so if the base address of the first one
would be &s.c[0]?  (really the base address of a non-variable access
is the access itself, right?  &s.c[1] in this case)

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37573


  parent reply	other threads:[~2008-10-16  8:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18 17:31 [Bug tree-optimization/37573] New: " edwintorok at gmail dot com
2008-09-18 17:31 ` [Bug tree-optimization/37573] " edwintorok at gmail dot com
2008-09-18 17:33 ` edwintorok at gmail dot com
2008-09-18 19:15 ` [Bug tree-optimization/37573] [4.4 Regression] " pinskia at gcc dot gnu dot org
2008-09-19 17:03 ` jakub at gcc dot gnu dot org
2008-09-19 17:53 ` jakub at gcc dot gnu dot org
2008-09-21  7:56 ` irar at il dot ibm dot com
2008-10-15 21:30 ` spop at gcc dot gnu dot org
2008-10-15 21:46 ` rguenth at gcc dot gnu dot org
2008-10-15 21:49 ` rguenth at gcc dot gnu dot org
2008-10-16  0:03 ` spop at gcc dot gnu dot org
2008-10-16  8:16 ` rguenther at suse dot de [this message]
2008-10-22 16:10   ` Sebastian Pop
2008-10-22  3:29 ` mmitchel at gcc dot gnu dot org
2008-10-22 16:11 ` sebpop at gmail dot com
2008-10-29 18:49 ` edwintorok at gmail dot com
2008-11-03  9:56 ` rguenth at gcc dot gnu dot org
2008-11-03 12:34 ` rguenth at gcc dot gnu dot org
2008-11-03 12:35 ` rguenth at gcc dot gnu dot org
2008-11-03 17:52 ` edwintorok at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081016081451.31371.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).