[Bug target/36756] New: g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[Bug target/36756] New: g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[janis at gcc dot gnu dot org]

Test g++.dg/gomp/tls-3.C started failing on powerpc-unknown-linux-gnu with an
ICE in rs6000_emit_move when the -O0 defaults were changed for
-funit-at-a-time, -fsection-anchors, and -ftop-level-reorder.  This smaller C
test:

__thread int i;
int
foo ()
{
  static __thread int k;
  return k;
}

gets the same ICE for earlier compilers back to 4.2.0 (when section anchors
were added) when compiled with "-funit-at-a-time -fsection-anchors
-fno-toplevel-reorder".


-- 
           Summary: g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time,
                    no-toplevel-reorder
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janis at gcc dot gnu dot org
GCC target triplet: powerpc-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[janis at gcc dot gnu dot org]

------- Comment #1 from janis at gcc dot gnu dot org  2008-07-07 21:59 -------
There's an ICE in the same place for libgomp.fortran/appendix_a/a.22.7.f90.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2008-08-11 01:41 -------
Confirmed, it is at least an user visible regression for 4.4.0.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-08-11 01:41:07
               date|                            |
            Summary|g++.dg/tls-3.C ICE with     |[4.4 Regression] g++.dg/tls-
                   |section-anchors, unit-at-a- |3.C ICE with section-
                   |time, no-toplevel-reorder   |anchors, unit-at-a-time, no-
                   |                            |toplevel-reorder
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[janis at gcc dot gnu dot org]

------- Comment #3 from janis at gcc dot gnu dot org  2008-08-11 17:17 -------
I have a fix for this; the code to prevent using section anchors with
no-unit-at-a-time is done in the wrong order.


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |janis at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-08-11 01:41:07         |2008-08-11 17:17:42
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-08-22 14:41 -------
Any update on this?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[janis at gcc dot gnu dot org]

------- Comment #5 from janis at gcc dot gnu dot org  2008-08-22 19:05 -------
Patch is http://gcc.gnu.org/ml/gcc-patches/2008-08/msg00843.html, I pinged it
earlier today.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[janis at gcc dot gnu dot org]

------- Comment #6 from janis at gcc dot gnu dot org  2008-08-25 20:19 -------
Subject: Bug 36756

Author: janis
Date: Mon Aug 25 20:18:08 2008
New Revision: 139572

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139572
Log:
        PR target/36756
        * config/rs6000/rs6000.c (optimization_options): Don't default to
        section anchors without toplevel reorder.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[sam at gcc dot gnu dot org]

------- Comment #7 from sam at gcc dot gnu dot org  2008-08-29 23:46 -------
I think the fix is wrong: when optimization_options() is called, user options
have not been processed yet. It is likely that section anchors are always
disabled by this change.

The patch for PR37283 at
http://gcc.gnu.org/ml/gcc-patches/2008-08/msg02325.html may solve this.


-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[janis at gcc dot gnu dot org]

------- Comment #8 from janis at gcc dot gnu dot org  2008-09-02 19:47 -------
I still think the fix was correct.  Before r139892, the relevant options were
processed in decode_options before the call to optimization_options and so
section anchors were only disabled for -O0.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756

[Bug target/36756] [4.4 Regression] g++.dg/tls-3.C ICE with section-anchors, unit-at-a-time, no-toplevel-reorder

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2008-10-21 10:54 -------
Given:
2008-09-05  Janis Johnson  <janis187@us.ibm.com>
            Samuel Tardieu  <sam@rfc1149.net>

        * opts.c (decode_options): Combine nested if statements.

        PR target/37283
        * opts.c (decode_options): Handle more relationships among
        unit-at-a-time, toplevel-reorder, and section-anchors.
I think this can be closed now.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36756