[Bug target/37362] New: [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[Bug target/37362] New: [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[g0dsowncountry at yahoo dot com]

This looks very similar to Bug# 33635. 

Stage 1 GCC (version 4.4.0 20080829) doesn't bootstrap on mipsisa64r2-linux-gcc
due to an ICE while compiling: -

mipsisa64r2-linux/64/libgcc/_powitf2.o 
mipsisa64r2-linux/libgcc/_powitf2.o    (n32)

[Identical Test Case from 33635]

[$] cat foo.i
void __powitf2 (float x __attribute__ ((mode (TF)))) {}

[$] ./gcc/cc1 -fpreprocessed foo.i -quiet
foo.i: In function '__powitf2':
foo.i:1: error: unrecognizable insn:
(insn 25 24 3 foo.i:1 (set (mem/c/i:DI (reg/f:SI 30 $fp) [0 x+0 S8 A128])
        (unspec:DI [
                (reg:TF 44 $f12 [ x ])
            ] 31)) -1 (nil))
foo.i:1: internal compiler error: in extract_insn, at recog.c:1988
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Kindly advise if additional information is required...


-- 
           Summary: [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-
                    gcc
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: g0dsowncountry at yahoo dot com
 GCC build triplet: i686-host_pc-linux-gnu
  GCC host triplet: i686-host_pc-linux-gnu
GCC target triplet: mipsisa64r2-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
  GCC build triplet|i686-host_pc-linux-gnu      |
   GCC host triplet|i686-host_pc-linux-gnu      |
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |4.4.0
            Version|unknown                     |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[g0dsowncountry at yahoo dot com]

------- Comment #1 from g0dsowncountry at yahoo dot com  2008-09-05 20:46 -------
Noticed that if GCC is configured with additional parameters 
'--with-arch=5kc --with-tune=5kc', PASS 1 build completes (gcc version 4.4.0
20080904 (experimental)). 

mipsisa64-linux-* builds fine w/o these extra configure options.

If this is the intended way to currently configure/build for mipsisa64r2-linux
targets, please confirm, so that this could be marked as invalid..?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2008-11-05 08:40 -------
Can you still reproduce this with current trunk?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[ubizjak at gmail dot com]

------- Comment #3 from ubizjak at gmail dot com  2008-11-05 10:04 -------
I guess this issue can be fixed by following (untested) trivial patch:

--cut here--
Index: mips.md
===================================================================
--- mips.md     (revision 141602)
+++ mips.md     (working copy)
@@ -4508,7 +4508,7 @@
       rtx low = mips_subword (operands[1], 0);
       rtx high = mips_subword (operands[1], 1);
       emit_insn (gen_load_low<mode> (operands[0], low));
-      if (ISA_HAS_MXHC1)
+      if (TARGET_HARD_FLOAT && ISA_HAS_MXHC1)
        emit_insn (gen_mthc1<mode> (operands[0], high, operands[0]));
       else
        emit_insn (gen_load_high<mode> (operands[0], high, operands[0]));
@@ -4518,7 +4518,7 @@
       rtx low = mips_subword (operands[0], 0);
       rtx high = mips_subword (operands[0], 1);
       emit_insn (gen_store_word<mode> (low, operands[1], const0_rtx));
-      if (ISA_HAS_MXHC1)
+      if (TARGET_HARD_FLOAT && ISA_HAS_MXHC1)
        emit_insn (gen_mfhc1<mode> (high, operands[1]));
       else
        emit_insn (gen_store_word<mode> (high, operands[1], const1_rtx));
--cut here--

Nebu, can you bootstrap and regression test this patch on your target?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[g0dsowncountry at yahoo dot com]

------- Comment #4 from g0dsowncountry at yahoo dot com  2008-11-17 21:39 -------
Using top-of-stack GCC and Binutils from Nov 17, issue still present; Applied
the below patch and re-tried, no change in behavior. Fails the same way...

FYI, This is what I'm using to configure GCC: -

../gcc-svn-111708/configure --prefix=<> --host=i686-host_pc-linux-gnu
--target=mipsisa64r2-linux --build=i686-host_pc-linux-gnu --disable-nls
--with-newlib --disable-shared --disable-threads --with-gnu-as --with-gnu-ld
--disable-soft-float --enable-symvers=gnu --enable-__cxa_atexit
--disable-libmudflap --disable-libssp --disable-libffi --disable-libgomp
--with-local-prefix=<> --with-sysroot=<> --enable-multilib --enable-languages=c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[ubizjak at gmail dot com]

------- Comment #5 from ubizjak at gmail dot com  2008-11-18 00:11 -------
(In reply to comment #4)
> Using top-of-stack GCC and Binutils from Nov 17, issue still present; Applied
> the below patch and re-tried, no change in behavior. Fails the same way...

This one is tested with a cross and works for me:

Index: mips.md
===================================================================
--- mips.md     (revision 141951)
+++ mips.md     (working copy)
@@ -4537,7 +4537,7 @@
       rtx low = mips_subword (operands[0], 0);
       rtx high = mips_subword (operands[0], 1);
       emit_insn (gen_store_word<mode> (low, operands[1], const0_rtx));
-      if (ISA_HAS_MXHC1)
+      if (register_operand (high, <HALFMODE>mode) && ISA_HAS_MXHC1)
        emit_insn (gen_mfhc1<mode> (high, operands[1]));
       else
        emit_insn (gen_store_word<mode> (high, operands[1], const1_rtx));


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-11-18 00:11:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[g0dsowncountry at yahoo dot com]

------- Comment #6 from g0dsowncountry at yahoo dot com  2008-11-18 01:31 -------
With the patch in Comment #5, the test case passes; but the GCC Build fails
with the following error message while creating
mipsisa64r2-linux/64/libgcc/_powitf2.o

../../../../gcc-svn-111708/libgcc/../gcc/libgcc2.c: In function '__powitf2':
../../../../gcc-svn-111708/libgcc/../gcc/libgcc2.c:1743: error: insn does not
satisfy its constraints:
(insn 209 208 202 8 ../../../../gcc-svn-111708/libgcc/../gcc/libgcc2.c:1742
(set (reg:TF 44 $f12)
        (unspec:TF [
                (mem/u/c/i:DI (lo_sum:DI (reg/f:DI 4 $4 [218])
                        (symbol_ref/u:DI ("*.LC0") [flags 0x2])) [2 S8 A128])
                (reg:TF 44 $f12)
            ] 32)) 336 {mthc1tf} (expr_list:REG_EQUAL (const_double:TF 1.0e+0
[0x0.8p+1])
        (nil)))
../../../../gcc-svn-111708/libgcc/../gcc/libgcc2.c:1743: internal compiler
error: in copyprop_hardreg_forward_1, at regrename.c:1595
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-11-18 08:09 -------
Created an attachment (id=16716)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16716&action=view)
Patch with a testcase

This patch solves all issues with mthc1 and mfhc1.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[g0dsowncountry at yahoo dot com]

------- Comment #8 from g0dsowncountry at yahoo dot com  2008-11-18 18:52 -------
With Uros's patch in Comment #7, GCC Builds Fine..! 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[uros at gcc dot gnu dot org]

------- Comment #9 from uros at gcc dot gnu dot org  2008-11-18 22:01 -------
Subject: Bug 37362

Author: uros
Date: Tue Nov 18 22:00:12 2008
New Revision: 141978

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141978
Log:
        PR target/37362
        * config/mips/mips.md (move_doubleword_fpr<mode>): Check that "high"
        is a register or zero operand in the correct mode before generating
        mtch1 insn or a register operand in the correct mode before generating
        mfch1 insn.
        (mtch1<mode>): Correct operand 1 predicate to reg_or_0_operand.

testsuite/ChangeLog:

        PR target/37362
        * gcc.target/mips/pr37362.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/mips/pr37362.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/mips/mips.md
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362

[Bug target/37362] [4.4 Regression] Bootstrap broken on mipsisa64r2-linux-gcc

[ubizjak at gmail dot com]

------- Comment #10 from ubizjak at gmail dot com  2008-11-18 22:06 -------
Fixed.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |11/msg00920.html
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37362