[Bug target/37241] New: [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[Bug target/37241] New: [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[dominiq at lps dot ens dot fr]

On Darwin, we have the following since at least revision 136913 (revision
136903 seems the most likely candidate, the others being 136899, 136905, and
136912):

FAIL: g++.dg/abi/key2.C scan-assembler .globl __ZTI1f\\\\n\\t.weak_definition
__ZTI1f\\\\n\\t.section __DATA,__const_coal,coalesced

The corresponding part of the assembly code reads:

   42 -         .long   __ZN1f1hEv
   43 - .globl __ZTI1f
   44 :         .weak_definition __ZTI1f
   45 +         .align 2
   46 + __ZTI1f:

Revision 136903
Author: hubicka
Date:   Wed Jun 18 19:07:51 2008 UTC (2 months, 1 week ago)
Log Message:    
        * c-opts.c (c_common_post_options): PCH is not compatible with
        no-unit-at-a-time.
        * opts.c (handle_options): Enable unit-at-a-time at O0 along with
        -fno-toplevel-reorder by default now.
        * gcc.dg/weak/weak-2.c: We no longer complain about incompatibilty.
        * gcc.dg/weak/weak-3.c: We no longer complain about incompatibilty.
        * gcc.dg/weak/weak-4.c: We no longer complain about incompatibilty.
        * gcc.dg/weak/weak-5.c: We no longer complain about incompatibilty.
        * gcc.dg/weak/weak-6.c: Fix thinko in previous change.
        * gcc.dg/weak/weak-7.c: Likewise.


-- 
           Summary: [4.4 Regression]: FAIL: g++.dg/abi/key2.C
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: *-apple-darwin*
  GCC host triplet: *-apple-darwin*
GCC target triplet: *-apple-darwin*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug target/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug target/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2008-09-14 05:03 -------
Confirmed, I see this also.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-09-14 05:03:55
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug target/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug target/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2008-10-22 12:11 -------
That sounds just too strict testcase matching, not expecting any kind of
reordering and .section directives not necessarily being emitted if an object
is emitted in the same section as the previous one.
FYI, on a x86_64-linux -> powerpc64-darwin cross, I see:
        .globl __ZTV1f
        .weak_definition __ZTV1f
        .section __TEXT,__const_coal,coalesced
...
        .globl __ZTI1f
        .weak_definition __ZTI1f
...
        .globl __ZTS1f
        .weak_definition __ZTS1f
(all in the same section and __TEXT used everywhere, not __DATA).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-10-28 23:22 -------
The section does not change so there is no need for the .section in the
scan-assembler:
.globl __ZTV1f
        .weak_definition __ZTV1f
        .section __DATA,__const_coal,coalesced
        .align 3
__ZTV1f:
        .long   0
        .long   __ZTI1f
        .long   __ZN1f1gEv
        .long   __ZN1f1hEv
.globl __ZTI1f
        .weak_definition __ZTI1f
        .align 2
__ZTI1f:


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|target                      |testsuite
  GCC build triplet|*-apple-darwin*             |
   GCC host triplet|*-apple-darwin*             |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2008-10-28 23:33 -------
Not P1, as it is just a testcase issue, not compiler bug.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2008-11-03 12:00 -------
s/testcase/patch/, sorry.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2008-11-03 12:00 -------
Created an attachment (id=16616)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16616&action=view)
gcc44-pr37241.patch

Please try attached testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[dominiq at lps dot ens dot fr]

------- Comment #7 from dominiq at lps dot ens dot fr  2008-11-03 17:33 -------
The failures disappear with the patch in comment #5.

Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-09-14 05:03:55         |2008-11-03 20:27:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2008-11-03 22:07 -------
Subject: Bug 37241

Author: jakub
Date: Mon Nov  3 22:05:57 2008
New Revision: 141565

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141565
Log:
        PR testsuite/37241
        * g++.dg/abi/key2.C: Adjust regexps to allow __ZTV1f and __ZTI1f
        sharing one .section directive.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/abi/key2.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241

[Bug testsuite/37241] [4.4 Regression]: FAIL: g++.dg/abi/key2.C

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2008-11-03 22:08 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37241