[Bug middle-end/37902] New: [4.3 Regression] in_system_header bug

[Bug middle-end/37902] New: [4.3 Regression] in_system_header bug

[jakub at gcc dot gnu dot org]

See http://gcc.gnu.org/ml/gcc-bugs/2008-10/msg01511.html

/* { dg-options "-O -W -Wall -Wdeclaration-after-statement -fpreprocessed" }
# 1 "my.c" 1
# 1 "my.h" 1 3 4
void foo (void);
# 2 "my.c" 2

void
foo (void)
{
}

int
bar (void)
{
  return 0;
  int j;
  return j;
}

doesn't warn in bar, supposedly in_system_header hasn't been cleared when done
with foo function.

This is fixed on the trunk supposedly by
http://gcc.gnu.org/ml/gcc-patches/2008-07/msg01264.html
but that patch is definitely not backportable to 4.3 branch.


-- 
           Summary: [4.3 Regression] in_system_header bug
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2008-10-23 12:40 -------
The regression has been introduced by PR32256, before that in_system_header
flag wasn't saved/restored in push_cfun/pop_cfun.
The issue seems to be that allocate_struct_function call in store_parm_decls
doesn't seem to have a corresponding set_cfun (NULL); call, so when push_cfun
during gimplification is called, it doesn't save in_system_header (as cfun is
already non-NULL) and more importantly, pop_cfun at the end of gimplification
pops to the same cfun, which means in_system_header remains 1 when leaving the
gimplifier and is then used by subsequent parsing of bar function.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |diagnostic
   Target Milestone|---                         |4.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2009-01-24 10:20 -------
GCC 4.3.3 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.3                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2009-08-04 12:29 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2010-05-22 18:12 -------
GCC 4.3.5 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.5                       |4.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

[Bug middle-end/37902] [4.3 Regression] in_system_header bug

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37902

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.3.6                       |4.4.0

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 11:34:47 UTC ---
Fixed for 4.4.0.