[Bug testsuite/37561] New: [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[Bug testsuite/37561] New: [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[hjl dot tools at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

bash-3.2$ cat g++.old-deja/g++.mike/warn1.C
// { dg-do assemble  }
// { dg-options "-Wall" }

typedef char * charptr;
typedef __SIZE_TYPE__ size_t;
char c[]={'A','B','C','D'};
int i=size_t(&c);
int *pp=&i;
void foo() { }
int main()
{
 charptr(*pp)++;        // { dg-warning "" } 
 return 0;
}
bash-3.2$ gcc -Wall -S -o /tmp/x.s g++.old-deja/g++.mike/warn1.C -m64
g++.old-deja/g++.mike/warn1.C: In function ‘int main()’:
g++.old-deja/g++.mike/warn1.C:12: warning: value computed is not used
bash-3.2$ gcc -Wall -S -o /tmp/x.s g++.old-deja/g++.mike/warn1.C -m32
g++.old-deja/g++.mike/warn1.C: In function ‘int main()’:
g++.old-deja/g++.mike/warn1.C:12: error: lvalue required as increment operand
bash-3.2$ 

On Linux/x86-64, I got

FAIL: g++.old-deja/g++.mike/warn1.C  (test for errors, line 12)
FAIL: g++.old-deja/g++.mike/warn1.C (test for excess errors)


-- 
           Summary: [4.4 Regression] Revision 140405 caused g++.old-
                    deja/g++.mike/warn1.C
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug testsuite/37561] [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[janis at gcc dot gnu dot org]

------- Comment #1 from janis at gcc dot gnu dot org  2008-09-17 16:00 -------
I tested with -m32 on powerpc64-linux, not with both -m32/-m64 which would have
caught this; I'll test with both for related patches.

The test previously used { dg-warning "" }, which matched any message from that
line.  The patch, in preparation to using new versions of dg-error and
dg-warning that actually check for "warning" and "error", changed that to {
dg-error "lvalue" }, which matches the error message for -m32 but not the
warning message for -m64.  It's a bug in the compiler that the error isn't
reported for -m64, and the change to the test merely detected that.

This should be a C++ bug, not a testsuite bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug testsuite/37561] [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[hjl dot tools at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]



------- Comment #2 from hjl dot tools at gmail dot com  2008-09-17 16:11 -------
(In reply to comment #1)
> I tested with -m32 on powerpc64-linux, not with both -m32/-m64 which would have
> caught this; I'll test with both for related patches.
> 
> The test previously used { dg-warning "" }, which matched any message from that
> line.  The patch, in preparation to using new versions of dg-error and
> dg-warning that actually check for "warning" and "error", changed that to {
> dg-error "lvalue" }, which matches the error message for -m32 but not the
> warning message for -m64.  It's a bug in the compiler that the error isn't
> reported for -m64, and the change to the test merely detected that.
> 
> This should be a C++ bug, not a testsuite bug.
> 

I am not sure if it is a C++ bug. The differences between -m32
and -m64 are the sizes of __SIZE_TYPE__, int and pointer. Replace
int with long gives me
[hjl@gnu-6 tmp]$ cat x.cc 
typedef char * charptr;
typedef __SIZE_TYPE__ size_t;
char c[]={'A','B','C','D'};
long i=size_t(&c);
long *pp=&i;
void foo() { }
int main()
{
   charptr(*pp)++;        // { dg-warning "" } 
    return 0;
}
[hjl@gnu-6 tmp]$ gcc -Wall x.cc -S -m64     
x.cc: In function ‘int main()’:
x.cc:9: error: lvalue required as increment operand
[hjl@gnu-6 tmp]$ gcc -Wall x.cc -S -m32
x.cc: In function ‘int main()’:
x.cc:9: error: lvalue required as increment operand
[hjl@gnu-6 tmp]$ 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug testsuite/37561] [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[janis at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]



------- Comment #3 from janis at gcc dot gnu dot org  2008-09-17 17:02 -------
This is twisting my brain, but in this simplified testcase:

  __PTRDIFF_TYPE__ p;
  short q;
  void foo () { ((char *)p)++; }
  void bar () { ((char *)q)++; }

we get an error with both -m32 and-m64 for foo but not for bar:

  elm3b149% /home/janis/tools/gcc-trunk-anonsvn/bin/g++ -c -m32 z.C
  z.C: In function ‘void foo()’:
  z.C:3: error: lvalue required as increment operand
  elm3b149% /home/janis/tools/gcc-trunk-anonsvn/bin/g++ -c -m64 z.C
  z.C: In function ‘void foo()’:
  z.C:3: error: lvalue required as increment operand

although the expression "(char *)q" in bar is not an lvalue.  What am I
missing?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug testsuite/37561] [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[janis at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]



------- Comment #4 from janis at gcc dot gnu dot org  2008-09-17 17:38 -------
The same thing happens in C for the simplified testcase; z.c is a copy of z.C
from comment #3:

  elm3b149% /home/janis/tools/gcc-trunk-anonsvn/bin/gcc -c -m32 z.c
  z.c: In function ‘foo’:
  z.c:3: error: lvalue required as increment operand
  z.c: In function ‘bar’:
  z.c:4: warning: cast to pointer from integer of different size
  elm3b149% /home/janis/tools/gcc-trunk-anonsvn/bin/gcc -c -m64 z.c
  z.c: In function ‘foo’:
  z.c:3: error: lvalue required as increment operand
  z.c: In function ‘bar’:
  z.c:4: warning: cast to pointer from integer of different size


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug testsuite/37561] [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[janis at gcc dot gnu dot org]

------- Comment #5 from janis at gcc dot gnu dot org  2008-09-19 18:24 -------
The operand of a postincrement and friends must be a modifiable lvalue.  The
type check code for both C and C++ calls get_unwidened, which removes the cast
when it's a different size but leaves the cast when it's the same size.  The
later call to lvalue_p (via lvalue_or_else) says the operand is not an lvalue
when there's still a cast, but doesn't complain when the cast has been removed.


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org, jsm28 at gcc dot gnu
                   |                            |dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2008-09-20 03:09 -------
This is a bug in the front-end ...


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
          Component|testsuite                   |c++
     Ever Confirmed|0                           |1
           Keywords|                            |accepts-invalid
   Last reconfirmed|0000-00-00 00:00:00         |2008-09-20 03:09:18
               date|                            |
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3/4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2008-10-07 14:08 -------
As all compilers starting with 4.0 behave the same way, this is not a new 4.4
regression.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4 Regression] Revision   |[4.2/4.3/4.4 Regression]
                   |140405 caused g++.old-      |Revision 140405 caused
                   |deja/g++.mike/warn1.C       |g++.old-
                   |                            |deja/g++.mike/warn1.C


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3/4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3/4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-09-20 03:09:18         |2008-11-14 16:10:30
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3/4.4 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2008-11-15 09:54 -------
Subject: Bug 37561

Author: jakub
Date: Sat Nov 15 09:53:02 2008
New Revision: 141881

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141881
Log:
        PR c++/37561
        * c-typeck.c (build_unary_op): Don't call get_unwidened.  Use
        argtype instead of result_type.

        * typeck.c (cp_build_unary_op): Don't call get_unwidened.  Use
        argtype instead of result_type.

        * gcc.dg/pr37561.c: New test.
        * g++.dg/other/increment1.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/other/increment1.C
    trunk/gcc/testsuite/gcc.dg/pr37561.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-typeck.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2008-11-15 09:57 -------
Fixed on the trunk.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.4.0
            Summary|[4.2/4.3/4.4 Regression]    |[4.2/4.3 Regression]
                   |Revision 140405 caused      |Revision 140405 caused
                   |g++.old-                    |g++.old-
                   |deja/g++.mike/warn1.C       |deja/g++.mike/warn1.C


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2009-01-08 22:58 -------
Thus fixed.  No need to fix accepts-invalid bugs on release branches (IMHO
we should never do that).


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |4.2.4 4.3.2
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561

[Bug c++/37561] [4.2/4.3 Regression] Revision 140405 caused g++.old-deja/g++.mike/warn1.C

[rguenth at gcc dot gnu dot org]

------- Comment #11 from rguenth at gcc dot gnu dot org  2009-07-10 15:55 -------
Subject: Bug 37561

Author: rguenth
Date: Fri Jul 10 15:55:04 2009
New Revision: 149484

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=149484
Log:
2009-07-10  Richard Guenther  <rguenther@suse.de>

        Backport from mainline
        2008-11-17  Jakub Jelinek  <jakub@redhat.com>

        PR c++/36089
        * init.c (constant_value_1): Handle TREE_LIST init.

        PR c++/37561
        PR c++/36089
        * g++.dg/template/init8.C: New test.

Added:
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/template/init8.C
Modified:
    branches/gcc-4_3-branch/gcc/cp/ChangeLog
    branches/gcc-4_3-branch/gcc/cp/init.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37561