[Bug middle-end/38237] New: [4.4 regression] multiple weak directives

[Bug middle-end/38237] New: [4.4 regression] multiple weak directives

[ebotcazou at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

This is a fallout of

2008-08-19  Rafael Espíndola  <espindola@google.com>

        * varasm.c (weak_decls): Move earlier in the file.
        (assemble_external): Add weak decls to the weak_decls list.
        (declare_weak): Don't add decls to the weak_decls list.


eric@atlantis:~/build/gcc/native32> cat t.c
extern int i __attribute__((weak));

void foo(void)
{
  int a = i + i + i + i;
}
eric@atlantis:~/build/gcc/native32> cat t.s
        .file   "t.c"
        .text
.globl foo
        .type   foo, @function
foo:
        pushl   %ebp
        movl    %esp, %ebp
        subl    $16, %esp
        movl    i, %edx
        movl    i, %eax
        addl    %eax, %edx
        movl    i, %eax
        addl    %eax, %edx
        movl    i, %eax
        leal    (%edx,%eax), %eax
        movl    %eax, -4(%ebp)
        leave
        ret
        .size   foo, .-foo
        .weak   i
        .weak   i
        .weak   i
        .weak   i
        .ident  "GCC: (GNU) 4.4.0 20081122 (experimental) [trunk revision
142117]"
        .section        .note.GNU-stack,"",@progbits


-- 
           Summary: [4.4 regression] multiple weak directives
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ebotcazou at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38237

[Bug middle-end/38237] [4.4 regression] multiple weak directives

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38237

[Bug middle-end/38237] [4.4 regression] multiple weak directives

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-11-23 16:14 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-11-23 16:14:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38237

[Bug middle-end/38237] [4.4 regression] multiple weak directives

[jsm28 at gcc dot gnu dot org]

------- Comment #2 from jsm28 at gcc dot gnu dot org  2008-11-27 17:36 -------
Setting to P5, please restore to P3 if the assembler for some primary or
secondary target complains about the multiple directives or incorrectly
assembles the file because of them.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38237

[Bug middle-end/38237] [4.4/4.5 regression] multiple weak directives

[sje at gcc dot gnu dot org]

------- Comment #3 from sje at gcc dot gnu dot org  2009-03-30 16:44 -------
Subject: Bug 38237

Author: sje
Date: Mon Mar 30 16:43:40 2009
New Revision: 145303

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=145303
Log:
        PR middle-end/38237
        * tree.h (tree_find_value): New declaration.
        * tree.c (tree_find_value): New function.
        * varasm.c (assemble_external): Avoid duplicate entries on lists.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree.c
    trunk/gcc/tree.h
    trunk/gcc/varasm.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38237

[Bug middle-end/38237] [4.4/4.5 regression] multiple weak directives

[sje at cup dot hp dot com]

------- Comment #4 from sje at cup dot hp dot com  2009-03-30 16:46 -------
Closing out as fixed in 4.5.  It is probably not worth backporting to 4.4 since
it doesn't cause any failures that we know of.


-- 

sje at cup dot hp dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to fail|                            |4.4.0
      Known to work|                            |4.5.0
         Resolution|                            |FIXED
   Target Milestone|4.4.0                       |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38237