public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/38262]  New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
@ 2008-11-25 16:02 ghazi at gcc dot gnu dot org
  2008-11-25 16:27 ` [Bug bootstrap/38262] " pinskia at gcc dot gnu dot org
                   ` (10 more replies)
  0 siblings, 11 replies; 14+ messages in thread
From: ghazi at gcc dot gnu dot org @ 2008-11-25 16:02 UTC (permalink / raw)
  To: gcc-bugs

As noted here:
http://gcc.gnu.org/ml/gcc/2008-11/msg00234.html

various components of GCC (xgcc, gcov, etc) are linking unnecessarily with
gmp/mpfr.  I believe we only need to do that for executables linked against
libbackend.a (like cc1).  The result is exposed when gmp/mpfr are shared
libraries and appear in the ldd output.

This bug was previously fixed in PR35107 but regressed during the graphite
merge.

http://gcc.gnu.org/viewcvs/trunk/gcc/Makefile.in?r1=139854&r2=139893


-- 
           Summary: [4.4 regression] GCC components unnecessarily link with
                    shared gmp/mpfr
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ghazi at gcc dot gnu dot org
 BugsThisDependsOn: 35107


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
@ 2008-11-25 16:27 ` pinskia at gcc dot gnu dot org
  2008-11-25 20:25 ` [Bug bootstrap/38262] New: " Sebastian Pop
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-11-25 16:27 UTC (permalink / raw)
  To: gcc-bugs



-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
  2008-11-25 16:27 ` [Bug bootstrap/38262] " pinskia at gcc dot gnu dot org
@ 2008-11-25 20:25 ` Sebastian Pop
  2008-11-25 20:27 ` [Bug bootstrap/38262] " sebpop at gmail dot com
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: Sebastian Pop @ 2008-11-25 20:25 UTC (permalink / raw)
  To: gcc-bugzilla; +Cc: gcc-bugs

Here is a patch from Dwarak for fixing this.
He will send this to review on gcc-patches@ list.

Sebastian Pop
--
AMD - GNU Tools

--- Makefile.in 2008-10-23 10:33:51.274495000 -0500
+++ Makefile.in.fix     2008-11-19 16:11:55.802980000 -0600
@@ -903,8 +903,9 @@ BUILD_LIBDEPS=3D $(BUILD_LIBIBERTY)

 # How to link with both our special library facilities
 # and the system's installed libraries.
-LIBS =3D @LIBS@ $(CPPLIB) $(LIBINTL) $(LIBICONV) $(LIBIBERTY)
$(LIBDECNUMBER) \
-       $(GMPLIBS) $(CLOOGLIBS) $(PPLLIBS)
+LIBS =3D @LIBS@ $(CPPLIB) $(LIBINTL) $(LIBICONV) $(LIBIBERTY)
$(LIBDECNUMBER)=20
+
+BACKENDLIBS =3D $(GMPLIBS) $(CLOOGLIBS) $(PPLLIBS)

 # Any system libraries needed just for GNAT.
 SYSLIBS =3D @GNAT_LIBEXC@
@@ -1613,7 +1614,7 @@ libbackend.a: $(OBJS@onestep@)
 xgcc$(exeext): $(GCC_OBJS) gccspec.o version.o intl.o prefix.o \
    version.o $(LIBDEPS) $(EXTRA_GCC_OBJS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(GCC_OBJS) gccspec.o \
-         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
+         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
$(BACKENDLIBS)

 # cpp is to cpp0 as gcc is to cc1.
 # The only difference from xgcc is that it's linked with cppspec.o
@@ -1621,7 +1622,7 @@ xgcc$(exeext): $(GCC_OBJS) gccspec.o ver
 cpp$(exeext): $(GCC_OBJS) cppspec.o version.o intl.o prefix.o \
    version.o $(LIBDEPS) $(EXTRA_GCC_OBJS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(GCC_OBJS) cppspec.o \
-         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
+         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
$(BACKENDLIBS)

 # Dump a specs file to make -B./ read these specs over installed ones.
 $(SPECS): xgcc$(exeext)
@@ -1638,7 +1639,7 @@ dummy-checksum.o : dummy-checksum.c

 cc1-dummy$(exeext): $(C_OBJS) dummy-checksum.o $(BACKEND) $(LIBDEPS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) dummy-checksum.o
\
-         $(BACKEND) $(LIBS) $(GMPLIBS)
+         $(BACKEND) $(LIBS) $(BACKENDLIBS)

 cc1-checksum.c : cc1-dummy$(exeext) build/genchecksum$(build_exeext)
        build/genchecksum$(build_exeext) cc1-dummy$(exeext) > $@
@@ -1647,7 +1648,7 @@ cc1-checksum.o : cc1-checksum.c

 cc1$(exeext): $(C_OBJS) cc1-checksum.o $(BACKEND) $(LIBDEPS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) cc1-checksum.o \
-         $(BACKEND) $(LIBS) $(GMPLIBS)
+         $(BACKEND) $(LIBS) $(BACKENDLIBS)

 #

 # Build libgcc.a.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
  2008-11-25 16:27 ` [Bug bootstrap/38262] " pinskia at gcc dot gnu dot org
  2008-11-25 20:25 ` [Bug bootstrap/38262] New: " Sebastian Pop
@ 2008-11-25 20:27 ` sebpop at gmail dot com
  2008-11-25 23:10 ` ghazi at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: sebpop at gmail dot com @ 2008-11-25 20:27 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from sebpop at gmail dot com  2008-11-25 20:25 -------
Subject: Re:  New: [4.4 regression] GCC components unnecessarily link with
shared gmp/mpfr

Here is a patch from Dwarak for fixing this.
He will send this to review on gcc-patches@ list.

Sebastian Pop
--
AMD - GNU Tools

--- Makefile.in 2008-10-23 10:33:51.274495000 -0500
+++ Makefile.in.fix     2008-11-19 16:11:55.802980000 -0600
@@ -903,8 +903,9 @@ BUILD_LIBDEPS=3D $(BUILD_LIBIBERTY)

 # How to link with both our special library facilities
 # and the system's installed libraries.
-LIBS =3D @LIBS@ $(CPPLIB) $(LIBINTL) $(LIBICONV) $(LIBIBERTY)
$(LIBDECNUMBER) \
-       $(GMPLIBS) $(CLOOGLIBS) $(PPLLIBS)
+LIBS =3D @LIBS@ $(CPPLIB) $(LIBINTL) $(LIBICONV) $(LIBIBERTY)
$(LIBDECNUMBER)=20
+
+BACKENDLIBS =3D $(GMPLIBS) $(CLOOGLIBS) $(PPLLIBS)

 # Any system libraries needed just for GNAT.
 SYSLIBS =3D @GNAT_LIBEXC@
@@ -1613,7 +1614,7 @@ libbackend.a: $(OBJS@onestep@)
 xgcc$(exeext): $(GCC_OBJS) gccspec.o version.o intl.o prefix.o \
    version.o $(LIBDEPS) $(EXTRA_GCC_OBJS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(GCC_OBJS) gccspec.o \
-         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
+         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
$(BACKENDLIBS)

 # cpp is to cpp0 as gcc is to cc1.
 # The only difference from xgcc is that it's linked with cppspec.o
@@ -1621,7 +1622,7 @@ xgcc$(exeext): $(GCC_OBJS) gccspec.o ver
 cpp$(exeext): $(GCC_OBJS) cppspec.o version.o intl.o prefix.o \
    version.o $(LIBDEPS) $(EXTRA_GCC_OBJS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(GCC_OBJS) cppspec.o \
-         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
+         intl.o prefix.o version.o $(EXTRA_GCC_OBJS) $(LIBS)
$(BACKENDLIBS)

 # Dump a specs file to make -B./ read these specs over installed ones.
 $(SPECS): xgcc$(exeext)
@@ -1638,7 +1639,7 @@ dummy-checksum.o : dummy-checksum.c

 cc1-dummy$(exeext): $(C_OBJS) dummy-checksum.o $(BACKEND) $(LIBDEPS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) dummy-checksum.o
\
-         $(BACKEND) $(LIBS) $(GMPLIBS)
+         $(BACKEND) $(LIBS) $(BACKENDLIBS)

 cc1-checksum.c : cc1-dummy$(exeext) build/genchecksum$(build_exeext)
        build/genchecksum$(build_exeext) cc1-dummy$(exeext) > $@
@@ -1647,7 +1648,7 @@ cc1-checksum.o : cc1-checksum.c

 cc1$(exeext): $(C_OBJS) cc1-checksum.o $(BACKEND) $(LIBDEPS)
        $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) cc1-checksum.o \
-         $(BACKEND) $(LIBS) $(GMPLIBS)
+         $(BACKEND) $(LIBS) $(BACKENDLIBS)

 #

 # Build libgcc.a.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2008-11-25 20:27 ` [Bug bootstrap/38262] " sebpop at gmail dot com
@ 2008-11-25 23:10 ` ghazi at gcc dot gnu dot org
  2008-11-26 18:19   ` Sebastian Pop
  2008-11-26 18:21 ` sebpop at gmail dot com
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 14+ messages in thread
From: ghazi at gcc dot gnu dot org @ 2008-11-25 23:10 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from ghazi at gcc dot gnu dot org  2008-11-25 23:08 -------
(In reply to comment #1)
> Subject: Re:  New: [4.4 regression] GCC components unnecessarily link with
> shared gmp/mpfr
> Here is a patch from Dwarak for fixing this.
> He will send this to review on gcc-patches@ list.
> Sebastian Pop
> --
> AMD - GNU Tools

Thanks, however I don't understand why in this patch xgcc and cpp are being
linked with BACKENDLIBS.  They don't linked with libbackend.a.

Also, there are many more places where you do need to add BACKENDLIBS like
cc1plus, cc1obj, f951, jc1, etc.  See here for all the places you'll need to
catch:

http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00187.html


-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-11-25 23:08:54
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 23:10 ` ghazi at gcc dot gnu dot org
@ 2008-11-26 18:19   ` Sebastian Pop
  0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Pop @ 2008-11-26 18:19 UTC (permalink / raw)
  To: gcc-bugzilla; +Cc: gcc-bugs

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Thanks for catching the missing parts.
Here is the updated patch.  Does this patch look correct?
I sent this patch to test on the gccfarm and will send an email to
gcc-patches after it completes regstrap.

Thanks,
Sebastian

On Tue, Nov 25, 2008 at 5:08 PM, ghazi at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #2 from ghazi at gcc dot gnu dot org  2008-11-25 23:08 -------
> (In reply to comment #1)
>> Subject: Re:  New: [4.4 regression] GCC components unnecessarily link with
>> shared gmp/mpfr
>> Here is a patch from Dwarak for fixing this.
>> He will send this to review on gcc-patches@ list.
>> Sebastian Pop
>> --
>> AMD - GNU Tools
>
> Thanks, however I don't understand why in this patch xgcc and cpp are being
> linked with BACKENDLIBS.  They don't linked with libbackend.a.
>
> Also, there are many more places where you do need to add BACKENDLIBS like
> cc1plus, cc1obj, f951, jc1, etc.  See here for all the places you'll need to
> catch:
>
> http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00187.html
>
>
> --
>
> ghazi at gcc dot gnu dot org changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>             Status|UNCONFIRMED                 |NEW
>     Ever Confirmed|0                           |1
>   Last reconfirmed|0000-00-00 00:00:00         |2008-11-25 23:08:54
>               date|                            |
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262
>
>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 1273_pr38262_link.diff --]
[-- Type: text/x-patch; name=1273_pr38262_link.diff, Size: 6220 bytes --]

Index: gcc/java/Make-lang.in
===================================================================
--- gcc/java/Make-lang.in	(revision 142224)
+++ gcc/java/Make-lang.in	(working copy)
@@ -101,7 +101,7 @@ jvspec.o-warn = -Wno-error
 jc1$(exeext): $(JAVA_OBJS) $(BACKEND) $(LIBDEPS) attribs.o
 	rm -f $@
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
-		$(JAVA_OBJS) $(BACKEND) $(ZLIB) $(LIBICONV) $(LIBS) attribs.o $(GMPLIBS)
+		$(JAVA_OBJS) $(BACKEND) $(ZLIB) $(LIBICONV) $(LIBS) attribs.o $(BACKENDLIBS)
 
 jcf-dump$(exeext): $(JCFDUMP_OBJS) $(LIBDEPS)
 	rm -f $@
Index: gcc/objc/Make-lang.in
===================================================================
--- gcc/objc/Make-lang.in	(revision 142224)
+++ gcc/objc/Make-lang.in	(working copy)
@@ -54,7 +54,7 @@ objc_OBJS = $(OBJC_OBJS) cc1obj-checksum
 cc1obj-dummy$(exeext): $(OBJC_OBJS) $(C_AND_OBJC_OBJS) dummy-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
 	      $(OBJC_OBJS) $(C_AND_OBJC_OBJS) dummy-checksum.o \
-	      $(BACKEND) $(LIBS) $(GMPLIBS)
+	      $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 cc1obj-checksum.c : cc1obj-dummy$(exeext) build/genchecksum$(build_exeext)
 	build/genchecksum$(build_exeext) cc1obj-dummy$(exeext) > $@
@@ -64,7 +64,7 @@ cc1obj-checksum.o : cc1obj-checksum.c
 cc1obj$(exeext): $(OBJC_OBJS) $(C_AND_OBJC_OBJS) cc1obj-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
 	      $(OBJC_OBJS) $(C_AND_OBJC_OBJS) cc1obj-checksum.o \
-	      $(BACKEND) $(LIBS) $(GMPLIBS)
+	      $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 # Objective C language specific files.
 
Index: gcc/objcp/Make-lang.in
===================================================================
--- gcc/objcp/Make-lang.in	(revision 142224)
+++ gcc/objcp/Make-lang.in	(working copy)
@@ -56,7 +56,7 @@ obj-c++_OBJS = $(OBJCXX_OBJS) cc1objplus
 cc1objplus-dummy$(exeext): $(OBJCXX_OBJS) dummy-checksum.o $(BACKEND) \
 		$(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
-		$(OBJCXX_OBJS) dummy-checksum.o $(BACKEND) $(LIBS) $(GMPLIBS)
+		$(OBJCXX_OBJS) dummy-checksum.o $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 cc1objplus-checksum.c : cc1objplus-dummy$(exeext) build/genchecksum$(build_exeext)
 	build/genchecksum$(build_exeext) cc1objplus-dummy$(exeext) > $@
@@ -65,7 +65,7 @@ cc1objplus-checksum.o : cc1objplus-check
 
 cc1objplus$(exeext): $(OBJCXX_OBJS) cc1objplus-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
-		$(OBJCXX_OBJS) cc1objplus-checksum.o $(BACKEND) $(LIBS) $(GMPLIBS)
+		$(OBJCXX_OBJS) cc1objplus-checksum.o $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 # Objective C++ language specific files.
 
Index: gcc/cp/Make-lang.in
===================================================================
--- gcc/cp/Make-lang.in	(revision 142224)
+++ gcc/cp/Make-lang.in	(working copy)
@@ -93,7 +93,7 @@ cp-warn = $(STRICT_WARN)
 
 cc1plus-dummy$(exeext): $(CXX_OBJS) dummy-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
-	      $(CXX_OBJS) dummy-checksum.o $(BACKEND) $(LIBS) $(GMPLIBS)
+	      $(CXX_OBJS) dummy-checksum.o $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 cc1plus-checksum.c : cc1plus-dummy$(exeext) build/genchecksum$(build_exeext)
 	build/genchecksum$(build_exeext) cc1plus-dummy$(exeext) > $@
@@ -102,7 +102,7 @@ cc1plus-checksum.o : cc1plus-checksum.c
 
 cc1plus$(exeext): $(CXX_OBJS) cc1plus-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
-	      $(CXX_OBJS) cc1plus-checksum.o $(BACKEND) $(LIBS) $(GMPLIBS)
+	      $(CXX_OBJS) cc1plus-checksum.o $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 # Special build rules.
 $(srcdir)/cp/cfns.h: $(srcdir)/cp/cfns.gperf
Index: gcc/ada/gcc-interface/Make-lang.in
===================================================================
--- gcc/ada/gcc-interface/Make-lang.in	(revision 142224)
+++ gcc/ada/gcc-interface/Make-lang.in	(working copy)
@@ -299,7 +299,7 @@ TARGET_ADA_SRCS =
 # Since the RTL should be built with the latest compiler, remove the
 #  stamp target in the parent directory whenever gnat1 is rebuilt
 gnat1$(exeext): $(TARGET_ADA_SRCS) $(GNAT1_OBJS) $(ADA_BACKEND) $(LIBDEPS)
-	$(GCC_LINK) -o $@ $(GNAT1_OBJS) $(ADA_BACKEND) $(LIBS) $(SYSLIBS) $(GMPLIBS) $(CFLAGS)
+	$(GCC_LINK) -o $@ $(GNAT1_OBJS) $(ADA_BACKEND) $(LIBS) $(SYSLIBS) $(BACKENDLIBS) $(CFLAGS)
 	$(RM) stamp-gnatlib2-rts stamp-tools
 
 gnatbind$(exeext): ada/b_gnatb.o $(CONFIG_H) $(GNATBIND_OBJS)
Index: gcc/fortran/Make-lang.in
===================================================================
--- gcc/fortran/Make-lang.in	(revision 142224)
+++ gcc/fortran/Make-lang.in	(working copy)
@@ -98,7 +98,7 @@ gfortran-cross$(exeext): gfortran$(exeex
 f951$(exeext): $(F95_OBJS) \
 		$(BACKEND) $(LIBDEPS) attribs.o
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
-		$(F95_OBJS) $(BACKEND) $(LIBS) attribs.o $(GMPLIBS)
+		$(F95_OBJS) $(BACKEND) $(LIBS) attribs.o $(BACKENDLIBS)
 
 gt-fortran-trans.h    : s-gtype; @true
 #\f
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in	(revision 142224)
+++ gcc/Makefile.in	(working copy)
@@ -920,9 +920,8 @@ BUILD_LIBDEPS= $(BUILD_LIBIBERTY)
 
 # How to link with both our special library facilities
 # and the system's installed libraries.
-LIBS = @LIBS@ $(CPPLIB) $(LIBINTL) $(LIBICONV) $(LIBIBERTY) $(LIBDECNUMBER) \
-       $(GMPLIBS) $(CLOOGLIBS) $(PPLLIBS)
-
+LIBS = @LIBS@ $(CPPLIB) $(LIBINTL) $(LIBICONV) $(LIBIBERTY) $(LIBDECNUMBER)
+BACKENDLIBS = $(GMPLIBS) $(CLOOGLIBS) $(PPLLIBS)
 # Any system libraries needed just for GNAT.
 SYSLIBS = @GNAT_LIBEXC@
 
@@ -1655,7 +1654,7 @@ dummy-checksum.o : dummy-checksum.c
 
 cc1-dummy$(exeext): $(C_OBJS) dummy-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) dummy-checksum.o \
-	  $(BACKEND) $(LIBS) $(GMPLIBS)
+	  $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 cc1-checksum.c : cc1-dummy$(exeext) build/genchecksum$(build_exeext)
 	build/genchecksum$(build_exeext) cc1-dummy$(exeext) > $@
@@ -1664,7 +1663,7 @@ cc1-checksum.o : cc1-checksum.c
 
 cc1$(exeext): $(C_OBJS) cc1-checksum.o $(BACKEND) $(LIBDEPS)
 	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) cc1-checksum.o \
-	  $(BACKEND) $(LIBS) $(GMPLIBS)
+	  $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 #\f
 # Build libgcc.a.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2008-11-25 23:10 ` ghazi at gcc dot gnu dot org
@ 2008-11-26 18:21 ` sebpop at gmail dot com
  2008-11-26 19:12 ` ghazi at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: sebpop at gmail dot com @ 2008-11-26 18:21 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from sebpop at gmail dot com  2008-11-26 18:20 -------
Subject: Re:  [4.4 regression] GCC components unnecessarily link with shared
gmp/mpfr

Thanks for catching the missing parts.
Here is the updated patch.  Does this patch look correct?
I sent this patch to test on the gccfarm and will send an email to
gcc-patches after it completes regstrap.

Thanks,
Sebastian

On Tue, Nov 25, 2008 at 5:08 PM, ghazi at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #2 from ghazi at gcc dot gnu dot org  2008-11-25 23:08 -------
> (In reply to comment #1)
>> Subject: Re:  New: [4.4 regression] GCC components unnecessarily link with
>> shared gmp/mpfr
>> Here is a patch from Dwarak for fixing this.
>> He will send this to review on gcc-patches@ list.
>> Sebastian Pop
>> --
>> AMD - GNU Tools
>
> Thanks, however I don't understand why in this patch xgcc and cpp are being
> linked with BACKENDLIBS.  They don't linked with libbackend.a.
>
> Also, there are many more places where you do need to add BACKENDLIBS like
> cc1plus, cc1obj, f951, jc1, etc.  See here for all the places you'll need to
> catch:
>
> http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00187.html
>
>
> --
>
> ghazi at gcc dot gnu dot org changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>             Status|UNCONFIRMED                 |NEW
>     Ever Confirmed|0                           |1
>   Last reconfirmed|0000-00-00 00:00:00         |2008-11-25 23:08:54
>               date|                            |
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262
>
>


------- Comment #4 from sebpop at gmail dot com  2008-11-26 18:20 -------
Created an attachment (id=16780)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16780&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2008-11-26 18:21 ` sebpop at gmail dot com
@ 2008-11-26 19:12 ` ghazi at gcc dot gnu dot org
  2008-11-28  9:40 ` jakub at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: ghazi at gcc dot gnu dot org @ 2008-11-26 19:12 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from ghazi at gcc dot gnu dot org  2008-11-26 19:11 -------
(In reply to comment #3)
> Subject: Re:  [4.4 regression] GCC components unnecessarily link with shared
> gmp/mpfr
> Thanks for catching the missing parts.
> Here is the updated patch.  Does this patch look correct?

Yes it looks correct, thanks for working on it.

--Kaveh


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2008-11-26 19:12 ` ghazi at gcc dot gnu dot org
@ 2008-11-28  9:40 ` jakub at gcc dot gnu dot org
  2008-12-05  6:34   ` Sebastian Pop
  2008-12-05  6:35 ` sebpop at gmail dot com
                   ` (3 subsequent siblings)
  10 siblings, 1 reply; 14+ messages in thread
From: jakub at gcc dot gnu dot org @ 2008-11-28  9:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from jakub at gcc dot gnu dot org  2008-11-28 09:38 -------
The patch looks good to me (if not obvious).  Sebastian, are you going to post
it to gcc-patches?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-28  9:40 ` jakub at gcc dot gnu dot org
@ 2008-12-05  6:34   ` Sebastian Pop
  0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Pop @ 2008-12-05  6:34 UTC (permalink / raw)
  To: gcc-bugzilla; +Cc: gcc-bugs

On Fri, Nov 28, 2008 at 3:38 AM, jakub at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
> The patch looks good to me (if not obvious).  Sebastian, are you going to post
> it to gcc-patches?

I just sent it to gcc-patches.
Sorry this took me so long to send: it went out of my radar.

Sebastian


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2008-11-28  9:40 ` jakub at gcc dot gnu dot org
@ 2008-12-05  6:35 ` sebpop at gmail dot com
  2008-12-05  8:04 ` spop at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: sebpop at gmail dot com @ 2008-12-05  6:35 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from sebpop at gmail dot com  2008-12-05 06:34 -------
Subject: Re:  [4.4 regression] GCC components unnecessarily link with shared
gmp/mpfr

On Fri, Nov 28, 2008 at 3:38 AM, jakub at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
> The patch looks good to me (if not obvious).  Sebastian, are you going to post
> it to gcc-patches?

I just sent it to gcc-patches.
Sorry this took me so long to send: it went out of my radar.

Sebastian


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2008-12-05  6:35 ` sebpop at gmail dot com
@ 2008-12-05  8:04 ` spop at gcc dot gnu dot org
  2008-12-05  8:06 ` spop at gcc dot gnu dot org
  2008-12-05  8:53 ` jakub at gcc dot gnu dot org
  10 siblings, 0 replies; 14+ messages in thread
From: spop at gcc dot gnu dot org @ 2008-12-05  8:04 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from spop at gcc dot gnu dot org  2008-12-05 08:03 -------
Subject: Bug 38262

Author: spop
Date: Fri Dec  5 08:01:58 2008
New Revision: 142464

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142464
Log:
2008-11-07  Sebastian Pop  <sebastian.pop@amd.com>

        PR bootstrap/38262
        * java/Make-lang.in (jc1): Add BACKENDLIBS, remove GMPLIBS.
        * objc/Make-lang.in (cc1obj-dummy, cc1obj): Same.
        * objcp/Make-lang.in (cc1objplus-dummy, cc1objplus): Same.
        * cp/Make-lang.in (cc1plus-dummy, cc1plus): Same.
        * ada/gcc-interface/Make-lang.in (gnat1): Same.
        * fortran/Make-lang.in (f951): Same.
        * Makefile.in (LIBS): Remove GMPLIBS, CLOOGLIBS and PPLLIBS.
        (BACKENDLIBS): New.
        (cc1-dummy, cc1): Add BACKENDLIBS, remove GMPLIBS.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/ada/gcc-interface/Make-lang.in
    trunk/gcc/cp/Make-lang.in
    trunk/gcc/fortran/Make-lang.in
    trunk/gcc/java/Make-lang.in
    trunk/gcc/objc/Make-lang.in
    trunk/gcc/objcp/Make-lang.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2008-12-05  8:04 ` spop at gcc dot gnu dot org
@ 2008-12-05  8:06 ` spop at gcc dot gnu dot org
  2008-12-05  8:53 ` jakub at gcc dot gnu dot org
  10 siblings, 0 replies; 14+ messages in thread
From: spop at gcc dot gnu dot org @ 2008-12-05  8:06 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from spop at gcc dot gnu dot org  2008-12-05 08:02 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Bug bootstrap/38262] [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr
  2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2008-12-05  8:06 ` spop at gcc dot gnu dot org
@ 2008-12-05  8:53 ` jakub at gcc dot gnu dot org
  10 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu dot org @ 2008-12-05  8:53 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #10 from jakub at gcc dot gnu dot org  2008-12-05 08:52 -------
Subject: Bug 38262

Author: jakub
Date: Fri Dec  5 08:50:47 2008
New Revision: 142466

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142466
Log:
        PR bootstrap/38262
        Fixup ChangeLog entries.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ada/ChangeLog
    trunk/gcc/cp/ChangeLog
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/java/ChangeLog
    trunk/gcc/objc/ChangeLog
    trunk/gcc/objcp/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38262


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2008-12-05  8:53 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-25 16:02 [Bug bootstrap/38262] New: [4.4 regression] GCC components unnecessarily link with shared gmp/mpfr ghazi at gcc dot gnu dot org
2008-11-25 16:27 ` [Bug bootstrap/38262] " pinskia at gcc dot gnu dot org
2008-11-25 20:25 ` [Bug bootstrap/38262] New: " Sebastian Pop
2008-11-25 20:27 ` [Bug bootstrap/38262] " sebpop at gmail dot com
2008-11-25 23:10 ` ghazi at gcc dot gnu dot org
2008-11-26 18:19   ` Sebastian Pop
2008-11-26 18:21 ` sebpop at gmail dot com
2008-11-26 19:12 ` ghazi at gcc dot gnu dot org
2008-11-28  9:40 ` jakub at gcc dot gnu dot org
2008-12-05  6:34   ` Sebastian Pop
2008-12-05  6:35 ` sebpop at gmail dot com
2008-12-05  8:04 ` spop at gcc dot gnu dot org
2008-12-05  8:06 ` spop at gcc dot gnu dot org
2008-12-05  8:53 ` jakub at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).