[Bug rtl-optimization/38280] New: [4.3 Regression] Revision 142207 breaks 416.gamess/481.wrf/ in SPEC CPU 2006

[Bug rtl-optimization/38280] New: [4.3 Regression] Revision 142207 breaks 416.gamess/481.wrf/ in SPEC CPU 2006

[hjl dot tools at gmail dot com]

On Linux/ia32, revision 142207 caused:

gfortran -m32 -c -o mctwo.fppized.o    -O2 -mfpmath=sse -mssse3        
-ffixed-form       mctwo.fppized.f
bad allocation for 2046 and 3100
mctwo.fppized.f: In function 'lh2ddi':
mctwo.fppized.f:3996: internal compiler error: in check_allocation, at
ira.c:1568
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
specmake: *** [mctwo.fppized.o] Error 1
Stop make command: Wed Nov 26 18:11:07 2008 (1227694267)
Elapsed time for make command: 00:03:08 (188) 
Error with make 'specmake build': check file
'/home/wlin5/cpu2006/benchspec/CPU2006/416.gamess/run/build_base_lnx32.0001/make.err'

gfortran -m32 -c -o module_ra_gfdleta.fppized.o -I. -I./netcdf/include   -O2
-mfpmath=sse -mssse3       -DSPEC_CPU_LINUX -DSPEC_CPU_CASE_FLAG
-DSPEC_CPU_LOGICAL_STRICT -frecord-marker=4       
module_ra_gfdleta.fppized.f90
module_ra_gfdleta.fppized.f90: In function 'spa88':
module_ra_gfdleta.fppized.f90:4713: internal compiler error: in
push_allocno_to_stack, at ira-color.c:882
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
specmake: *** [module_ra_gfdleta.fppized.o] Error 1
Stop make command: Wed Nov 26 18:25:42 2008 (1227695142)
Elapsed time for make command: 00:01:33 (93)
Error with make 'specmake build': check file
'/home/wlin5/cpu2006/benchspec/CPU2006/481.wrf/run/build_base_lnx32.0000/make.err'

Gcc is configured with --enable-checking.


-- 
           Summary: [4.3 Regression]  Revision 142207 breaks
                    416.gamess/481.wrf/ in SPEC CPU 2006
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[jsm28 at gcc dot gnu dot org]

------- Comment #1 from jsm28 at gcc dot gnu dot org  2008-11-27 17:32 -------
Setting to P4, please restore to P3 if a C or C++ test showing this problem is
found.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[vmakarov at redhat dot com]

------- Comment #2 from vmakarov at redhat dot com  2008-11-27 20:32 -------
  The problem was in violation of allocno order in regno_allocno_map list. 
This order is very important for many algorithms (allocno info propagation,
conflict propagation and IR flattening).  For example,

loop 0:
     no usage of R
  loop 1:
     a1 representing R
  loop 2:
     a2 representing R

After removing Loop1, we move a1 to loop 0.  Allocnos on upper levels should be
after allocnos on lower levels in regno_allocno_map list.  Before removing loop
we had a1 a2 in the list which is ok because they are on the same loop level. 
After removing loop 1, we have again a1 and a2 which is not ok because a1 now
corresponds to loop 0 containing loop 1 and as a consequence should be after
a2.

  We had no problem before the patch because we removed always a loop and all
its subloops (removing loops based on register pressure) and the order
violation was not possible.

  I'll submit a patch solving the problem today.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[hjl at gcc dot gnu dot org]

------- Comment #3 from hjl at gcc dot gnu dot org  2008-11-27 23:30 -------
Subject: Bug 38280

Author: hjl
Date: Thu Nov 27 23:28:44 2008
New Revision: 142250

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142250
Log:
2008-11-27  Vladimir Makarov  <vmakarov@redhat.com>

        PR rtl-optimization/38280
        * ira-build.c (loop_is_inside_p, regno_allocno_order_compare_func,
        ira_rebuild_regno_allocno_list): New functions.
        (regno_allocnos): New static variable.
        (remove_unnecessary_allocnos): Allocate/deallocate regno_allocnos.
        Call ira_rebuild_regno_allocno_list.

Modified:
    branches/ira-merge/gcc/ChangeLog.ira
    branches/ira-merge/gcc/ira-build.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[Joey dot ye at intel dot com]

------- Comment #4 from Joey dot ye at intel dot com  2008-11-28 03:39 -------
142250 doesn't fix this regression. 416.gamess and 481.wrf still fail.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[hjl dot tools at gmail dot com]

------- Comment #5 from hjl dot tools at gmail dot com  2008-11-28 08:42 -------
(In reply to comment #4)
> 142250 doesn't fix this regression. 416.gamess and 481.wrf still fail.
> 

Revision 142250 is for ira-merge branch. Please try

http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01428.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[Joey dot ye at intel dot com]

------- Comment #6 from Joey dot ye at intel dot com  2008-11-28 15:11 -------
Patch at http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01428.html fixed this
regression.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[hjl dot tools at gmail dot com]

------- Comment #7 from hjl dot tools at gmail dot com  2008-11-28 15:20 -------
(In reply to comment #6)
> Patch at http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01428.html fixed this
> regression.
> 

481.wrf also failed on Intel64. Does this patch fix it?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[Joey dot ye at intel dot com]

------- Comment #8 from Joey dot ye at intel dot com  2008-12-01 02:18 -------
Yes. It fixes 416/481 on 32 bits and 481 on 64 bits.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[vmakarov at gcc dot gnu dot org]

------- Comment #9 from vmakarov at gcc dot gnu dot org  2008-12-02 00:17 -------
Subject: Bug 38280

Author: vmakarov
Date: Tue Dec  2 00:15:35 2008
New Revision: 142336

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142336
Log:
2008-12-01  Vladimir Makarov  <vmakarov@redhat.com>

        PR rtl-optimization/38280
        * ira-build.c (loop_is_inside_p, regno_allocno_order_compare_func,
        ira_rebuild_regno_allocno_list): New functions.
        (regno_allocnos): New static variable.
        (remove_unnecessary_allocnos): Allocate/deallocate regno_allocnos.
        Call ira_rebuild_regno_allocno_list.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ira-build.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280

[Bug rtl-optimization/38280] [4.4 regression] Revision 142207 breaks 416.gamess/481.wrf in SPEC CPU 2006

[hjl dot tools at gmail dot com]

------- Comment #10 from hjl dot tools at gmail dot com  2008-12-02 18:46 -------
Fixed as of revision 142345.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38280