[Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug debug/38101]  New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
@ 2008-11-13  4:12 d dot g dot gorbachev at gmail dot com
  2008-11-13  5:55 ` Andrew Thomas Pinski
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: d dot g dot gorbachev at gmail dot com @ 2008-11-13  4:12 UTC (permalink / raw)
  To: gcc-bugs

tree.c:

tree
decl_value_expr_lookup (tree from)
{
  ...
  return NULL_TREE;
}

tree.h:

#define DECL_VALUE_EXPR(NODE) \
  (decl_value_expr_lookup (DECL_WRTL_CHECK (NODE)))

dbxout.c:

static rtx
dbxout_expand_expr (tree expr)
{
  switch (TREE_CODE (expr))
  ...
    case PARM_DECL:
      if (DECL_HAS_VALUE_EXPR_P (expr))
        return dbxout_expand_expr (DECL_VALUE_EXPR (expr));
  ...
}


-- 
           Summary: dbxout_expand_expr() doesn't check return value of
                    DECL_VALUE_EXPR()
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: d dot g dot gorbachev at gmail dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i386-pc-mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Bug debug/38101]  New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
  2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
@ 2008-11-13  5:55 ` Andrew Thomas Pinski
  2008-11-13  5:57 ` [Bug debug/38101] " pinskia at gmail dot com
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: Andrew Thomas Pinski @ 2008-11-13  5:55 UTC (permalink / raw)
  To: gcc-bugzilla; +Cc: gcc-bugs



Sent from my iPhone

On Nov 12, 2008, at 8:11 PM, "d dot g dot gorbachev at gmail dot com" <gcc-bugzilla@gcc.gnu.org 
 > wrote:

> tree.c:
>
> tree
> decl_value_expr_lookup (tree from)
> {
>  ...
>  return NULL_TREE;
> }
>
> tree.h:
>
> #define DECL_VALUE_EXPR(NODE) \
>  (decl_value_expr_lookup (DECL_WRTL_CHECK (NODE)))
>
> dbxout.c:
>
> static rtx
> dbxout_expand_expr (tree expr)
> {
>  switch (TREE_CODE (expr))
>  ...
>    case PARM_DECL:
>      if (DECL_HAS_VALUE_EXPR_P (expr))
>        return dbxout_expand_expr (DECL_VALUE_EXPR (expr));

DECL_VALUE_EXPR should not return null if DECL_HAS_VALUE_EXPR_P  
returns true.

>
>  ...
> }
>
>
> -- 
>           Summary: dbxout_expand_expr() doesn't check return value of
>                    DECL_VALUE_EXPR()
>           Product: gcc
>           Version: 4.4.0
>            Status: UNCONFIRMED
>          Severity: normal
>          Priority: P3
>         Component: debug
>        AssignedTo: unassigned at gcc dot gnu dot org
>        ReportedBy: d dot g dot gorbachev at gmail dot com
> GCC build triplet: i686-pc-linux-gnu
>  GCC host triplet: i686-pc-linux-gnu
> GCC target triplet: i386-pc-mingw32
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101
>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/38101] dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
  2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
  2008-11-13  5:55 ` Andrew Thomas Pinski
@ 2008-11-13  5:57 ` pinskia at gmail dot com
  2008-11-13 19:22 ` pinskia at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: pinskia at gmail dot com @ 2008-11-13  5:57 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from pinskia at gmail dot com  2008-11-13 05:56 -------
Subject: Re:   New: dbxout_expand_expr() doesn't check return value of
DECL_VALUE_EXPR()



Sent from my iPhone

On Nov 12, 2008, at 8:11 PM, "d dot g dot gorbachev at gmail dot com"
<gcc-bugzilla@gcc.gnu.org 
 > wrote:

> tree.c:
>
> tree
> decl_value_expr_lookup (tree from)
> {
>  ...
>  return NULL_TREE;
> }
>
> tree.h:
>
> #define DECL_VALUE_EXPR(NODE) \
>  (decl_value_expr_lookup (DECL_WRTL_CHECK (NODE)))
>
> dbxout.c:
>
> static rtx
> dbxout_expand_expr (tree expr)
> {
>  switch (TREE_CODE (expr))
>  ...
>    case PARM_DECL:
>      if (DECL_HAS_VALUE_EXPR_P (expr))
>        return dbxout_expand_expr (DECL_VALUE_EXPR (expr));

DECL_VALUE_EXPR should not return null if DECL_HAS_VALUE_EXPR_P  
returns true.

>
>  ...
> }
>
>
> -- 
>           Summary: dbxout_expand_expr() doesn't check return value of
>                    DECL_VALUE_EXPR()
>           Product: gcc
>           Version: 4.4.0
>            Status: UNCONFIRMED
>          Severity: normal
>          Priority: P3
>         Component: debug
>        AssignedTo: unassigned at gcc dot gnu dot org
>        ReportedBy: d dot g dot gorbachev at gmail dot com
> GCC build triplet: i686-pc-linux-gnu
>  GCC host triplet: i686-pc-linux-gnu
> GCC target triplet: i386-pc-mingw32
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101
>


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/38101] dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
  2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
  2008-11-13  5:55 ` Andrew Thomas Pinski
  2008-11-13  5:57 ` [Bug debug/38101] " pinskia at gmail dot com
@ 2008-11-13 19:22 ` pinskia at gcc dot gnu dot org
  2008-11-14  1:48 ` d dot g dot gorbachev at gmail dot com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-11-13 19:22 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from pinskia at gcc dot gnu dot org  2008-11-13 19:21 -------
Can you explain why you think DECL_VALUE_EXPR will return a NULL if
DECL_HAS_VALUE_EXPR_P is set?  I don't see anywhere in the code which sets
DECL_HAS_VALUE_EXPR_P and does not insert something into the hash table.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/38101] dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
  2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
                   ` (2 preceding siblings ...)
  2008-11-13 19:22 ` pinskia at gcc dot gnu dot org
@ 2008-11-14  1:48 ` d dot g dot gorbachev at gmail dot com
  2008-11-19  4:38 ` d dot g dot gorbachev at gmail dot com
  2008-11-29 13:09 ` [Bug pch/38101] " d dot g dot gorbachev at gmail dot com
  5 siblings, 0 replies; 8+ messages in thread
From: d dot g dot gorbachev at gmail dot com @ 2008-11-14  1:48 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from d dot g dot gorbachev at gmail dot com  2008-11-14 01:47 -------
Example (11MB archive) - http://www.divshare.com/download/5809022-31c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/38101] dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
  2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
                   ` (3 preceding siblings ...)
  2008-11-14  1:48 ` d dot g dot gorbachev at gmail dot com
@ 2008-11-19  4:38 ` d dot g dot gorbachev at gmail dot com
  2008-11-29 13:09 ` [Bug pch/38101] " d dot g dot gorbachev at gmail dot com
  5 siblings, 0 replies; 8+ messages in thread
From: d dot g dot gorbachev at gmail dot com @ 2008-11-19  4:38 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from d dot g dot gorbachev at gmail dot com  2008-11-19 04:37 -------
Created an attachment (id=16720)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16720&action=view)
Example

Disregard the previous comment.

Segmentation fault in GCC.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug pch/38101] dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
  2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
                   ` (4 preceding siblings ...)
  2008-11-19  4:38 ` d dot g dot gorbachev at gmail dot com
@ 2008-11-29 13:09 ` d dot g dot gorbachev at gmail dot com
  5 siblings, 0 replies; 8+ messages in thread
From: d dot g dot gorbachev at gmail dot com @ 2008-11-29 13:09 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from d dot g dot gorbachev at gmail dot com  2008-11-29 13:08 -------
Hash table entries should be reordered when writing a PCH.


-- 

d dot g dot gorbachev at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|debug                       |pch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug pch/38101] dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR()
       [not found] <bug-38101-4@http.gcc.gnu.org/bugzilla/>
@ 2011-09-10 18:32 ` d.g.gorbachev at gmail dot com
  0 siblings, 0 replies; 8+ messages in thread
From: d.g.gorbachev at gmail dot com @ 2011-09-10 18:32 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38101

Dmitry Gorbachev <d.g.gorbachev at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #6 from Dmitry Gorbachev <d.g.gorbachev at gmail dot com> 2011-09-10 18:30:42 UTC ---
Can't reproduce.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-09-10 18:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-13  4:12 [Bug debug/38101] New: dbxout_expand_expr() doesn't check return value of DECL_VALUE_EXPR() d dot g dot gorbachev at gmail dot com
2008-11-13  5:55 ` Andrew Thomas Pinski
2008-11-13  5:57 ` [Bug debug/38101] " pinskia at gmail dot com
2008-11-13 19:22 ` pinskia at gcc dot gnu dot org
2008-11-14  1:48 ` d dot g dot gorbachev at gmail dot com
2008-11-19  4:38 ` d dot g dot gorbachev at gmail dot com
2008-11-29 13:09 ` [Bug pch/38101] " d dot g dot gorbachev at gmail dot com
     [not found] <bug-38101-4@http.gcc.gnu.org/bugzilla/>
2011-09-10 18:32 ` d.g.gorbachev at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).