[Bug target/37843] New: [4.4 Regression] unaligned stack in main due to tail call optimization

[Bug target/37843] New: [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

[hjl@gnu-6 880]$ cat x.c
extern int foo ();

int main()
{
    return foo();
}
[hjl@gnu-6 880]$ rm x.s
[hjl@gnu-6 880]$ cat x.c
extern int foo ();

int main()
{
    return foo();
}
[hjl@gnu-6 880]$ make
/export/gnu/import/svn/gcc-test/bld/gcc/xgcc
-B/export/gnu/import/svn/gcc-test/bld/gcc/ -O2 -m32 -S -o x.s x.c
[hjl@gnu-6 880]$ cat x.s
        .file   "x.c"
        .text
        .p2align 4,,15
.globl main
        .type   main, @function
main:
        pushl   %ebp
        movl    %esp, %ebp
        subl    $8, %esp
        leave
        jmp     foo

The stack isn't aligned to 16byte.
        .size   main, .-main


-- 
           Summary: [4.4 Regression] unaligned stack in main due to tail
                    call optimization
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com
GCC target triplet: i686-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug target/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #1 from hjl dot tools at gmail dot com  2008-10-16 01:06 -------
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00670.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |10/msg00670.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug target/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #2 from hjl dot tools at gmail dot com  2008-10-16 22:14 -------
An updated patch is at

http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00724.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |http://gcc.gnu.org/ml/gcc-
                   |patches/2008-               |patches/2008-
                   |10/msg00670.html            |10/msg00724.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug target/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de
           Keywords|                            |wrong-code
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #3 from hjl dot tools at gmail dot com  2008-11-01 00:25 -------
I changed it to middle-end.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|target                      |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-11-01 11:36 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
 GCC target triplet|i686-*                      |i?86-*-*
      Known to fail|                            |4.4.0
      Known to work|                            |4.3.2
           Priority|P3                          |P1
   Last reconfirmed|0000-00-00 00:00:00         |2008-11-01 11:36:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #5 from hjl dot tools at gmail dot com  2008-11-05 14:32 -------
The updated patch is at

http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00130.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |http://gcc.gnu.org/ml/gcc-
                   |patches/2008-               |patches/2008-
                   |10/msg00724.html            |11/msg00130.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #6 from hjl dot tools at gmail dot com  2008-11-11 06:49 -------
The current patch is at

http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00180.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |http://gcc.gnu.org/ml/gcc-
                   |patches/2008-               |patches/2008-
                   |11/msg00130.html            |11/msg00180.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[steven at gcc dot gnu dot org]

------- Comment #7 from steven at gcc dot gnu dot org  2008-11-18 21:34 -------
P1 bug with a pending patch... maybe a reviewer could take a look at this
(seemingly trivial) patch at
http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00180.html
?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl at gcc dot gnu dot org]

------- Comment #8 from hjl at gcc dot gnu dot org  2008-11-25 15:34 -------
Subject: Bug 37843

Author: hjl
Date: Tue Nov 25 15:33:27 2008
New Revision: 142193

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142193
Log:
gcc/

2008-11-25  H.J. Lu  <hongjiu.lu@intel.com>
            Joey Ye  <joey.ye@intel.com>

        PR middle-end/37843
        * config/i386/i386.c (ix86_function_ok_for_sibcall): Return
        false if we need to align the outgoing stack.
        (ix86_update_stack_boundary): Check parm_stack_boundary.

gcc/testsuite/

2008-11-25  H.J. Lu  <hongjiu.lu@intel.com>

        PR middle-end/37843
        * gcc.target/i386/align-main-3.c: New.
        * gcc.target/i386/pr37843-1.c: Likewise.
        * gcc.target/i386/pr37843-2.c: Likewise.
        * gcc.target/i386/pr37843-3.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.target/i386/align-main-3.c
    trunk/gcc/testsuite/gcc.target/i386/pr37843-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr37843-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr37843-3.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[howarth at nitro dot med dot uc dot edu]

------- Comment #9 from howarth at nitro dot med dot uc dot edu  2008-11-26 04:25 -------
On i686-apple-darwin9, we are failing...

FAIL: gcc.target/i386/pr37843-1.c scan-assembler call[\\t ]*foo
FAIL: gcc.target/i386/pr37843-2.c scan-assembler jmp[\\t ]*foo

at revision 142207.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[howarth at nitro dot med dot uc dot edu]

------- Comment #10 from howarth at nitro dot med dot uc dot edu  2008-11-26 04:26 -------
Created an attachment (id=16773)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16773&action=view)
assembly file for gcc.target/i386/pr37843-1.c on i686-apple-darwin9

Created with...

/sw/src/fink.build/gcc44-4.3.999-20081125/darwin_objdir/gcc/xgcc
-B/sw/src/fink.build/gcc44-4.3.999-20081125/darwin_objdir/gcc/
/sw/src/fink.build/gcc44-4.3.999-20081125/gcc-4.4-20081125/gcc/testsuite/gcc.target/i386/pr37843-1.c
  -O2 -mpreferred-stack-boundary=6 -mincoming-stack-boundary=5 -S  -m32 -o
pr37843-1.s


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[howarth at nitro dot med dot uc dot edu]

------- Comment #11 from howarth at nitro dot med dot uc dot edu  2008-11-26 04:28 -------
Created an attachment (id=16774)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16774&action=view)
assembly file for gcc.target/i386/pr37843-2.c on i686-apple-darwin9

Created with...

/sw/src/fink.build/gcc44-4.3.999-20081125/darwin_objdir/gcc/xgcc
-B/sw/src/fink.build/gcc44-4.3.999-20081125/darwin_objdir/gcc/
/sw/src/fink.build/gcc44-4.3.999-20081125/gcc-4.4-20081125/gcc/testsuite/gcc.target/i386/pr37843-2.c
  -O2 -mpreferred-stack-boundary=6 -mincoming-stack-boundary=6 -S  -m32 -o
pr37843-2.s


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #12 from hjl dot tools at gmail dot com  2008-11-26 05:38 -------
I don't think sibcall work on Darwin. Can you skip them on Darwin?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[howarth at nitro dot med dot uc dot edu]

------- Comment #13 from howarth at nitro dot med dot uc dot edu  2008-11-26 12:23 -------
Why do we have...

/* { dg-do compile { target { *-*-linux* && ilp32 } } } */

in gcc.target/i386/align-main-3.c and gcc.target/i386/pr37843-3.c
but not gcc.target/i386/pr37843-1.c and gcc.target/i386/pr37843-2.c?
Isn't that the origin of the problem on darwin?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl at gcc dot gnu dot org]

------- Comment #14 from hjl at gcc dot gnu dot org  2008-11-26 14:53 -------
Subject: Bug 37843

Author: hjl
Date: Wed Nov 26 14:52:12 2008
New Revision: 142222

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142222
Log:
2008-11-26  H.J. Lu  <hongjiu.lu@intel.com>

        PR middle-end/37843
        * gcc.target/i386/pr37843-1.c: Make it Linux only.
        * gcc.target/i386/pr37843-2.c: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/pr37843-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr37843-2.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl at gcc dot gnu dot org]

------- Comment #15 from hjl at gcc dot gnu dot org  2008-11-28 16:32 -------
Subject: Bug 37843

Author: hjl
Date: Fri Nov 28 16:30:56 2008
New Revision: 142259

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142259
Log:
2008-11-28  H.J. Lu  <hongjiu.lu@intel.com>

        PR middle-end/37843
        * gcc.target/i386/pr37843-1.c: Make it nonpic targets only.
        * gcc.target/i386/pr37843-2.c: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/pr37843-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr37843-2.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl at gcc dot gnu dot org]

------- Comment #16 from hjl at gcc dot gnu dot org  2008-11-29 16:33 -------
Subject: Bug 37843

Author: hjl
Date: Sat Nov 29 16:32:35 2008
New Revision: 142278

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142278
Log:
2008-11-29  H.J. Lu  <hongjiu.lu@intel.com>

        PR middle-end/37843
        * gcc.target/i386/pr37843-3.c: Make it nonpic targets only.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/pr37843-3.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[jakub at gcc dot gnu dot org]

------- Comment #17 from jakub at gcc dot gnu dot org  2008-11-29 21:04 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #18 from hjl dot tools at gmail dot com  2008-11-29 21:10 -------
It isn't totally fixed:

FAIL: gcc.target/i386/pr37843-3.c scan-assembler-not call[\\\\t ]*foo
FAIL: gcc.target/i386/pr37843-3.c scan-assembler jmp[\\\\t ]*foo

I only checked in x86 backend change since no one has reviewed the
middle-end change:

http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01309.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |http://gcc.gnu.org/ml/gcc-
                   |patches/2008-               |patches/2008-
                   |11/msg00180.html            |11/msg01309.html
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[rguenther at suse dot de]

------- Comment #19 from rguenther at suse dot de  2008-11-30 11:19 -------
Subject: Re:  [4.4 Regression] unaligned stack in main
 due to tail call optimization

On Sat, 29 Nov 2008, hjl dot tools at gmail dot com wrote:

> ------- Comment #18 from hjl dot tools at gmail dot com  2008-11-29 21:10 -------
> It isn't totally fixed:
> 
> FAIL: gcc.target/i386/pr37843-3.c scan-assembler-not call[\\\\t ]*foo
> FAIL: gcc.target/i386/pr37843-3.c scan-assembler jmp[\\\\t ]*foo
> 
> I only checked in x86 backend change

Which is if course not the right thing to do without XFAILing the
new testcases...

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[mmitchel at gcc dot gnu dot org]

------- Comment #20 from mmitchel at gcc dot gnu dot org  2008-12-09 19:34 -------
HJ --

As Richard says, you should not have checked in the new testcases without
XFAILs and without having fixed the bug.

Furthermore, your patch to the middle-end is without explanation.  What is the
problem?  How does your patch fix the problem?

-- Mark


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #21 from hjl dot tools at gmail dot com  2008-12-09 22:34 -------
Created an attachment (id=16868)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16868&action=view)
An updated patch

This patch adds some comments to middle-end change. It also
replaces _Decimal128 with __m128 in gcc.target/i386/pr37843-3.c
so that it can run for all ia32 targets.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #22 from hjl dot tools at gmail dot com  2008-12-09 22:36 -------
(In reply to comment #20)
> HJ --
> 
> As Richard says, you should not have checked in the new testcases without
> XFAILs and without having fixed the bug.
> 
> Furthermore, your patch to the middle-end is without explanation.  What is the
> problem?  How does your patch fix the problem?
> 

Hi Mark,

Thanks for looking into this. I uploaded a new patch at

http://gcc.gnu.org/bugzilla/attachment.cgi?id=16868

with comments to middle-end changes.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[jakub at gcc dot gnu dot org]

------- Comment #23 from jakub at gcc dot gnu dot org  2009-01-15 15:08 -------
Please s/incomoing/incoming/g in the patch.  Otherwise the patch makes a lot of
sense to me.  As INCOMING_STACK_BOUNDARY is used not only in
expand_stack_alignment, but also in 386's targetm.function_ok_for_sibcall (and
i386 is the only target that has variable INCOMING_STACK_BOUNDARY ATM).  This
target hook is called from expand_call, indirectly from
expand_gimple_basic_block.  expand_stack_alignment is called after all the
expand_gimple_basic_block calls, and the patch moves INCOMING_STACK_BOUNDARY
initialization before those calls.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl dot tools at gmail dot com]

------- Comment #24 from hjl dot tools at gmail dot com  2009-01-15 15:18 -------
Created an attachment (id=17107)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17107&action=view)
Here is the updated patch.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16868|0                           |1
        is obsolete|                            |
         AssignedTo|unassigned at gcc dot gnu   |hjl dot tools at gmail dot
                   |dot org                     |com
             Status|REOPENED                    |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[dnovillo at gcc dot gnu dot org]

------- Comment #25 from dnovillo at gcc dot gnu dot org  2009-01-15 15:23 -------
(In reply to comment #24)
> Created an attachment (id=17107)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17107&action=view) [edit]
> Here is the updated patch.

OK.


Diego.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[hjl at gcc dot gnu dot org]

------- Comment #26 from hjl at gcc dot gnu dot org  2009-01-15 15:44 -------
Subject: Bug 37843

Author: hjl
Date: Thu Jan 15 15:44:41 2009
New Revision: 143400

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143400
Log:
gcc/

2009-01-15  H.J. Lu  <hongjiu.lu@intel.com>
            Joey Ye  <joey.ye@intel.com>

        PR middle-end/37843
        * cfgexpand.c (expand_stack_alignment): Don't update stack
        boundary nor check incoming stack boundary here.
        (gimple_expand_cfg): Update stack boundary and check incoming
        stack boundary here.

gcc/testsuite/

2009-01-15  H.J. Lu  <hongjiu.lu@intel.com>

        PR middle-end/37843
        * gcc.target/i386/pr37843-3.c: Replace _Decimal128 with __m128.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/pr37843-3.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843

[Bug middle-end/37843] [4.4 Regression] unaligned stack in main due to tail call optimization

[jakub at gcc dot gnu dot org]

------- Comment #27 from jakub at gcc dot gnu dot org  2009-01-15 16:28 -------
Fixed, thanks.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37843