public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/38459]  New: [graphite] SEGFAULT in cloog_clast_create
@ 2008-12-09 20:15 grosser at gcc dot gnu dot org
  2008-12-09 20:19 ` [Bug middle-end/38459] " grosser at gcc dot gnu dot org
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: grosser at gcc dot gnu dot org @ 2008-12-09 20:15 UTC (permalink / raw)
  To: gcc-bugs

In the current graphite branch we fail with a SEGFAULT.

#0  0x28ed1fb1 in _malloc_prefork () from /lib/libc.so.7
#1  0x28ed6f45 in realloc () from /lib/libc.so.7
#2  0x28c9d019 in __gmp_default_reallocate () from /usr/local/lib/libgmp.so.7
#3  0x28cb0a4e in __gmpz_realloc () from /usr/local/lib/libgmp.so.7
#4  0x28cb14ce in __gmpz_set () from /usr/local/lib/libgmp.so.7
#5  0x28ce44ec in insert_loop (loop=0x291b56e0, level=4, scalar=0,
next=0xbfbfe7f0, infos=0x291b53c0)
    at source/ppl/clast.c:1446
#6  0x28ce46fd in insert_loop (loop=0x291b5340, level=3, scalar=0,
next=0xbfbfe7f0, infos=0x291b53c0)
    at source/ppl/clast.c:1480
#7  0x28ce46fd in insert_loop (loop=0x291b53e0, level=2, scalar=0,
next=0xbfbfe7f0, infos=0x291b53c0)
    at source/ppl/clast.c:1480
#8  0x28ce46fd in insert_loop (loop=0x291b5360, level=1, scalar=0,
next=0xbfbfe7f0, infos=0x291b53c0)
    at source/ppl/clast.c:1480
#9  0x28ce492f in cloog_clast_create (program=0x2910bfe0, options=0x2916f1c0)
at source/ppl/clast.c:1518
#10 0x08a15cf2 in find_transform (scop=0x29132310) at
../../../git/gcc/graphite.c:4238
#11 0x08a189a8 in graphite_transform_loops () at
../../../git/gcc/graphite.c:5386

It seems we do not initialize the cloog data structures correct or there is a
bug in cloog.


-- 
           Summary: [graphite] SEGFAULT in cloog_clast_create
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: grosser at gcc dot gnu dot org
        ReportedBy: grosser at gcc dot gnu dot org
OtherBugsDependingO 37894
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
@ 2008-12-09 20:19 ` grosser at gcc dot gnu dot org
  2008-12-09 20:28 ` grosser at gcc dot gnu dot org
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: grosser at gcc dot gnu dot org @ 2008-12-09 20:19 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from grosser at gcc dot gnu dot org  2008-12-09 20:17 -------
Created an attachment (id=16855)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16855&action=view)
Add reduced testcase from mltfftsg.F CP2K


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
  2008-12-09 20:19 ` [Bug middle-end/38459] " grosser at gcc dot gnu dot org
@ 2008-12-09 20:28 ` grosser at gcc dot gnu dot org
  2008-12-09 20:44 ` jv244 at cam dot ac dot uk
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: grosser at gcc dot gnu dot org @ 2008-12-09 20:28 UTC (permalink / raw)
  To: gcc-bugs



-- 

grosser at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-12-09 20:26:08
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
  2008-12-09 20:19 ` [Bug middle-end/38459] " grosser at gcc dot gnu dot org
  2008-12-09 20:28 ` grosser at gcc dot gnu dot org
@ 2008-12-09 20:44 ` jv244 at cam dot ac dot uk
  2008-12-09 20:48 ` jv244 at cam dot ac dot uk
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jv244 at cam dot ac dot uk @ 2008-12-09 20:44 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from jv244 at cam dot ac dot uk  2008-12-09 20:43 -------
(In reply to comment #0)

similar stack trace for the segfault in harris_force_types.F:

0  0x00002b3cbe554066 in realloc () from /lib64/libc.so.6
#1  0x00002b3cbd66098c in __gmp_default_reallocate () from
/usr/lib64/libgmp.so.3
#2  0x00002b3cbd675a21 in __gmpz_realloc () from /usr/lib64/libgmp.so.3
#3  0x00002b3cbd676554 in __gmpz_set () from /usr/lib64/libgmp.so.3
#4  0x00002b3cbd8a4dfc in insert_loop (loop=0x128e0a0, level=2, scalar=0,
next=0x7fffed66c930, infos=0x12a0910)
    at source/ppl/clast.c:1446
#5  0x00002b3cbd8a5367 in insert_loop (loop=0x128dfa0, level=1, scalar=0,
next=0x7fffed66c930, infos=0x12a0910)
    at source/ppl/clast.c:1480
#6  0x00002b3cbd8a5a41 in cloog_clast_create (program=0x128a590, options=<value
optimized out>) at source/ppl/clast.c:1518
#7  0x0000000000ae667d in find_transform (scop=0x1204710) at
/scratch/vondele/gcc/graphite/gcc/graphite.c:4238
#8  0x0000000000aede4b in graphite_transform_loops () at
/scratch/vondele/gcc/graphite/gcc/graphite.c:5382
#9  0x00000000007df337 in graphite_transforms () at
/scratch/vondele/gcc/graphite/gcc/tree-ssa-loop.c:298
#10 0x000000000066cb55 in execute_one_pass (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1279
#11 0x000000000066cd41 in execute_pass_list (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1328
#12 0x000000000066cd55 in execute_pass_list (pass=0x1082540) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329
#13 0x000000000066cd55 in execute_pass_list (pass=0x1081a00) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329
#14 0x000000000075dafc in tree_rest_of_compilation (fndecl=0x2b3cbefb3800) at
/scratch/vondele/gcc/graphite/gcc/tree-optimize.c:418
#15 0x00000000008d7ac0 in cgraph_expand_function (node=0x2b3cbf058300) at
/scratch/vondele/gcc/graphite/gcc/cgraphunit.c:1038
#16 0x00000000008d967d in cgraph_optimize () at
/scratch/vondele/gcc/graphite/gcc/cgraphunit.c:1097
#17 0x0000000000485ffa in gfc_be_parse_file (set_yydebug=<value optimized out>)
    at /scratch/vondele/gcc/graphite/gcc/fortran/f95-lang.c:240
#18 0x000000000070e55d in toplev_main (argc=<value optimized out>, argv=0x0) at
/scratch/vondele/gcc/graphite/gcc/toplev.c:968
#19 0x00002b3cbe4ffb54 in __libc_start_main () from /lib64/libc.so.6


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2008-12-09 20:44 ` jv244 at cam dot ac dot uk
@ 2008-12-09 20:48 ` jv244 at cam dot ac dot uk
  2008-12-09 21:06 ` jv244 at cam dot ac dot uk
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jv244 at cam dot ac dot uk @ 2008-12-09 20:48 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from jv244 at cam dot ac dot uk  2008-12-09 20:46 -------
(In reply to comment #0)

similar for fft_tools.F


0x00002ad42b5a4507 in __gmpz_set () from /usr/lib64/libgmp.so.3
(gdb) bt
#0  0x00002ad42b5a4507 in __gmpz_set () from /usr/lib64/libgmp.so.3
#1  0x00002ad42b7d2dfc in insert_loop (loop=0x16d8650, level=4, scalar=0,
next=0x7fff7f73e888, infos=0x12a40b0)
    at source/ppl/clast.c:1446
#2  0x00002ad42b7d3367 in insert_loop (loop=0x16d8870, level=3, scalar=0,
next=0x7fff7f73e888, infos=0x12a40b0)
    at source/ppl/clast.c:1480
#3  0x00002ad42b7d3367 in insert_loop (loop=0x16bece0, level=2, scalar=0,
next=0x7fff7f73e888, infos=0x12a40b0)
    at source/ppl/clast.c:1480
#4  0x00002ad42b7d33fd in insert_loop (loop=0x127e720, level=2, scalar=0,
next=0x7fff7f73ea00, infos=0x12a40b0)
    at source/ppl/clast.c:1489
#5  0x00002ad42b7d3367 in insert_loop (loop=0x12a4cc0, level=1, scalar=0,
next=0x7fff7f73ea00, infos=0x12a40b0)
    at source/ppl/clast.c:1480
#6  0x00002ad42b7d3a41 in cloog_clast_create (program=0x1285140, options=<value
optimized out>) at source/ppl/clast.c:1518
#7  0x0000000000ae667d in find_transform (scop=0x16bee50) at
/scratch/vondele/gcc/graphite/gcc/graphite.c:4238
#8  0x0000000000aede4b in graphite_transform_loops () at
/scratch/vondele/gcc/graphite/gcc/graphite.c:5382
#9  0x00000000007df337 in graphite_transforms () at
/scratch/vondele/gcc/graphite/gcc/tree-ssa-loop.c:298
#10 0x000000000066cb55 in execute_one_pass (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1279
#11 0x000000000066cd41 in execute_pass_list (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1328
#12 0x000000000066cd55 in execute_pass_list (pass=0x1082540) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329
#13 0x000000000066cd55 in execute_pass_list (pass=0x1081a00) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329
#14 0x000000000075dafc in tree_rest_of_compilation (fndecl=0x2ad42cf03400) at
/scratc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2008-12-09 20:48 ` jv244 at cam dot ac dot uk
@ 2008-12-09 21:06 ` jv244 at cam dot ac dot uk
  2008-12-09 21:17 ` spop at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jv244 at cam dot ac dot uk @ 2008-12-09 21:06 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from jv244 at cam dot ac dot uk  2008-12-09 21:04 -------
similar for gamma.F 

#0  0x00002b69b539a066 in realloc () from /lib64/libc.so.6
#1  0x00002b69b44a698c in __gmp_default_reallocate () from
/usr/lib64/libgmp.so.3
#2  0x00002b69b44bba21 in __gmpz_realloc () from /usr/lib64/libgmp.so.3
#3  0x00002b69b44bc554 in __gmpz_set () from /usr/lib64/libgmp.so.3
#4  0x00002b69b46eadfc in insert_loop (loop=0x12050d0, level=2, scalar=0,
next=0x7ffff6824af0, infos=0x11e4bc0)
    at source/ppl/clast.c:1446
#5  0x00002b69b46eb367 in insert_loop (loop=0x1204ff0, level=1, scalar=0,
next=0x7ffff6824af0, infos=0x11e4bc0)
    at source/ppl/clast.c:1480
#6  0x00002b69b46eba41 in cloog_clast_create (program=0x11c5e80, options=<value
optimized out>) at source/ppl/clast.c:1518
#7  0x0000000000ae667d in find_transform (scop=0x11fc320) at
/scratch/vondele/gcc/graphite/gcc/graphite.c:4238
#8  0x0000000000aede4b in graphite_transform_loops () at
/scratch/vondele/gcc/graphite/gcc/graphite.c:5382
#9  0x00000000007df337 in graphite_transforms () at
/scratch/vondele/gcc/graphite/gcc/tree-ssa-loop.c:298
#10 0x000000000066cb55 in execute_one_pass (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1279
#11 0x000000000066cd41 in execute_pass_list (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1328
#12 0x000000000066cd55 in execute_pass_list (pass=0x1082540) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329
#13 0x000000000066cd55 in execute_pass_list (pass=0x1081a00) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329
#14 0x000000000075dafc in tree_rest_of_compilation (fndecl=0x2b69b5dee800) at
/scratch/vondele/gcc/graphite/gcc/tree-optimize.c:418
#15 0x00000000008d7ac0 in cgraph_expand_function (node=0x2b69b5e0fe00) at
/scratch/vondele/gcc/graphite/gcc/cgraphunit.c:1038
#16 0x00000000008d967d in cgraph_optimize () a


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2008-12-09 21:06 ` jv244 at cam dot ac dot uk
@ 2008-12-09 21:17 ` spop at gcc dot gnu dot org
  2008-12-09 21:23 ` jv244 at cam dot ac dot uk
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu dot org @ 2008-12-09 21:17 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from spop at gcc dot gnu dot org  2008-12-09 21:14 -------
I do already know about this bug, this is id-2.f90 problem.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|grosser at gcc dot gnu dot  |spop at gcc dot gnu dot org
                   |org                         |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-12-09 20:26:08         |2008-12-09 21:14:13
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2008-12-09 21:17 ` spop at gcc dot gnu dot org
@ 2008-12-09 21:23 ` jv244 at cam dot ac dot uk
  2008-12-09 21:45 ` jv244 at cam dot ac dot uk
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jv244 at cam dot ac dot uk @ 2008-12-09 21:23 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from jv244 at cam dot ac dot uk  2008-12-09 21:22 -------
same for cp_cfm_basic_linalg.F

#0  0x00002ad7ad43d066 in realloc () from /lib64/libc.so.6
#1  0x00002ad7ac54998c in __gmp_default_reallocate () from
/usr/lib64/libgmp.so.3
#2  0x00002ad7ac55ea21 in __gmpz_realloc () from /usr/lib64/libgmp.so.3
#3  0x00002ad7ac55f554 in __gmpz_set () from /usr/lib64/libgmp.so.3
#4  0x00002ad7ac78ddfc in insert_loop (loop=0x11dfcf0, level=2, scalar=0,
next=0x7ffffe781a40, infos=0x1201cb0)
    at source/ppl/clast.c:1446
#5  0x00002ad7ac78e367 in insert_loop (loop=0x1208290, level=1, scalar=0,
next=0x7ffffe781a40, infos=0x1201cb0)
    at source/ppl/clast.c:1480
#6  0x00002ad7ac78ea41 in cloog_clast_create (program=0x11e9580, options=<value
optimized out>) at source/ppl/clast.c:1518
#7  0x0000000000ae667d in find_transform (scop=0x11d19b0) at
/scratch/vondele/gcc/graphite/gcc/graphite.c:4238
#8  0x0000000000aede4b in graphite_transform_loops () at
/scratch/vondele/gcc/graphite/gcc/graphite.c:5382
#9  0x00000000007df337 in graphite_transforms () at
/scratch/vondele/gcc/graphite/gcc/tree-ssa-loop.c:298
#10 0x000000000066cb55 in execute_one_pass (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1279
#11 0x000000000066cd41 in execute_pass_list (pass=0x10827e0) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1328
#12 0x000000000066cd55 in execute_pass_list (pass=0x1082540) at
/scratch/vondele/gcc/graphite/gcc/passes.c:1329


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2008-12-09 21:23 ` jv244 at cam dot ac dot uk
@ 2008-12-09 21:45 ` jv244 at cam dot ac dot uk
  2008-12-10  8:50 ` grosser at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jv244 at cam dot ac dot uk @ 2008-12-09 21:45 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from jv244 at cam dot ac dot uk  2008-12-09 21:44 -------
(In reply to comment #5)
> I do already know about this bug, this is id-2.f90 problem.

OK, guess it is rather frequent in that case, following files trigger it as
well:

ps_wavelet_kernel.F
ai_moments.F
cp_fm_basic_linalg.F
cp_sm_fm_interactions.F
ai_angmom.F
realspace_grid_types.F
distribution_optimize.F
qs_util.F
atom_operators.F
atom_fit.F
dynamical_coeff_types.F
particle_types.F
pw_poisson_types.F
pw_spline_utils.F
colvar_types.F
cp_ddapc_methods.F

So'll keep an eye on the branch, and check again once that bug is fixed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2008-12-09 21:45 ` jv244 at cam dot ac dot uk
@ 2008-12-10  8:50 ` grosser at gcc dot gnu dot org
  2008-12-10 15:29 ` spop at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: grosser at gcc dot gnu dot org @ 2008-12-10  8:50 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from grosser at gcc dot gnu dot org  2008-12-10 08:48 -------
Created an attachment (id=16869)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16869&action=view)
Fix

OK. I got the fix. We had a problem with invalid CloogDomain data structures.

We did not detect all parameters in find_scop_parameters(), but detected some
later during the domain creation. This was wrong, as the domains are always
with the number of parameters in mind created. If this number changes during
domain creation the already created domains are wrong/invalid.

To detect this easier the next time I added an assert in the code path. If we
would add parameters after find_scop_parameters() we simply fail.parameters. 

And why did we not detect all parameters?

Before commit 142384 we had this order:

1. Detect all bbs
2. Detect parameters
3. Remove unnecessary bbs.

Now we have do not even create the bbs in 1. So we do not check all bbs for
parameters and some of the bbs we do not check contained conditions with
parameters.

Solution: Change the way we find parameters in conditions. Do not look in the
bbs for conditions, but directly in GBB_CONDITIONS.

With this fix applied I can compile CP2K with "-O2 -fgraphite" so there are
only backend bugs left.

These will be found with "-O2 -fgraphite-identity"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2008-12-10  8:50 ` grosser at gcc dot gnu dot org
@ 2008-12-10 15:29 ` spop at gcc dot gnu dot org
  2008-12-10 17:37 ` grosser at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu dot org @ 2008-12-10 15:29 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from spop at gcc dot gnu dot org  2008-12-10 15:28 -------
Subject: Re:  [graphite] SEGFAULT in cloog_clast_create

> 2008-12-10  Tobias Grosser  <grosser@fim.uni-passau.de>
>
> 	* graphite.c (new_scop): Initialize SCOP_ADD_PARAMS.
> 	(param_index): Assert if parameter is not know after parameter
> 	detection.
> 	(find_params_in_bb): Detect params directly in GBB_CONDITIONS.
> 	(find_scop_parameters): Mark, that we have finished parameter
> 	detection.
> 	(graphite_transform_loops): Move condition detection before parameter
> 	detection.
> 	* graphite.h (struct scop): Add SCP_ADD_PARAMS.

s/SCP_ADD_PARAMS/SCOP_ADD_PARAMS/

> 	* testsuite/gfortran.dg/graphite/pr38459.f90: New.

Ok.  Please apply to graphite branch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2008-12-10 15:29 ` spop at gcc dot gnu dot org
@ 2008-12-10 17:37 ` grosser at gcc dot gnu dot org
  2008-12-10 17:42 ` grosser at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: grosser at gcc dot gnu dot org @ 2008-12-10 17:37 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #10 from grosser at gcc dot gnu dot org  2008-12-10 17:35 -------
Subject: Bug 38459

Author: grosser
Date: Wed Dec 10 17:33:58 2008
New Revision: 142653

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142653
Log:
2008-12-10  Tobias Grosser  <grosser@fim.uni-passau.de>

        PR middle-end/38459
        * graphite.c (new_scop): Initialize SCOP_ADD_PARAMS.
        (param_index): Assert if parameter is not know after parameter
        detection.
        (find_params_in_bb): Detect params directly in GBB_CONDITIONS.
        (find_scop_parameters): Mark, that we have finished parameter
        detection.
        (graphite_transform_loops): Move condition detection before parameter
        detection.
        * graphite.h (struct scop): Add SCOP_ADD_PARAMS.
        * testsuite/gfortran.dg/graphite/pr38459.f90: New.

Added:
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/pr38459.f90
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite.c
    branches/graphite/gcc/graphite.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (10 preceding siblings ...)
  2008-12-10 17:37 ` grosser at gcc dot gnu dot org
@ 2008-12-10 17:42 ` grosser at gcc dot gnu dot org
  2008-12-11 19:38 ` spop at gcc dot gnu dot org
  2008-12-11 20:00 ` spop at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: grosser at gcc dot gnu dot org @ 2008-12-10 17:42 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #11 from grosser at gcc dot gnu dot org  2008-12-10 17:36 -------
The last commit fixed that bug


-- 

grosser at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (11 preceding siblings ...)
  2008-12-10 17:42 ` grosser at gcc dot gnu dot org
@ 2008-12-11 19:38 ` spop at gcc dot gnu dot org
  2008-12-11 20:00 ` spop at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu dot org @ 2008-12-11 19:38 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #12 from spop at gcc dot gnu dot org  2008-12-11 19:37 -------
Subject: Bug 38459

Author: spop
Date: Thu Dec 11 19:35:41 2008
New Revision: 142688

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142688
Log:
2008-12-11  Harsha Jagasia  <harsha.jagasia@amd.com>

        PR tree-optimization/38446
        * graphite.c (register_bb_in_sese): New.
        (bb_in_sese_p): Check if bb belongs to sese region by explicitly
        looking at the bbs in the region.
        * graphite.h (sese): Add region_basic_blocks pointer set to
        structure and initialize at the time of defining new scop.

2008-12-11  Tobias Grosser  <grosser@fim.uni-passau.de>

        * graphite.c (new_graphite_bb): Initialize GBB_STATIC_SCHEDULE.
        (find_params_in_bb): Do not free data refs.
        (free_graphite_bb): Add FIXME on disabled free_data_refs.

2008-12-11  Sebastian Pop  <sebastian.pop@amd.com>

        * graphite.c (struct ivtype_map_elt): New.
        (debug_ivtype_elt, debug_ivtype_map_1, debug_ivtype_map,
        new_ivtype_map_elt, ivtype_map_elt_info, eq_ivtype_map_elts,
        gcc_type_for_cloog_iv): New.
        (loop_iv_stack_patch_for_consts): Use the type of the induction
        variable from the original loop, except for the automatically
        generated loops, i.e., in the case of a strip-mined loop, in
        which case there is no original loop: in that case just use
        integer_type_node.
        (new_graphite_bb): Initialize GBB_CLOOG_IV_TYPES.
        (free_graphite_bb): Free GBB_CLOOG_IV_TYPES.
        (clast_name_to_gcc): Accept params to be NULL.
        (clast_to_gcc_expression): Take an extra parameter for the type.
        Convert to that type all the expressions built by this function.
        (gcc_type_for_clast_expr, gcc_type_for_clast_eq): New.
        (graphite_translate_clast_equation): Compute the type of the
        clast_equation before translating its LHS and RHS.
        (clast_get_body_of_loop, gcc_type_for_iv_of_clast_loop): New.
        (graphite_create_new_loop): Compute the type of the induction
        variable before translating the lower and upper bounds and before
        creating the induction variable.
        (rename_variables_from_edge, rename_phis_end_scop): New.
        (copy_bb_and_scalar_dependences): Call rename_phis_end_scop.
        (sese_add_exit_phis_edge): Do not use integer_zero_node.
        (find_cloog_iv_in_expr, compute_cloog_iv_types_1,
        compute_cloog_iv_types): New.
        (gloog): Call compute_cloog_iv_types before starting the
        translation of the clast.

        * graphite.h (struct graphite_bb): New field cloog_iv_types.
        (GBB_CLOOG_IV_TYPES): New.
        (debug_ivtype_map): Declared.
        (oldiv_for_loop): New.

2008-12-10  Tobias Grosser  <grosser@fim.uni-passau.de>

        PR middle-end/38459
        * graphite.c (new_scop): Initialize SCOP_ADD_PARAMS.
        (param_index): Assert if parameter is not know after parameter
        detection.
        (find_params_in_bb): Detect params directly in GBB_CONDITIONS.
        (find_scop_parameters): Mark, that we have finished parameter
        detection.
        (graphite_transform_loops): Move condition detection before parameter
        detection.
        * graphite.h (struct scop): Add SCOP_ADD_PARAMS.

2008-12-11  Harsha Jagasia  <harsha.jagasia@amd.com>

        PR tree-optimization/38446
        * gcc.dg/graphite/pr38446.c: New.

2008-12-11  Sebastian Pop  <sebastian.pop@amd.com>

        * gcc.dg/graphite/scop-16.c: Test only scop specific info.
        * gcc.dg/graphite/scop-17.c: Same.
        * gcc.dg/graphite/block-5.c: New.
        * gcc.dg/graphite/block-6.c: New.
        * gcc.dg/graphite/pr37485.c: Clean dump file after.
        * gcc.dg/graphite/pr37684.c: Same.
        * gcc.dg/graphite/block-2.c: Same.

2008-12-10  Tobias Grosser  <grosser@fim.uni-passau.de>

        PR middle-end/38459
        * gfortran.dg/graphite/pr38459.f90: New.


Added:
    trunk/gcc/testsuite/gcc.dg/graphite/block-2.c
    trunk/gcc/testsuite/gcc.dg/graphite/block-5.c
    trunk/gcc/testsuite/gcc.dg/graphite/block-6.c
    trunk/gcc/testsuite/gcc.dg/graphite/pr38446.c
    trunk/gcc/testsuite/gfortran.dg/graphite/pr38459.f90
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/graphite.c
    trunk/gcc/graphite.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/graphite/pr37485.c
    trunk/gcc/testsuite/gcc.dg/graphite/pr37684.c
    trunk/gcc/testsuite/gcc.dg/graphite/scop-15.c
    trunk/gcc/testsuite/gcc.dg/graphite/scop-16.c
    trunk/gcc/testsuite/gcc.dg/graphite/scop-17.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create
  2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
                   ` (12 preceding siblings ...)
  2008-12-11 19:38 ` spop at gcc dot gnu dot org
@ 2008-12-11 20:00 ` spop at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu dot org @ 2008-12-11 20:00 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #13 from spop at gcc dot gnu dot org  2008-12-11 19:58 -------
Subject: Bug 38459

Author: spop
Date: Thu Dec 11 19:57:18 2008
New Revision: 142690

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142690
Log:
2008-12-11  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/38459
        * gfortran.dg/graphite/pr37857.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/graphite/pr37857.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2008-12-11 20:00 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-09 20:15 [Bug middle-end/38459] New: [graphite] SEGFAULT in cloog_clast_create grosser at gcc dot gnu dot org
2008-12-09 20:19 ` [Bug middle-end/38459] " grosser at gcc dot gnu dot org
2008-12-09 20:28 ` grosser at gcc dot gnu dot org
2008-12-09 20:44 ` jv244 at cam dot ac dot uk
2008-12-09 20:48 ` jv244 at cam dot ac dot uk
2008-12-09 21:06 ` jv244 at cam dot ac dot uk
2008-12-09 21:17 ` spop at gcc dot gnu dot org
2008-12-09 21:23 ` jv244 at cam dot ac dot uk
2008-12-09 21:45 ` jv244 at cam dot ac dot uk
2008-12-10  8:50 ` grosser at gcc dot gnu dot org
2008-12-10 15:29 ` spop at gcc dot gnu dot org
2008-12-10 17:37 ` grosser at gcc dot gnu dot org
2008-12-10 17:42 ` grosser at gcc dot gnu dot org
2008-12-11 19:38 ` spop at gcc dot gnu dot org
2008-12-11 20:00 ` spop at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).