public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "grosser at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/38459] [graphite] SEGFAULT in cloog_clast_create Date: Wed, 10 Dec 2008 08:50:00 -0000 [thread overview] Message-ID: <20081210084855.32167.qmail@sourceware.org> (raw) In-Reply-To: <bug-38459-15673@http.gcc.gnu.org/bugzilla/> ------- Comment #8 from grosser at gcc dot gnu dot org 2008-12-10 08:48 ------- Created an attachment (id=16869) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16869&action=view) Fix OK. I got the fix. We had a problem with invalid CloogDomain data structures. We did not detect all parameters in find_scop_parameters(), but detected some later during the domain creation. This was wrong, as the domains are always with the number of parameters in mind created. If this number changes during domain creation the already created domains are wrong/invalid. To detect this easier the next time I added an assert in the code path. If we would add parameters after find_scop_parameters() we simply fail.parameters. And why did we not detect all parameters? Before commit 142384 we had this order: 1. Detect all bbs 2. Detect parameters 3. Remove unnecessary bbs. Now we have do not even create the bbs in 1. So we do not check all bbs for parameters and some of the bbs we do not check contained conditions with parameters. Solution: Change the way we find parameters in conditions. Do not look in the bbs for conditions, but directly in GBB_CONDITIONS. With this fix applied I can compile CP2K with "-O2 -fgraphite" so there are only backend bugs left. These will be found with "-O2 -fgraphite-identity" -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38459
next prev parent reply other threads:[~2008-12-10 8:50 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-12-09 20:15 [Bug middle-end/38459] New: " grosser at gcc dot gnu dot org 2008-12-09 20:19 ` [Bug middle-end/38459] " grosser at gcc dot gnu dot org 2008-12-09 20:28 ` grosser at gcc dot gnu dot org 2008-12-09 20:44 ` jv244 at cam dot ac dot uk 2008-12-09 20:48 ` jv244 at cam dot ac dot uk 2008-12-09 21:06 ` jv244 at cam dot ac dot uk 2008-12-09 21:17 ` spop at gcc dot gnu dot org 2008-12-09 21:23 ` jv244 at cam dot ac dot uk 2008-12-09 21:45 ` jv244 at cam dot ac dot uk 2008-12-10 8:50 ` grosser at gcc dot gnu dot org [this message] 2008-12-10 15:29 ` spop at gcc dot gnu dot org 2008-12-10 17:37 ` grosser at gcc dot gnu dot org 2008-12-10 17:42 ` grosser at gcc dot gnu dot org 2008-12-11 19:38 ` spop at gcc dot gnu dot org 2008-12-11 20:00 ` spop at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20081210084855.32167.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).