public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
@ 2008-09-28 9:55 martinwguy at yahoo dot it
2008-09-28 9:56 ` [Bug target/37668] " martinwguy at yahoo dot it
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: martinwguy at yahoo dot it @ 2008-09-28 9:55 UTC (permalink / raw)
To: gcc-bugs
Hi
I spotted this while trawling through the arm code generator: the code in the
NEG case has no effect. I assume the NEG case should return if the condition
matches; patch attached. It's still present in trunk.
case NEG:
if (TARGET_HARD_FLOAT && GET_MODE_CLASS (mode) == MODE_FLOAT)
*total = COSTS_N_INSNS (1);
/* Fall through */
case NOT:
*total = COSTS_N_INSNS (ARM_NUM_REGS (mode));
return false;
--
Summary: Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
Product: gcc
Version: 4.3.2
Status: UNCONFIRMED
Severity: minor
Priority: P3
Component: target
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: martinwguy at yahoo dot it
GCC target triplet: arm-*
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37668
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/37668] Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
2008-09-28 9:55 [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG: martinwguy at yahoo dot it
@ 2008-09-28 9:56 ` martinwguy at yahoo dot it
2008-09-28 11:58 ` steven at gcc dot gnu dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: martinwguy at yahoo dot it @ 2008-09-28 9:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from martinwguy at yahoo dot it 2008-09-28 09:55 -------
Created an attachment (id=16418)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16418&action=view)
Aplies the "obvious" fix
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37668
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/37668] Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
2008-09-28 9:55 [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG: martinwguy at yahoo dot it
2008-09-28 9:56 ` [Bug target/37668] " martinwguy at yahoo dot it
@ 2008-09-28 11:58 ` steven at gcc dot gnu dot org
2008-12-10 14:32 ` rearnsha at gcc dot gnu dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: steven at gcc dot gnu dot org @ 2008-09-28 11:58 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from steven at gcc dot gnu dot org 2008-09-28 11:57 -------
Don't know if the patch is OK, but the code is obviously doing something silly.
CC-ing ARM maintainer.
--
steven at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pbrook at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2008-09-28 11:57:07
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37668
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/37668] Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
2008-09-28 9:55 [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG: martinwguy at yahoo dot it
2008-09-28 9:56 ` [Bug target/37668] " martinwguy at yahoo dot it
2008-09-28 11:58 ` steven at gcc dot gnu dot org
@ 2008-12-10 14:32 ` rearnsha at gcc dot gnu dot org
2008-12-10 15:00 ` rearnsha at gcc dot gnu dot org
2008-12-10 15:03 ` rearnsha at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: rearnsha at gcc dot gnu dot org @ 2008-12-10 14:32 UTC (permalink / raw)
To: gcc-bugs
--
rearnsha at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |rearnsha at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2008-09-28 11:57:07 |2008-12-10 14:29:42
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37668
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/37668] Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
2008-09-28 9:55 [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG: martinwguy at yahoo dot it
` (2 preceding siblings ...)
2008-12-10 14:32 ` rearnsha at gcc dot gnu dot org
@ 2008-12-10 15:00 ` rearnsha at gcc dot gnu dot org
2008-12-10 15:03 ` rearnsha at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: rearnsha at gcc dot gnu dot org @ 2008-12-10 15:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from rearnsha at gcc dot gnu dot org 2008-12-10 14:58 -------
Subject: Bug 37668
Author: rearnsha
Date: Wed Dec 10 14:57:18 2008
New Revision: 142647
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142647
Log:
Martin Guy <martinwguy@yahoo.it>
PR target/37668
* arm.c (arm_size_rtx_costs, case NEG): Don't fall through if the
result will be in an FPU register.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/arm/arm.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37668
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/37668] Obvious bug in arm.c: arm_size_rtx_costs() case NEG:
2008-09-28 9:55 [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG: martinwguy at yahoo dot it
` (3 preceding siblings ...)
2008-12-10 15:00 ` rearnsha at gcc dot gnu dot org
@ 2008-12-10 15:03 ` rearnsha at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: rearnsha at gcc dot gnu dot org @ 2008-12-10 15:03 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from rearnsha at gcc dot gnu dot org 2008-12-10 15:00 -------
Fixed in 4.4.0
--
rearnsha at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.4.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37668
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-12-10 15:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-28 9:55 [Bug target/37668] New: Obvious bug in arm.c: arm_size_rtx_costs() case NEG: martinwguy at yahoo dot it
2008-09-28 9:56 ` [Bug target/37668] " martinwguy at yahoo dot it
2008-09-28 11:58 ` steven at gcc dot gnu dot org
2008-12-10 14:32 ` rearnsha at gcc dot gnu dot org
2008-12-10 15:00 ` rearnsha at gcc dot gnu dot org
2008-12-10 15:03 ` rearnsha at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).