public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dberlin at dberlin dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/38533] [4.2/4.3/4.4 regression] tree-ssa-reassoc.c increases register pressure several times
Date: Tue, 16 Dec 2008 17:02:00 -0000 [thread overview]
Message-ID: <20081216170032.19113.qmail@sourceware.org> (raw)
In-Reply-To: <bug-38533-17083@http.gcc.gnu.org/bugzilla/>
------- Comment #4 from dberlin at gcc dot gnu dot org 2008-12-16 17:00 -------
Subject: Re: [4.2/4.3/4.4 regression] tree-ssa-reassoc.c increases register
pressure several times
Yes, that looks like a bug.
There are also numerous ways in which the placement can be improved.
A few people had talked about rewriting it to be a balanced tree
placement, etc, so i've never bothered to do even the small cleanups.
If you want to change placement, go for it.
:)
On Tue, Dec 16, 2008 at 11:57 AM, jakub at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #3 from jakub at gcc dot gnu dot org 2008-12-16 16:57 -------
> In particular, the problem is in linearize_expr_tree. The |s are already
> perfectly linearized (in all but the innermost recursive linearize_expr_tree
> binlhsisreassoc is 1 and binrhsisreassoc is 0, in the innermost both are 0),
> yet:
> 1645 gsinow = gsi_for_stmt (stmt);
> 1646 gsilhs = gsi_for_stmt (SSA_NAME_DEF_STMT (binlhs));
> 1647 gsi_move_before (&gsilhs, &gsinow);
> moves all of them to one spot. Couldn't that moving be deferred till we
> actually know it is worthwhile to reassociate something, not blindly just in
> case something will be needed?
>
>
> --
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38533
>
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.
>
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38533
next prev parent reply other threads:[~2008-12-16 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 17:54 [Bug c/38533] New: [4.2/4.3/4.4 regression] Inefficient stack usage h-shimamoto at ct dot jp dot nec dot com
2008-12-15 23:24 ` [Bug middle-end/38533] " pinskia at gcc dot gnu dot org
2008-12-16 13:50 ` [Bug middle-end/38533] [4.2/4.3/4.4 regression] tree-ssa-reassoc.c increases register pressure several times jakub at gcc dot gnu dot org
2008-12-16 15:01 ` hjl dot tools at gmail dot com
2008-12-16 16:58 ` jakub at gcc dot gnu dot org
2008-12-16 17:02 ` dberlin at dberlin dot org [this message]
2008-12-16 23:27 ` jakub at gcc dot gnu dot org
2008-12-17 13:07 ` jakub at gcc dot gnu dot org
2008-12-17 16:05 ` jakub at gcc dot gnu dot org
2008-12-18 7:57 ` jakub at gcc dot gnu dot org
2008-12-18 8:00 ` [Bug middle-end/38533] [4.2/4.3 " jakub at gcc dot gnu dot org
2008-12-29 22:45 ` rguenth at gcc dot gnu dot org
2009-02-04 7:44 ` bonzini at gnu dot org
2009-03-31 21:05 ` [Bug middle-end/38533] [4.3 " jsm28 at gcc dot gnu dot org
2009-04-22 15:19 ` rguenth at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216170032.19113.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).