[Bug middle-end/38584] New: [4.3/4.4 Regression] Inline heuristics

[Bug middle-end/38584] New: [4.3/4.4 Regression] Inline heuristics

[jv244 at cam dot ac dot uk]

This is split off from PR38474 for clarity. Compiling the testcase of that PR 

(http://gcc.gnu.org/bugzilla/attachment.cgi?id=16873)

as

gfortran-4.3 -ffree-line-length-512 -g -ffree-form -ftime-report -c -O0
testcase.f90

requires about 20min in inline heuristics, estimating the stack frame size. It
also allocates 2.3Gb doing so.


-- 
           Summary: [4.3/4.4 Regression] Inline heuristics
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: memory-hog, compile-time-hog
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk
OtherBugsDependingO 38474
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics

[jv244 at cam dot ac dot uk]

------- Comment #1 from jv244 at cam dot ac dot uk  2008-12-20 11:32 -------
affects both 4.3 and 4.4


-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |steven at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-12-20 15:47:00
               date|                            |
            Summary|[4.3/4.4 Regression] Inline |[4.3/4.4 Regression] Inline
                   |heuristics                  |heuristics run even at -O0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #2 from steven at gcc dot gnu dot org  2008-12-21 00:33 -------
Created an attachment (id=16951)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16951&action=view)
Avoid expensive inline heuristics at O0, and speed up add_alias_set_conflicts

This problem is always going to be, at the core, that add_alias_set_conflicts
is a quadratic problem in the number of stack variables.  But we can avoid
calculating this at -O0 for the inline heuristics but not for bin-packing stack
variables.  And we can also try hard to make the quadratic loop as cheap as
possible.

Without this patch, for compiling the full test case (at -O0) my ia64 host
spends 952s in "callgraph optimizations", 1903s in "inline heuristics", and
1013s in "expand" (total 3868s).

With the patch, the numbers are 1s in "callgraph optimizations", 0s in "inline
heuristics", and 587s in "expand" (total 588s).

Given the nature of this unholy test case, I think the patch is close to the
final form I intend to submit, at least algorithmically.  There are enough
areas left where we spend a lot more time...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[jv244 at cam dot ac dot uk]

------- Comment #3 from jv244 at cam dot ac dot uk  2008-12-21 08:05 -------
(In reply to comment #2)
> Without this patch, (total 3868s).
> 
> With the patch, (total 588s).

Great... 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #4 from steven at gcc dot gnu dot org  2008-12-30 13:36 -------
Subject: Bug 38584

Author: steven
Date: Tue Dec 30 13:35:00 2008
New Revision: 142963

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142963
Log:
        PR middle-end/38584
        * ipa-inline.c (compute_inline_parameters): When not optimizing,
        don't compute the inline parameters, just set them to 0 instead.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-inline.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #5 from steven at gcc dot gnu dot org  2008-12-30 13:37 -------
We should not use the full bin-packing algorithm for any optimization level.  A
simpler heuristic is called for.  I'll see if I can come up with something.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2009-01-01 00:55 -------
Now that inline heuristics runs only at -O1+ on the trunk, can this be changed
into 4.3 only regression?  If you want to make bin-packing faster, that could
be covered by a separate bug (and would it be a regression)?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[stevenb dot gcc at gmail dot com]

------- Comment #7 from stevenb dot gcc at gmail dot com  2009-01-01 13:42 -------
Subject: Re:  [4.3/4.4 Regression] Inline heuristics run even at -O0

Note that the compile time at, say, -O1 for 4.3 vs. 4.4 is also a huge
difference for the test case (4.4 much slower, in part due to the
expensive heuristic).  Therefore, IMHO, this is still a 4.4 regression
too.  We should not be running such expensive algorithms just for
inline heuristics.  We need to figure out a cheaper heuristic.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #8 from steven at gcc dot gnu dot org  2009-01-04 00:15 -------
Subject: Bug 38584

Author: steven
Date: Sun Jan  4 00:15:08 2009
New Revision: 143040

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143040
Log:
        PR middle-end/38584
        * cfgexpand.c (estimate_stack_frame_size): Simplify the estimate:
        Calculate the size of all stack vars assuming no packing of stack
        vars will happen, replacing a quadratic algorithm with a linear one.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #9 from steven at gcc dot gnu dot org  2009-01-04 00:17 -------
.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[cnstar9988 at gmail dot com]

------- Comment #10 from cnstar9988 at gmail dot com  2009-01-07 08:55 -------
ping for 4.3...


-- 

cnstar9988 at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cnstar9988 at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #11 from steven at gcc dot gnu dot org  2009-01-07 09:37 -------
I have no intention to fix this in 4.3.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[cnstar9988 at gmail dot com]

------- Comment #12 from cnstar9988 at gmail dot com  2009-01-08 09:30 -------
Target Milestone: 4.3.3
But not fixed for 4.3.3
ping ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #13 from steven at gcc dot gnu dot org  2009-01-08 10:21 -------
Reopening...


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0

[steven at gcc dot gnu dot org]

------- Comment #14 from steven at gcc dot gnu dot org  2009-01-08 10:22 -------
...to unassign and avoid spam from cnstar9988 (who is free to test/submit the
patch if it's so important for him/her to have this bug fixed in gcc 4.3).


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|steven at gcc dot gnu dot   |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|REOPENED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3 Regression] Inline heuristics run even at -O0

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2009-01-24 10:21 -------
GCC 4.3.3 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.3                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3 Regression] Inline heuristics run even at -O0

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2009-08-04 12:29 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3 Regression] Inline heuristics run even at -O0

[rguenth at gcc dot gnu dot org]

------- Comment #18 from rguenth at gcc dot gnu dot org  2010-04-20 14:32 -------
Backported the fix for the $summary.  WONTFIX for the cfgexpand slowness.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584

[Bug middle-end/38584] [4.3 Regression] Inline heuristics run even at -O0

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2010-04-20 14:32 -------
Subject: Bug 38584

Author: rguenth
Date: Tue Apr 20 14:31:47 2010
New Revision: 158562

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158562
Log:
2010-04-20  Richard Guenther  <rguenther@suse.de>

        Backport from mainline
        2008-12-30  Steven Bosscher  <steven@gcc.gnu.org>

        PR middle-end/38584
        * ipa-inline.c (compute_inline_parameters): When not optimizing,
        don't compute the inline parameters, just set them to 0 instead.

Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/ipa-inline.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584