public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "forwards dot from dot bugzilla at d81 dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/38629] target-specific parameters for inline heuristics not defined for AVR
Date: Fri, 26 Dec 2008 21:30:00 -0000	[thread overview]
Message-ID: <20081226212936.1085.qmail@sourceware.org> (raw)
In-Reply-To: <bug-38629-17118@http.gcc.gnu.org/bugzilla/>



------- Comment #2 from forwards dot from dot bugzilla at d81 dot de  2008-12-26 21:29 -------
Steven, thanks for your explanation. My point of view was that gcc-4.3.3 did do
inlining code for "-Os", "-O1", "-O2" although the manual clearly states that
it would not do inlining for these optimization levels.

     "-O2 Optimize even more. GCC performs... The compiler does not perform
          loop unrolling or function inlining when you specify -O2..."

But for "-O/-O1" it is mentioned:
     "-O turns on the following optimization flags:
      ... -finline-small-functions ..."

So the manual is a little ambiguous in this point. So to tune the heuristics
for the AVR target, one needs to tell the compiler:
 1) what's a "small function"
 2) tell about the costs
 3) maybe do something more

Actually, in GCC-4.4, gcc/config/avr/avr.c, somebody did already some tuning as
it seems to me:

avr_override_options (void)
{
  const struct mcu_type_s *t;

  flag_delete_null_pointer_checks = 0;

  if (!PARAM_SET_P (PARAM_INLINE_CALL_COST))
    set_param_value ("inline-call-cost", 5);
    ....

I don't feel qualified enough to find well working values for all AVR
architectures since I do know the Attiny2313, Mega8 and Mega644 a little bit.
Maybe someone is willing to help me.


Wolfgang


PS: Steven, do you have got administrative rights to edit my initial post.
Could you please convert Till Harbaum's eMail address into something that
cannot be parsed by eMail harvesting robots ('@' -> "(at)").


-- 

forwards dot from dot bugzilla at d81 dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |forwards dot from dot
                   |                            |bugzilla at d81 dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38629


  parent reply	other threads:[~2008-12-26 21:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 14:58 [Bug c/38629] New: gcc version 4.2.x, 4.3.x and 4.4.0 are doing (too much) automatic inlining with -O1, -O2 and -Os cbm at d81 dot de
2008-12-26 15:41 ` [Bug target/38629] target-specific parameters for inline heuristics not defined for AVR steven at gcc dot gnu dot org
2008-12-26 21:30 ` forwards dot from dot bugzilla at d81 dot de [this message]
2008-12-26 21:36 ` pinskia at gcc dot gnu dot org
2008-12-29 20:14 ` rguenth at gcc dot gnu dot org
     [not found] <bug-38629-4@http.gcc.gnu.org/bugzilla/>
2010-11-10 20:19 ` hubicka at gcc dot gnu.org
2010-11-10 20:52 ` hubicka at gcc dot gnu.org
2015-04-09 15:43 ` federico at fsfe dot org
2015-04-09 15:47 ` federico at fsfe dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081226212936.1085.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).