[Bug c++/36019] New: template parameter does not hide class name

[Bug c++/36019] New: template parameter does not hide class name

[deba at inf dot elte dot hu]

If a member template is defined with same template parameter name as the class
name, then this parameter does not hide the class name.
The following code explains the problem:

#include <iostream>

struct B {
  static const int x = 1;
};

struct A {
  static const int x = 0;
  template <typename A>
  static void f() {
    std::cerr << A::x << std::endl;
  }
};

int main() {
  A::f<B>();
  return 0;
}

The result of the program is 0, while it should be 1.

Compilation:
> g++ -v -save-temps ns_bug.cc
Using built-in specs.                                                           
Target: i486-linux-gnu                                                          
Configured with: ../src/configure -v
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --enable-shared
--with-system-zlib --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.2
--program-suffix=-4.2 --enable-clocale=gnu --enable-libstdcxx-debug
--enable-objc-gc --enable-mpfr --disable-libmudflap --enable-targets=all
--enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu
--target=i486-linux-gnu                                                         
Thread model: posix                                                             
gcc version 4.2.3 (Debian 4.2.3-3)                                              
 /usr/lib/gcc/i486-linux-gnu/4.2.3/cc1plus -E -quiet -v -D_GNU_SOURCE ns_bug.cc
-mtune=generic -fpch-preprocess -o ns_bug.ii                                    
ignoring nonexistent directory "/usr/local/include/i486-linux-gnu"              
ignoring nonexistent directory
"/usr/lib/gcc/i486-linux-gnu/4.2.3/../../../../i486-linux-gnu/include"          
ignoring nonexistent directory "/usr/include/i486-linux-gnu"
#include "..." search starts here:
#include <...> search starts here:
 /usr/include/c++/4.2
 /usr/include/c++/4.2/i486-linux-gnu
 /usr/include/c++/4.2/backward
 /usr/local/include
 /usr/lib/gcc/i486-linux-gnu/4.2.3/include
 /usr/include
End of search list.
 /usr/lib/gcc/i486-linux-gnu/4.2.3/cc1plus -fpreprocessed ns_bug.ii -quiet
-dumpbase ns_bug.cc -mtune=generic -auxbase ns_bug -version -o ns_bug.s
GNU C++ version 4.2.3 (Debian 4.2.3-3) (i486-linux-gnu)
        compiled by GNU C version 4.2.3 (Debian 4.2.3-3).
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: f63294e1c8ecc1bf2473a5bae1642fbe
 as -V -Qy -o ns_bug.o ns_bug.s
^[[6~GNU assembler version 2.18.0 (i486-linux-gnu) using BFD version (GNU
Binutils for Debian) 2.18.0.20080103
 /usr/lib/gcc/i486-linux-gnu/4.2.3/collect2 --eh-frame-hdr -m elf_i386
--hash-style=both -dynamic-linker /lib/ld-linux.so.2
/usr/lib/gcc/i486-linux-gnu/4.2.3/../../../../lib/crt1.o
/usr/lib/gcc/i486-linux-gnu/4.2.3/../../../../lib/crti.o
/usr/lib/gcc/i486-linux-gnu/4.2.3/crtbegin.o
-L/usr/lib/gcc/i486-linux-gnu/4.2.3 -L/usr/lib/gcc/i486-linux-gnu/4.2.3
-L/usr/lib/gcc/i486-linux-gnu/4.2.3/../../../../lib -L/lib/../lib
-L/usr/lib/../lib -L/usr/lib/gcc/i486-linux-gnu/4.2.3/../../.. ns_bug.o
-lstdc++ -lm -lgcc_s -lgcc -lc -lgcc_s -lgcc
/usr/lib/gcc/i486-linux-gnu/4.2.3/crtend.o
/usr/lib/gcc/i486-linux-gnu/4.2.3/../../../../lib/crtn.o


-- 
           Summary: template parameter does not hide class name
           Product: gcc
           Version: 4.2.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: deba at inf dot elte dot hu
 GCC build triplet: i486-linux-gnu
  GCC host triplet: i486-linux-gnu
GCC target triplet: i486-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2008-12-28 06:27 -------
Confirmed.

Here is a rejects valid:
#include <iostream>

struct B {
  static const int x = 1;
};

struct A {
  template <typename A>
  static void f() {
    std::cerr << A::x << std::endl;
  }
};

int main() {
  A::f<B>();
  return 0;
}


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|i486-linux-gnu              |
   GCC host triplet|i486-linux-gnu              |
 GCC target triplet|i486-linux-gnu              |
           Keywords|                            |rejects-valid
      Known to fail|                            |4.3.0 4.0.1 4.4.0 4.3.2
                   |                            |4.3.3
      Known to work|                            |3.3.3
   Last reconfirmed|0000-00-00 00:00:00         |2008-12-28 06:27:52
               date|                            |
            Summary|template parameter does not |[4.2/4.3/4.4 Regression]
                   |hide class name             |template parameter does not
                   |                            |hide class name
   Target Milestone|---                         |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2008-12-29 20:57 -------
P1 for 4.4, not really for the branches.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

-- 

dodji at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dodji at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-12-28 06:27:52         |2009-01-07 01:11:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

------- Comment #3 from dodji at gcc dot gnu dot org  2009-01-08 23:03 -------
Created an attachment (id=17059)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17059&action=view)
candidate patch

I think what is happening is that lookup_name_real (in name-lookup.c) makes
sure types defined in the class hierarchy hide template type parameters. That
scheme is implemented in the outer_binding accessor function.

That scheme is fine for class templates, as stated in the spec in [temp.res]
and [temp.local]. 

Template parameters of member templates though, should hide types defined in
the class scope.

This patch tries to implement that. But I am not sure if it's the right
approach. I'll keep working on it until it's suitable for submission to
gcc-patches.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

------- Comment #4 from dodji at gcc dot gnu dot org  2009-01-09 19:10 -------
Created an attachment (id=17066)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17066&action=view)
A better patch

I believe this patch should be better that the previous one because it seems to
be more generic. I am still testing it and thinking about it.


-- 

dodji at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17059|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

------- Comment #5 from dodji at gcc dot gnu dot org  2009-01-12 22:41 -------
Subject: Bug 36019

Author: dodji
Date: Mon Jan 12 22:41:19 2009
New Revision: 143313

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143313
Log:
gcc/cp/ChangeLog:
2009-01-12  Dodji Seketeli  <dodji@redhat.com>

        PR c++/36019
        * pt.c (parameter_of_template_p): New function.
        * pt.c (get_template_info): Ditto.
        * cp-tree.h: Declare those.
        * name-lookup.c (binding_to_template_parms_of_scope_p): New
        function.
        (outer_binding): Take template parameters in account when looking for
        a name binding.

gcc/testsuite/ChangeLog:
2009-01-12  Dodji Seketeli  <dodji@redhat.com>

        PR c++/36019
        * g++.dg/lookup/hidden-class12.C: New test.
        * g++.dg/lookup/hidden-class13.C: New test.
        * g++.dg/lookup/hidden-class14.C: New test.
        * g++.dg/lookup/hidden-class15.C: New test.
        * g++.dg/lookup/hidden-class16.C: New test.
        * gcc/testsuite/g++.old-deja/g++.benjamin/tem03.C: Adjust testcase.


Added:
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/lookup/hidden-class12.C
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/lookup/hidden-class13.C
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/lookup/hidden-class14.C
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/lookup/hidden-class15.C
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/lookup/hidden-class16.C
Modified:
    branches/gcc-4_2-branch/gcc/cp/ChangeLog
    branches/gcc-4_2-branch/gcc/cp/cp-tree.h
    branches/gcc-4_2-branch/gcc/cp/name-lookup.c
    branches/gcc-4_2-branch/gcc/cp/pt.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/g++.old-deja/g++.benjamin/tem03.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

------- Comment #6 from dodji at gcc dot gnu dot org  2009-01-12 22:44 -------
Subject: Bug 36019

Author: dodji
Date: Mon Jan 12 22:44:13 2009
New Revision: 143314

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143314
Log:
gcc/cp/ChangeLog:
2009-01-12  Dodji Seketeli  <dodji@redhat.com>

        PR c++/36019
        * pt.c (parameter_of_template_p): New function.
        * cp-tree.h: Declare it.
        * name-lookup.c (binding_to_template_parms_of_scope_p): New
        function.
        (outer_binding): Take template parameters in account when looking for
        a name binding.

gcc/testsuite/ChangeLog:
2009-01-12  Dodji Seketeli  <dodji@redhat.com>

        PR c++/36019
        * g++.dg/lookup/hidden-class12.C: New test.
        * g++.dg/lookup/hidden-class13.C: New test.
        * g++.dg/lookup/hidden-class14.C: New test.
        * g++.dg/lookup/hidden-class15.C: New test.
        * g++.dg/lookup/hidden-class16.C: New test.
        * gcc/testsuite/g++.old-deja/g++.benjamin/tem03.C: Adjust testcase.


Added:
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/lookup/hidden-class12.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/lookup/hidden-class13.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/lookup/hidden-class14.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/lookup/hidden-class15.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/lookup/hidden-class16.C
Modified:
    branches/gcc-4_3-branch/gcc/cp/ChangeLog
    branches/gcc-4_3-branch/gcc/cp/cp-tree.h
    branches/gcc-4_3-branch/gcc/cp/name-lookup.c
    branches/gcc-4_3-branch/gcc/cp/pt.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_3-branch/gcc/testsuite/g++.old-deja/g++.benjamin/tem03.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

------- Comment #7 from dodji at gcc dot gnu dot org  2009-01-12 22:48 -------
Subject: Bug 36019

Author: dodji
Date: Mon Jan 12 22:47:49 2009
New Revision: 143315

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143315
Log:
gcc/cp/ChangeLog:
2009-01-12  Dodji Seketeli  <dodji@redhat.com>

        PR c++/36019
        * pt.c (parameter_of_template_p): New function.
        * cp-tree.h: Declare it.
        * name-lookup.c (binding_to_template_parms_of_scope_p): New
        function.
        (outer_binding): Take template parameters in account when looking for
        a name binding.

gcc/testsuite/ChangeLog:
2009-01-12  Dodji Seketeli  <dodji@redhat.com>

        PR c++/36019
        * g++.dg/lookup/hidden-class12.C: New test.
        * g++.dg/lookup/hidden-class13.C: New test.
        * g++.dg/lookup/hidden-class14.C: New test.
        * g++.dg/lookup/hidden-class15.C: New test.
        * g++.dg/lookup/hidden-class16.C: New test.


Added:
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class12.C
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class13.C
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class14.C
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class15.C
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class16.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/cp/pt.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at gcc dot gnu dot org]

------- Comment #8 from dodji at gcc dot gnu dot org  2009-01-12 22:50 -------
Fixed in trunk, gcc-4_3 and gcc-4_2.


-- 

dodji at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2009-01-12 23:00 -------
The 4.3 version seems to be the old one, with is_* prefixes and macro, while
trunk/4.2 are the new ones.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[dodji at redhat dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]



------- Comment #10 from dodji at gcc dot gnu dot org  2009-01-13 16:50 -------
Subject: Re:  [4.2/4.3/4.4 Regression] template parameter does
 not hide class name

jakub at gcc dot gnu dot org a écrit :
> ------- Comment #9 from jakub at gcc dot gnu dot org  2009-01-12 23:00 -------
> The 4.3 version seems to be the old one, with is_* prefixes and macro, while
> trunk/4.2 are the new ones.

Oops, right. Fixing that now. Thanks.

Dodji.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[jason at gcc dot gnu dot org]

------- Comment #11 from jason at gcc dot gnu dot org  2009-03-03 22:00 -------
Incidentally, this is core issue 458.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019

[Bug c++/36019] [4.2/4.3/4.4 Regression] template parameter does not hide class name

[jason at gcc dot gnu dot org]

------- Comment #12 from jason at gcc dot gnu dot org  2009-03-03 22:01 -------
*** Bug 13967 has been marked as a duplicate of this bug. ***


-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gianni at mariani dot ws


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36019