public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/38708] [4.4 Regression] Revision 137646 caused gcc.c-torture/execute/memset-[23].c fail with -mtune=pentiumpro
Date: Sat, 03 Jan 2009 09:10:00 -0000	[thread overview]
Message-ID: <20090103090920.7485.qmail@sourceware.org> (raw)
In-Reply-To: <bug-38708-6528@http.gcc.gnu.org/bugzilla/>



------- Comment #6 from jakub at gcc dot gnu dot org  2009-01-03 09:09 -------
--- i386.c.jj4        2008-12-27 10:12:25.000000000 +0100
+++ i386.c        2009-01-03 10:03:05.000000000 +0100
@@ -18012,13 +18012,12 @@ ix86_expand_setmem (rtx dst, rtx count_e
          Epilogue code will actually copy COUNT_EXP & EPILOGUE_SIZE_NEEDED
          bytes. Compensate if needed.  */

-      if (size_needed < desired_align - align)
+      if (size_needed < epilogue_size_needed)
         {
           tmp =
             expand_simple_binop (counter_mode (count_exp), AND, count_exp,
          GEN_INT (size_needed - 1), count_exp, 1,
          OPTAB_DIRECT);
-          size_needed = desired_align - align + 1;
           if (tmp != count_exp)
             emit_move_insn (count_exp, tmp);
         }
@@ -18029,10 +18028,10 @@ ix86_expand_setmem (rtx dst, rtx count_e
     {
       if (force_loopy_epilogue)
         expand_setmem_epilogue_via_loop (dst, destreg, val_exp, count_exp,
-         size_needed);
+         epilogue_size_needed);
       else
         expand_setmem_epilogue (dst, destreg, promoted_val, count_exp,
-        size_needed);
+        epilogue_size_needed);
     }
   if (jump_around_label)
     emit_label (jump_around_label);

instead seems to fix memset-3.c with -mtune=pentium-m -m32 at all optimizations
levels (and is what ix86_expand_movmem does).  But memset-2.c still fails, and
not just at -O3, but also at -O2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38708


  parent reply	other threads:[~2009-01-03  9:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02 18:45 [Bug target/38708] New: [4.4 Regression] gcc.c-torture/execute/memset-3.c Fails with -march=pentium-m -O1 pinskia at gcc dot gnu dot org
2009-01-02 18:49 ` [Bug target/38708] " pinskia at gcc dot gnu dot org
2009-01-02 18:51 ` pinskia at gcc dot gnu dot org
2009-01-02 19:03 ` [Bug target/38708] [4.4 Regression] Revision 137646 caused gcc.c-torture/execute/memset-[23].c fail with -mtune=pentium-m hjl dot tools at gmail dot com
2009-01-02 22:03 ` hjl dot tools at gmail dot com
2009-01-02 22:10 ` [Bug target/38708] [4.4 Regression] Revision 137646 caused gcc.c-torture/execute/memset-[23].c fail with -mtune=pentiumpro pinskia at gcc dot gnu dot org
2009-01-03  8:47 ` jakub at gcc dot gnu dot org
2009-01-03  9:10 ` jakub at gcc dot gnu dot org [this message]
2009-01-03 10:27 ` jakub at gcc dot gnu dot org
2009-01-03 10:28 ` jakub at gcc dot gnu dot org
2009-01-03 11:40 ` jakub at gcc dot gnu dot org
2009-01-04 14:26 ` jakub at gcc dot gnu dot org
2009-01-05 11:32 ` rguenth at gcc dot gnu dot org
2009-01-05 11:44 ` rguenth at gcc dot gnu dot org
2009-01-06 11:13 ` jakub at gcc dot gnu dot org
2009-01-09 17:13 ` jakub at gcc dot gnu dot org
2009-01-09 17:14 ` jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090103090920.7485.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).