public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/38781] PR38151: valgrind finds problem
Date: Thu, 15 Jan 2009 21:51:00 -0000	[thread overview]
Message-ID: <20090115215104.5710.qmail@sourceware.org> (raw)
In-Reply-To: <bug-38781-9596@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from dcb314 at hotmail dot com  2009-01-15 21:51 -------
(In reply to comment #3)
> An updated patch is at
> 
> http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00747.html

I have a couple of minor questions about the coding style
of this patch.

1. Why is the "/ 8 / 8" a good idea ? 

Presumably "/ 64" doesn't do it right ?

2. On the middle condition of the for-loop, could it
be micro-optimised to compute the upper limit of the
for loop before the loop starts ?

For example, instead of

; (i < A) && (i + pos) < B; ++i

replace with 

const int limit = min( A, B - pos);

...

; i < limit; ++i


Just an idea.


-- 

dcb314 at hotmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38781


  parent reply	other threads:[~2009-01-15 21:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-09  9:53 [Bug c/38781] New: " dcb314 at hotmail dot com
2009-01-09 17:57 ` [Bug c/38781] " hjl dot tools at gmail dot com
2009-01-09 17:58 ` hjl dot tools at gmail dot com
2009-01-14 15:16 ` [Bug target/38781] " hjl dot tools at gmail dot com
2009-01-14 17:07 ` hjl dot tools at gmail dot com
2009-01-15 21:51 ` dcb314 at hotmail dot com [this message]
2009-03-29 19:34 ` hjl dot tools at gmail dot com
2009-03-30 14:30 ` hjl at gcc dot gnu dot org
2009-03-30 14:34 ` hjl dot tools at gmail dot com
2009-04-24  5:50 ` lauras at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090115215104.5710.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).