[Bug c++/38745] New: ICE: statement makes a memory store, but has no VDEFS

[Bug c++/38745] New: ICE: statement makes a memory store, but has no VDEFS

[patrakov at gmail dot com]

This may be related to PR c++/37553. I have a new testcase (will attach) that
triggers a different ICE on today's trunk GCC:

longs2.cpp: In function 'Record* GetEntry(Context*)':
longs2.cpp:182: error: statement makes a memory store, but has no VDEFS
VIEW_CONVERT_EXPR<union u_u64>(c64_76).u.lo32.u.lo16.u.lo8 = D.1947_8;
longs2.cpp:182: internal compiler error: verify_ssa failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

(-O1 or higher is required to see this).


-- 
           Summary: ICE: statement makes a memory store, but has no VDEFS
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: patrakov at gmail dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug c++/38745] ICE: statement makes a memory store, but has no VDEFS

[patrakov at gmail dot com]

------- Comment #1 from patrakov at gmail dot com  2009-01-06 16:29 -------
Created an attachment (id=17039)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17039&action=view)
Testcase

This unreadable code was mostly generated with macros.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug c++/38745] ICE: statement makes a memory store, but has no VDEFS

[patrakov at gmail dot com]

------- Comment #2 from patrakov at gmail dot com  2009-01-06 16:33 -------
Doug, I added you to CC: because you fixed PR c++/37553, and this looks
related. Sorry if I am wrong.


-- 

patrakov at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doug dot gregor at gmail dot
                   |                            |com
      Known to fail|                            |4.4.0
      Known to work|                            |4.3.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug middle-end/38745] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2009-01-06 18:09 -------
This is more likely a middle-end issue and most likely caused by me ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2009-01-06 18:12 -------
Yes this is caused by my patch, 
basically we need to stop frowproping into ADDR_EXPR, VIEW_CONVERT_EXPR.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |tree-optimization
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|i686-pc-linux-gnu           |
           Keywords|                            |ice-on-valid-code
            Summary|ICE: statement makes a      |[4.4 Regression] ICE:
                   |memory store, but has no    |statement makes a memory
                   |VDEFS                       |store, but has no VDEFS
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2009-01-06 18:13 -------
Note it is unrelated to PR 37553 and most likely can be reproduce with C code
...


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-01-06 18:13:29
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[hjl dot tools at gmail dot com]

------- Comment #6 from hjl dot tools at gmail dot com  2009-01-06 19:33 -------
It is caused by revision 141606:

http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00043.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2009-01-06 19:38 -------
(In reply to comment #6)
> It is caused by revision 141606:
> 
> http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00043.html

Caused, not really, exposed is more likely as I said it is really caused by the
introduction of fwprop using VCEs.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2009-01-16 02:01 -------
So the problem here is that we should not forward prop *(struct a*)&f into an
expression which is taking the address ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2009-01-16 02:11 -------
Index: tree-ssa-forwprop.c
===================================================================
--- tree-ssa-forwprop.c (revision 143415)
+++ tree-ssa-forwprop.c (working copy)
@@ -775,29 +775,43 @@ forward_propagate_addr_expr_1 (tree name
       && !TYPE_VOLATILE (TREE_TYPE (rhs))
       && !TYPE_VOLATILE (TREE_TYPE (TREE_OPERAND (def_rhs, 0)))
       && operand_equal_p (TYPE_SIZE (TREE_TYPE (rhs)),
-                         TYPE_SIZE (TREE_TYPE (TREE_OPERAND (def_rhs, 0))),
0)) 
+                         TYPE_SIZE (TREE_TYPE (TREE_OPERAND (def_rhs, 0))), 0)
+      /* Don't create a VCE inside an ADDR_EXPR which be used on the LHS later
+         on.  */
+      && gimple_assign_rhs_code (use_stmt) != ADDR_EXPR) 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2009-01-16 09:34 -------
Do we have a small testcase?

VIEW_CONVERT_EXPR<union u_u64>(c64_76).u.lo32.u.lo16.u.lo8 = D.1947_8;

indeed looks funny (it's a partial def of a register).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2009-01-16 22:11 -------
Semi small testcase:
union u_u16
{
  unsigned short v;
  struct
  {
    unsigned char lo8, hi8;
  } __attribute__ ((__may_alias__)) u;
} __attribute__ ((__may_alias__));
union u_u32
{
  unsigned int v;
  struct
  {
    u_u16 lo16, hi16;
  } u;
} __attribute__ ((__may_alias__));
union u_u64
{
  struct
  {
    u_u32 lo32, hi32;
  } u;
};
struct Record
{
};
long long
UnpackFullKey (Record & rec, const char *&p)
{
  long long c64 = 0;
  (*(u_u16 *) & (*(u_u32 *) & ( *(u_u64*)&c64).u.lo32.v).u.lo16.v).u.hi8 =
    1;
  return c64;
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2009-01-22 23:10 -------
Hm, the first forwprop dump looks sane:

  VIEW_CONVERT_EXPR<union u_u64>(c64).u.lo32.u.lo16.u.hi8 ={v} 1;

but then addressables1 comes along and rewrites c64 into SSA form ... and if
you fix it then the duplicate in tree-ssa-alias.c comes along and does it
again.

Maybe I should merge the split of addressables from tree-ssa-alias.c from
the alias-improvements branch.

Trivial fix for addressables:

Index: tree-ssa.c
===================================================================
--- tree-ssa.c  (revision 143555)
+++ tree-ssa.c  (working copy)
@@ -1728,7 +1728,8 @@ execute_update_addresses_taken (void)
       /* Global Variables, result decls cannot be changed.  */
       if (is_global_var (var)
           || TREE_CODE (var) == RESULT_DECL
-         || bitmap_bit_p (addresses_taken, DECL_UID (var)))
+         || bitmap_bit_p (addresses_taken, DECL_UID (var))
+         || bitmap_bit_p (not_reg_needs, DECL_UID (var)))
        continue;

       if (TREE_ADDRESSABLE (var))
@@ -1746,7 +1747,6 @@ execute_update_addresses_taken (void)
            }
        }
       if (!DECL_GIMPLE_REG_P (var)
-         && !bitmap_bit_p (not_reg_needs, DECL_UID (var))
          && (TREE_CODE (TREE_TYPE (var)) == COMPLEX_TYPE
              || TREE_CODE (TREE_TYPE (var)) == VECTOR_TYPE))
        {


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2009-01-22 23:20 -------
>Maybe I should merge the split of addressables from tree-ssa-alias.c from
the alias-improvements branch.

There are two things, first c64 really should not be TREE_ADDRESSABLE but
rather !DECL_GIMPLE_REG_P.  But that is too big for this stage of compiling and
has unknown effects.  I will do it for 4.5 and remove the special casing here.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #14 from rguenth at gcc dot gnu dot org  2009-01-22 23:21 -------
non-optimal tree-ssa-alias.c part:

Index: tree-ssa-alias.c
===================================================================
--- tree-ssa-alias.c    (revision 143555)
+++ tree-ssa-alias.c    (working copy)
@@ -2483,6 +2483,21 @@ update_alias_info_1 (gimple stmt, struct
   if (addr_taken)
     bitmap_ior_into (gimple_addressable_vars (cfun), addr_taken);

+  /* If we have a call or an assignment, see if the lhs contains
+     a local decl that requires not to be a gimple register.  */
+  if (gimple_code (stmt) == GIMPLE_ASSIGN
+      || gimple_code (stmt) == GIMPLE_CALL)
+    {
+      tree lhs = gimple_get_lhs (stmt);
+      /* A plain decl does not need it set.  */
+      if (lhs && handled_component_p (lhs))
+       {
+         tree var = get_base_address (lhs);
+         if (DECL_P (var))
+           bitmap_set_bit (gimple_addressable_vars (cfun), DECL_UID (var));
+       }
+    }
+
   /* Process each operand use.  For pointers, determine whether they
      are dereferenced by the statement, or whether their value
      escapes, etc.  */


which then fixes the testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2009-01-22 23:23 -------
Hm?  Non-TREE_ADDRESSABLE non-SSA vars are fine.  It isn't DECL_GIMPLE_REG_P
either of course.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2009-01-25 11:40 -------
Mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pinskia at gcc dot gnu dot  |rguenth at gcc dot gnu dot
                   |org                         |org
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2009-
                   |                            |01/msg01172.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2009-01-26 09:55 -------
Subject: Bug 38745

Author: rguenth
Date: Mon Jan 26 09:55:30 2009
New Revision: 143673

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143673
Log:
2009-01-26  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/38745
        * tree-ssa.c (execute_update_addresses_taken): Do not include
        variables that cannot possibly be a register in not_reg_needs.
        Do not clear TREE_ADDRESSABLE on vars that may not become
        registers.
        * tree-ssa.c (update_alias_info_1): Include those in the set
        of addressable vars.

        * g++.dg/torture/pr38745.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr38745.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-alias.c
    trunk/gcc/tree-ssa.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2009-01-26 09:55 -------
Subject: Bug 38745

Author: rguenth
Date: Mon Jan 26 09:55:30 2009
New Revision: 143673

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143673
Log:
2009-01-26  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/38745
        * tree-ssa.c (execute_update_addresses_taken): Do not include
        variables that cannot possibly be a register in not_reg_needs.
        Do not clear TREE_ADDRESSABLE on vars that may not become
        registers.
        * tree-ssa.c (update_alias_info_1): Include those in the set
        of addressable vars.

        * g++.dg/torture/pr38745.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr38745.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-alias.c
    trunk/gcc/tree-ssa.c


------- Comment #18 from rguenth at gcc dot gnu dot org  2009-01-26 09:55 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[rguenth at gcc dot gnu dot org]

------- Comment #19 from rguenth at gcc dot gnu dot org  2009-01-26 15:03 -------
Subject: Bug 38745

Author: rguenth
Date: Mon Jan 26 15:03:30 2009
New Revision: 143676

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143676
Log:
2009-01-26  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/38745
        * tree-ssa-alias.c (update_alias_info_1): Exclude RESULT_DECL
        from special handling.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa-alias.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745

[Bug tree-optimization/38745] [4.4 Regression] ICE: statement makes a memory store, but has no VDEFS

[hjl at gcc dot gnu dot org]

------- Comment #20 from hjl at gcc dot gnu dot org  2009-01-30 17:32 -------
Subject: Bug 38745

Author: hjl
Date: Fri Jan 30 17:31:24 2009
New Revision: 143798

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143798
Log:
2009-01-30  H.J. Lu  <hongjiu.lu@intel.com>

        2009-01-27  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/38503
        * g++.dg/warn/Wstrict-aliasing-bogus-placement-new.C: New testcase.

        2009-01-26  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/38745
        * g++.dg/torture/pr38745.C: New testcase.

        2009-01-26  Richard Guenther  <rguenther@suse.de>

        PR middle-end/38851
        * g++.dg/warn/Wuninitialized-1.C: New testcase.

        2009-01-20  Andrew Pinski  <andrew_pinski@playstation.sony.com>
                    Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/38747
        PR tree-optimization/38748
        * gcc.dg/tree-ssa/struct-aliasing-1.c: New test.
        * gcc.c-torture/execute/struct-aliasing-1.c: Likewise.

Added:
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/torture/pr38745.C
      - copied unchanged from r143797,
trunk/gcc/testsuite/g++.dg/torture/pr38745.C
   
branches/gcc-4_3-branch/gcc/testsuite/g++.dg/warn/Wstrict-aliasing-bogus-placement-new.C
      - copied unchanged from r143797,
trunk/gcc/testsuite/g++.dg/warn/Wstrict-aliasing-bogus-placement-new.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/warn/Wuninitialized-1.C
      - copied unchanged from r143797,
trunk/gcc/testsuite/g++.dg/warn/Wuninitialized-1.C
   
branches/gcc-4_3-branch/gcc/testsuite/gcc.c-torture/execute/struct-aliasing-1.c
      - copied unchanged from r143797,
trunk/gcc/testsuite/gcc.c-torture/execute/struct-aliasing-1.c
    branches/gcc-4_3-branch/gcc/testsuite/gcc.dg/tree-ssa/struct-aliasing-1.c
      - copied unchanged from r143797,
trunk/gcc/testsuite/gcc.dg/tree-ssa/struct-aliasing-1.c
Modified:
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38745