[Bug c++/34015] New: warning in backward_warning.h is illegible

[Bug c++/34015] New: warning in backward_warning.h is illegible

[benoit dot hudson at gmail dot com]

Using gcc version 4.3.0 20071102 (experimental) (GCC)

When I use <ext/hash_set> I get a one-line warning copied below.  It is
essentially illegible; perhaps it should point to a web page instead where the
question of what replaces what and how can properly be explained?


/Users/bhudson/gcc-4.3-snapshot/lib/gcc/i386-apple-darwin8.10.2/4.3.0/../../../../include/c++/4.3.0/backward/backward_warning.h:32:2:
error: #warning This file includes at least one deprecated or antiquated
header. Please consider use of an equivalent, non-deprecated interface for the
requested functionality. A list of valid replacements is as follows: Use:
Instead of: <sstream>, basic_stringbuf <strstream>, strstreambuf <sstream>,
basic_istringstream <strstream>, istrstream <sstream>, basic_ostringstream
<strstream>, ostrstream <sstream>, basic_stringstream <strstream>, strstream
<unordered_set>, unordered_set <ext/hash_set>, hash_set <unordered_set>,
unordered_multiset <ext/hash_set>, hash_multiset <unordered_map>, unordered_map
<ext/hash_set>, hash_map <unordered_map>, unordered_multimap <ext/hash_set>,
hash_multimap <functional>, bind <functional>, binder1st <functional>, bind
<functional>, binder2nd <functional>, bind <functional>, bind1st <functional>,
bind <functional>, bind2nd <memory>, unique_ptr <memory>, auto_ptr To disable
this warning use -Wno-deprecated.


-- 
           Summary: warning in backward_warning.h is illegible
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: benoit dot hudson at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug c++/34015] warning in backward_warning.h is illegible

[manu at gcc dot gnu dot org]

------- Comment #1 from manu at gcc dot gnu dot org  2007-11-08 10:56 -------
We cannot assume that people encountering the warning will have web access.
The warning can certainly be improved. 

"A list of valid replacements is as follows: Use: Instead of:" 
This doesn't actually explain what follows.

"<sstream>, basic_stringbuf <strstream>, strstreambuf <sstream>,
basic_istringstream <strstream>,"
The comma makes it look like you should use basic_stringbuf instead of
<strstream>.
Also, if strstream is replaced by several, it will be convenient to group them
(<strstream> replaced by strstreambuf, ostrstream)

"To disable this warning use -Wno-deprecated."
There is a period missing before this sentence. I think it should go earlier,
so there is nothing else after the list of replacements.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-11-08 10:56:30
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug c++/34015] warning in backward_warning.h is illegible

[pcarlini at suse dot de]

------- Comment #2 from pcarlini at suse dot de  2007-11-08 11:05 -------
Let's add Benjamin in CC...


-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkoz at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

Re: [Bug c++/34015] warning in backward_warning.h is illegible

[Gabriel Dos Reis]

"manu at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| We cannot assume that people encountering the warning will have web access.

That is true.  But, the majority of for those who do have a web
access, we should provide additional pointers.

Of course, the real solution is to leave these headers as they were
in previous GCC releases.

-- Gaby

[Bug c++/34015] warning in backward_warning.h is illegible

[gdr at cs dot tamu dot edu]

------- Comment #3 from gdr at cs dot tamu dot edu  2007-11-08 11:23 -------
Subject: Re:  warning in backward_warning.h is illegible

"manu at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| We cannot assume that people encountering the warning will have web access.

That is true.  But, the majority of for those who do have a web
access, we should provide additional pointers.

Of course, the real solution is to leave these headers as they were
in previous GCC releases.

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug c++/34015] warning in backward_warning.h is illegible

[manu at gcc dot gnu dot org]

------- Comment #4 from manu at gcc dot gnu dot org  2007-11-08 13:13 -------
This is my proposal.

"This header is deprecated and may be removed in the future.  Please, consider
using an equivalent, non-deprecated interface for the requested functionality. 
To disable this warning use -Wno-deprecated.  A list of valid replacements is
as follows: 
<sstream> is replaced by <basic_stringbuf>, <basic_istringstream>,
<basic_ostringstream>, <basic_stringstream>;  <strstream> is replaced by
<strstream>, <strstreambuf>, <istrstream>, <ostrstream>;  <unordered_set> is
replaced by <unordered_set>, <unordered_multiset>;  <ext/hash_set> is replaced
by <hash_set>, <hash_multiset>, <hash_map>, <hash_multimap>;  <unordered_map>
is replaced by <unordered_map>, <unordered_multimap>;  <functional> is replaced
by <bind>, <binder1st>, <binder2nd>;  <memory> is replaced by <unique_ptr>,
<auto_ptr>."

I just re-organized the information, not sure if it is actually correct. I
noticed that <strstream> is replaced by <strstream>. So how would you get a
warning there? The same happens with <unordered_set>. How can a header be
replaced with the a new header with the same name?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug c++/34015] warning in backward_warning.h is illegible

[benoit dot hudson at gmail dot com]

------- Comment #5 from benoit dot hudson at gmail dot com  2007-11-08 15:35 -------
The fact that the error appears in backward_warning.h is another annoyance,
which is probably why the overly long descriptive message is there.  Better
would be that #include <ext/hash_set> would only report "<ext/hash_set> is
deprecated; please use <hash_set> instead."  Then the file listed as generating
the problem is hash_set included from the user's code, and the message
specifically says what's wrong, and the message fits on one line in a standard
terminal.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug libstdc++/34015] warning in backward_warning.h is illegible

[bkoz at gcc dot gnu dot org]

-- 

bkoz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bkoz at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-11-08 10:56:30         |2007-11-20 06:03:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug libstdc++/34015] warning in backward_warning.h is illegible

[bkoz at gcc dot gnu dot org]

------- Comment #6 from bkoz at gcc dot gnu dot org  2007-12-11 21:48 -------
Subject: Bug 34015

Author: bkoz
Date: Tue Dec 11 21:48:16 2007
New Revision: 130778

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130778
Log:
2007-12-11  Benjamin Kosnik  <bkoz@redhat.com>

        PR libstdc++/34015
        * include/backward/backward_warning.h: Adjust warning message.



Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/backward/backward_warning.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug libstdc++/34015] warning in backward_warning.h is illegible

[bkoz at gcc dot gnu dot org]

------- Comment #7 from bkoz at gcc dot gnu dot org  2008-04-24 17:27 -------

The goal for warnings should be to use an attribute on the specific class or
function in question, not on a per-file basis.

Unfortunately this does not work at the moment. So, the backwards_warning.h
file has been adjusted to make it a bit more clear as to what is going on, and
what should be used for deprecated items.

Therefore I would like to close or suspend this PR if submitter agrees.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug libstdc++/34015] warning in backward_warning.h is illegible

[manu at gcc dot gnu dot org]

------- Comment #8 from manu at gcc dot gnu dot org  2008-08-26 11:13 -------
(In reply to comment #7)
> The goal for warnings should be to use an attribute on the specific class or
> function in question, not on a per-file basis.

Care to elaborate? I don't understand what you mean here.

> Unfortunately this does not work at the moment. So, the backwards_warning.h
> file has been adjusted to make it a bit more clear as to what is going on, and
> what should be used for deprecated items.

I thought we handled newlines "\n" within strings given to #error. Is this
forbidden by any standard?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015

[Bug libstdc++/34015] warning in backward_warning.h is illegible

[manu at gcc dot gnu dot org]

------- Comment #9 from manu at gcc dot gnu dot org  2009-02-07 14:44 -------
Closing. Nobody cares enough to fix this in any other way and GCC 4.3.0 is out
already.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34015