[Bug c++/28274] New: Redeclaration with extra default argument doesn't work

[Bug c++/28274] New: Redeclaration with extra default argument doesn't work

[amylaar at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

bash-2.05b$ cat defarg.C
int f (int i, int j = 0);
int f (int i = 0, int j);
bash-2.05b$ ./cc1plus defarg.C  -quiet
defarg.C:2: error: default argument missing for parameter 2 of ‘int f(int,
int)’
defarg.C:2: error: default argument given for parameter 2 of ‘int f(int, int)’
defarg.C:1: error: after previous specification in ‘int f(int, int)’


-- 
           Summary: Redeclaration with extra default argument doesn't work
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: amylaar at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
      Known to fail|                            |4.1.1
      Known to work|3.3.6                       |3.3.6 3.4.0
            Summary|Redeclaration with extra    |[4.1/4.2 Regression]
                   |default argument doesn't    |Redeclaration with extra
                   |work                        |default argument doesn't
                   |                            |work
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-07-06 03:08 -------
Confirmed, at least a 4.1/4.2 regression, I cannot test 4.0.x but I do know
that "4.1.0 20051026" worked and so did "4.0.0 20050225".


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-07-06 03:08:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[reichelt at gcc dot gnu dot org]

------- Comment #2 from reichelt at gcc dot gnu dot org  2006-07-27 20:31 -------
This was caused by my patch for PR 16829.
I'll take care of it.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |monitored
      Known to fail|4.1.1                       |3.4.6 4.0.3 4.1.0 4.1.1
                   |                            |4.2.0
      Known to work|3.3.6 3.4.0                 |3.3.6 3.4.0 3.4.5 4.0.2
            Summary|[4.1/4.2 Regression]        |[4.0/4.1/4.2 Regression]
                   |Redeclaration with extra    |Redeclaration with extra
                   |default argument doesn't    |default argument doesn't
                   |work                        |work
   Target Milestone|4.1.2                       |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[patchapp at dberlin dot org]

------- Comment #3 from patchapp at dberlin dot org  2006-07-28 11:35 -------
Subject: Bug number PR c++/28274

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-07/msg01189.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[reichelt at gcc dot gnu dot org]

------- Comment #4 from reichelt at gcc dot gnu dot org  2006-08-03 02:30 -------
Subject: Bug 28274

Author: reichelt
Date: Thu Aug  3 02:30:49 2006
New Revision: 115893

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115893
Log:
        PR c++/28274
        * decl.c (duplicate_decls): Call check_default_args here.
        (start_preparsed_function): Do not call check_default_args.
        * name-lookup.c (pushdecl_maybe_friend): Only call
        check_default_args if duplicate_decls got bypassed.

        * g++.dg/other/default5.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/other/default5.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[reichelt at gcc dot gnu dot org]

------- Comment #5 from reichelt at gcc dot gnu dot org  2006-08-03 02:34 -------
Subject: Bug 28274

Author: reichelt
Date: Thu Aug  3 02:34:14 2006
New Revision: 115894

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115894
Log:
        PR c++/28274
        * decl.c (duplicate_decls): Call check_default_args here.
        (start_preparsed_function): Do not call check_default_args.
        * name-lookup.c (pushdecl_maybe_friend): Only call
        check_default_args if duplicate_decls got bypassed.

        * g++.dg/other/default5.C: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/other/default5.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/decl.c
    branches/gcc-4_1-branch/gcc/cp/name-lookup.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[reichelt at gcc dot gnu dot org]

------- Comment #6 from reichelt at gcc dot gnu dot org  2006-08-03 02:41 -------
Subject: Bug 28274

Author: reichelt
Date: Thu Aug  3 02:41:33 2006
New Revision: 115895

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115895
Log:
        PR c++/28274
        * decl.c (duplicate_decls): Call check_default_args here.
        (start_preparsed_function): Do not call check_default_args.
        * name-lookup.c (pushdecl_maybe_friend): Only call
        check_default_args if duplicate_decls got bypassed.

        * g++.dg/other/default5.C: New test.

Added:
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/other/default5.C
Modified:
    branches/gcc-4_0-branch/gcc/cp/ChangeLog
    branches/gcc-4_0-branch/gcc/cp/decl.c
    branches/gcc-4_0-branch/gcc/cp/name-lookup.c
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[reichelt at gcc dot gnu dot org]

------- Comment #7 from reichelt at gcc dot gnu dot org  2006-08-03 03:10 -------
Fixed on mainline, 4.1 branch, and 4.0 branch.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|3.4.6 4.0.3 4.1.0 4.1.1     |3.4.6 4.0.3 4.1.0 4.1.1
                   |4.2.0                       |
      Known to work|3.3.6 3.4.0 3.4.5 4.0.2     |3.3.6 3.4.0 3.4.5 4.0.2
                   |                            |4.0.4 4.1.2 4.2.0
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-09-22 08:04 -------
*** Bug 29177 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |greifel at megatop200 dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.0/4.1/4.2 Regression] Redeclaration with extra default argument doesn't work

[jason at gcc dot gnu dot org]

------- Comment #9 from jason at gcc dot gnu dot org  2009-02-11 21:28 -------
This is still broken inside extern "C":

extern "C" {
void foo (int i, int j = 6);
void foo (int i = 4, int j);
}


-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.2/4.3/4.4 Regression] Redeclaration with extra default argument doesn't work

[jason at gcc dot gnu dot org]

------- Comment #10 from jason at gcc dot gnu dot org  2009-02-11 21:31 -------
The extern "C" testcase passed under the 3.2 compiler; marking as regression.


-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|3.3.6 3.4.0 3.4.5 4.0.2     |3.3.6 3.4.0 3.4.5 4.0.2
                   |4.0.4 4.1.2 4.2.0           |4.0.4 4.1.2
           Priority|P1                          |P2
            Summary|[4.0/4.1/4.2 Regression]    |[4.2/4.3/4.4 Regression]
                   |Redeclaration with extra    |Redeclaration with extra
                   |default argument doesn't    |default argument doesn't
                   |work                        |work


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.2/4.3/4.4 Regression] Redeclaration with extra default argument doesn't work

[andreasmeier80 at gmx dot de]

------- Comment #11 from andreasmeier80 at gmx dot de  2009-02-25 10:33 -------
The target milestone 4.0.4 is wrong 


-- 

andreasmeier80 at gmx dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreasmeier80 at gmx dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.2/4.3/4.4 Regression] Redeclaration with extra default argument doesn't work

[reichelt at gcc dot gnu dot org]

------- Comment #12 from reichelt at gcc dot gnu dot org  2009-02-25 21:00 -------
The culprit is in the function pushdecl_maybe_friend:
Functions declared extern "C" bypass the usual mechanism, because
duplicate_decls isn't called for them (see lines 727ff):

          else if ((DECL_EXTERN_C_FUNCTION_P (x)
                    || DECL_FUNCTION_TEMPLATE_P (x))
                   && is_overloaded_fn (t))
            /* Don't do anything just yet.  */;
          else if (t == wchar_decl_node)
            [...snip...]
          else
            {
              tree olddecl = duplicate_decls (x, t, is_friend);

Later only the binding for such functions is compared, which doesn't
take default parameters into account (see line 778ff):

      if ((TREE_CODE (x) == FUNCTION_DECL)
          && DECL_EXTERN_C_P (x)
          /* We should ignore declarations happening in system headers.  */
          && !DECL_IN_SYSTEM_HEADER (x))
        {
          cxx_binding *function_binding =
              lookup_extern_c_fun_binding_in_all_ns (x);
          if (function_binding
              && !DECL_IN_SYSTEM_HEADER (function_binding->value))
            {
              tree previous = function_binding->value;

              /* In case either x or previous is declared to throw an
exception,
                 make sure both exception specifications are equal.  */
              if (decls_match (x, previous))
               [...snip...]

            }
        }

      if (TREE_CODE (x) == FUNCTION_DECL || DECL_FUNCTION_TEMPLATE_P (x))
        check_default_args (x);

I'm not sure how to proceed from here, so unassigning.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org
         AssignedTo|reichelt at gcc dot gnu dot |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|REOPENED                    |NEW
      Known to fail|3.4.6 4.0.3 4.1.0 4.1.1     |3.4.6 4.0.3 4.1.0 4.2.0
                   |                            |4.3.0
      Known to work|3.3.6 3.4.0 3.4.5 4.0.2     |3.3.6 3.4.0 3.4.5 4.0.0
                   |4.0.4 4.1.2                 |4.0.1 4.0.2
   Target Milestone|4.0.4                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.2/4.3/4.4 Regression] Redeclaration with extra default argument doesn't work

[jason at gcc dot gnu dot org]

------- Comment #13 from jason at gcc dot gnu dot org  2009-03-24 22:26 -------
Subject: Bug 28274

Author: jason
Date: Tue Mar 24 22:26:21 2009
New Revision: 145042

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=145042
Log:
        PR c++/28274
        * name-lookup.c (pushdecl_maybe_friend): Check default args later.

Added:
    trunk/gcc/testsuite/g++.dg/parse/defarg14.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.2/4.3 Regression] Redeclaration with extra default argument doesn't work

[jason at gcc dot gnu dot org]

------- Comment #14 from jason at gcc dot gnu dot org  2009-03-24 22:27 -------
Fixed for 4.4.


-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.2/4.3/4.4 Regression]    |[4.2/4.3 Regression]
                   |Redeclaration with extra    |Redeclaration with extra
                   |default argument doesn't    |default argument doesn't
                   |work                        |work


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.3 Regression] Redeclaration with extra default argument doesn't work

[jsm28 at gcc dot gnu dot org]

------- Comment #15 from jsm28 at gcc dot gnu dot org  2009-03-31 19:39 -------
Closing 4.2 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.2/4.3 Regression]        |[4.3 Regression]
                   |Redeclaration with extra    |Redeclaration with extra
                   |default argument doesn't    |default argument doesn't
                   |work                        |work
   Target Milestone|4.2.5                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.3 Regression] Redeclaration with extra default argument doesn't work

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2009-08-04 12:27 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274

[Bug c++/28274] [4.3 Regression] Redeclaration with extra default argument doesn't work

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2010-05-22 18:11 -------
GCC 4.3.5 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.5                       |4.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28274