public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/39343] New: [4.4 Regression] Wrong result for __builtin_object_size (x, 1)
@ 2009-03-02 12:36 jakub at gcc dot gnu dot org
2009-03-02 12:38 ` [Bug tree-optimization/39343] " jakub at gcc dot gnu dot org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-03-02 12:36 UTC (permalink / raw)
To: gcc-bugs
extern inline __attribute__ ((__always_inline__)) int
foo (char *dest)
{
return __builtin_object_size (dest, 1);
}
struct S
{
union
{
struct { int a, b; char c, d; } f;
struct { struct { int a, b; char c, d[255]; } e; } g;
} u;
};
int
main (void)
{
struct S s;
return foo (s.u.g.e.d) < 255;
}
fails since:
2008-08-13 Richard Guenther <rguenther@suse.de>
* tree.h (maybe_fold_offset_to_address): Declare.
* tree-ssa-ccp.c (surely_varying_stmt_p): Fix typo in last commit.
(ccp_fold): Handle pointer conversions the same as fold_stmt.
Likewise for POINTER_PLUS_EXPR.
(maybe_fold_offset_to_reference): Enable disabled code.
(maybe_fold_offset_to_address): New function.
(fold_stmt_r): Use it.
(fold_gimple_assign): Likewise.
* gimplify.c (gimplify_conversion): Use maybe_fold_offset_to_address.
(gimplify_expr): Likewise.
During gimplification foo ((char *) &s.u.g.e.d) is changed into:
foo (&s.u.f.d), where the former has __builtin_object_size (x, 1) 255, while
the latter just 1.
--
Summary: [4.4 Regression] Wrong result for __builtin_object_size
(x, 1)
Product: gcc
Version: 4.4.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P3
Component: tree-optimization
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jakub at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39343
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/39343] [4.4 Regression] Wrong result for __builtin_object_size (x, 1)
2009-03-02 12:36 [Bug tree-optimization/39343] New: [4.4 Regression] Wrong result for __builtin_object_size (x, 1) jakub at gcc dot gnu dot org
@ 2009-03-02 12:38 ` jakub at gcc dot gnu dot org
2009-03-02 15:24 ` jakub at gcc dot gnu dot org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-03-02 12:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from jakub at gcc dot gnu dot org 2009-03-02 12:38 -------
This causes valid programs to abort with -D_FORTIFY_SOURCE=2, when strcpy etc.
is used to initialize that field. For memcpy etc. it makes no difference,
those use __builtin_object_size (x, 0) always.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Target Milestone|--- |4.4.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39343
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/39343] [4.4 Regression] Wrong result for __builtin_object_size (x, 1)
2009-03-02 12:36 [Bug tree-optimization/39343] New: [4.4 Regression] Wrong result for __builtin_object_size (x, 1) jakub at gcc dot gnu dot org
2009-03-02 12:38 ` [Bug tree-optimization/39343] " jakub at gcc dot gnu dot org
@ 2009-03-02 15:24 ` jakub at gcc dot gnu dot org
2009-03-03 11:30 ` jakub at gcc dot gnu dot org
2009-03-03 11:30 ` jakub at gcc dot gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-03-02 15:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from jakub at gcc dot gnu dot org 2009-03-02 15:24 -------
Testing a patch.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |jakub at gcc dot gnu dot org
|dot org |
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2009-03-02 15:24:22
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39343
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/39343] [4.4 Regression] Wrong result for __builtin_object_size (x, 1)
2009-03-02 12:36 [Bug tree-optimization/39343] New: [4.4 Regression] Wrong result for __builtin_object_size (x, 1) jakub at gcc dot gnu dot org
` (2 preceding siblings ...)
2009-03-03 11:30 ` jakub at gcc dot gnu dot org
@ 2009-03-03 11:30 ` jakub at gcc dot gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-03-03 11:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from jakub at gcc dot gnu dot org 2009-03-03 11:30 -------
Fixed.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39343
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/39343] [4.4 Regression] Wrong result for __builtin_object_size (x, 1)
2009-03-02 12:36 [Bug tree-optimization/39343] New: [4.4 Regression] Wrong result for __builtin_object_size (x, 1) jakub at gcc dot gnu dot org
2009-03-02 12:38 ` [Bug tree-optimization/39343] " jakub at gcc dot gnu dot org
2009-03-02 15:24 ` jakub at gcc dot gnu dot org
@ 2009-03-03 11:30 ` jakub at gcc dot gnu dot org
2009-03-03 11:30 ` jakub at gcc dot gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-03-03 11:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from jakub at gcc dot gnu dot org 2009-03-03 11:30 -------
Subject: Bug 39343
Author: jakub
Date: Tue Mar 3 11:29:51 2009
New Revision: 144571
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144571
Log:
PR tree-optimization/39343
* tree-ssa-ccp.c (maybe_fold_offset_to_address): Don't check if
COMPONENT_REF t has ARRAY_TYPE.
* gcc.dg/pr39343.c: New test.
Added:
trunk/gcc/testsuite/gcc.dg/pr39343.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-ssa-ccp.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39343
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-03 11:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-02 12:36 [Bug tree-optimization/39343] New: [4.4 Regression] Wrong result for __builtin_object_size (x, 1) jakub at gcc dot gnu dot org
2009-03-02 12:38 ` [Bug tree-optimization/39343] " jakub at gcc dot gnu dot org
2009-03-02 15:24 ` jakub at gcc dot gnu dot org
2009-03-03 11:30 ` jakub at gcc dot gnu dot org
2009-03-03 11:30 ` jakub at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).