[Bug fortran/39292] New: [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[Bug fortran/39292] New: [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[rguenth at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

program bug
         integer :: n
         real, dimension(2) ::&
            &a = (/ ( (float(n))**(1.0), n=1,2) /)
         write(*,*) a(1), a(2)
         stop
      end program bug

gfortran-4.3 -S t.f90 
t.f90: In function ‘bug’:
t.f90:1: internal compiler error: in gfc_conv_array_initializer, at
fortran/trans-array.c:3884
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugs.opensuse.org/> for instructions.


-- 
           Summary: [4.3/4.4 Regression] ICE in gfc_conv_array_initializer,
                    at fortran/trans-array.c:3884
           Product: gcc
           Version: 4.3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2009-02-24 16:48 -------
Fails the same with 4.4, 4.2 reports an error:

gfortran-4.2 -S t.f90 
t.f90:4.35:

            &a = (/ ( (float(n))**(1.0), n=1,2) /)
                                  1
Error: Exponent at (1) must be INTEGER for an initialization expression

so I'm not sure if the testcase is valid or not.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.3.4 4.4.0
      Known to work|                            |4.2.4
           Priority|P3                          |P4
   Target Milestone|---                         |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[kargl at gcc dot gnu dot org]

------- Comment #2 from kargl at gcc dot gnu dot org  2009-02-24 17:09 -------

(In reply to comment #1)
> Fails the same with 4.4, 4.2 reports an error:
> 
> gfortran-4.2 -S t.f90 
> t.f90:4.35:
> 
>             &a = (/ ( (float(n))**(1.0), n=1,2) /)
>                                   1
> Error: Exponent at (1) must be INTEGER for an initialization expression
> 
> so I'm not sure if the testcase is valid or not.
> 

It is invalid in Fortran 95, and the error message is correct.
It is valid in Fortran 2003.

The patch in 
http://gcc.gnu.org/ml/fortran/2009-01/msg00231.html
may fix your problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2009-02-24 18:26 -------
Steve,

> The patch in 
> http://gcc.gnu.org/ml/fortran/2009-01/msg00231.html
> may fix your problem.
> 

It does - you are right!  I'll post a response to your patch that it should be
applied to 4.4 to fix this regression.

Thanks

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-02-24 18:26:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[kargl at gcc dot gnu dot org]

------- Comment #4 from kargl at gcc dot gnu dot org  2009-02-24 19:28 -------
(In reply to comment #3)
> Steve,
> 
> > The patch in 
> > http://gcc.gnu.org/ml/fortran/2009-01/msg00231.html
> > may fix your problem.
> > 
> 
> It does - you are right!  I'll post a response to your patch that it should be
> applied to 4.4 to fix this regression.
> 
> Thanks
> 
> Paul
> 

At this stage in the 4.4 release process, I think my patch is too risky.
I've only done some limited testing.  This should probably be considered
a 4.5 patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2009-02-25 13:05 -------
Steve,

> 
> At this stage in the 4.4 release process, I think my patch is too risky.
> I've only done some limited testing.  This should probably be considered
> a 4.5 patch.
> 

Should I apply mine, with a check that the expression is constant?

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2009-02-26 06:24 -------
Subject: Bug 39292

Author: pault
Date: Thu Feb 26 06:23:42 2009
New Revision: 144444

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144444
Log:
2009-02-26  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/39292
        * trans-array.c (gfc_conv_array_initializer): Convert all
        expressions rather than ICEing.

2009-02-26  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/39292
        * gfortran.dg/initialization_22.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/initialization_22.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #7 from pault at gcc dot gnu dot org  2009-02-26 09:34 -------
Fixed on trunk.

Thanks for the report, Richard

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2009-02-26 09:37 -------
Not fixed on the branch.  If you don't want to fix it there please adjust
the target milestone appropriately.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
      Known to fail|4.3.4 4.4.0                 |4.3.4
      Known to work|4.2.4                       |4.2.4 4.4.0
         Resolution|FIXED                       |
            Summary|[4.3/4.4 Regression] ICE in |[4.3 Regression] ICE in
                   |gfc_conv_array_initializer, |gfc_conv_array_initializer,
                   |at fortran/trans-           |at fortran/trans-
                   |array.c:3884                |array.c:3884


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #9 from pault at gcc dot gnu dot org  2009-02-26 10:21 -------
(In reply to comment #8)
> Not fixed on the branch.  If you don't want to fix it there please adjust
> the target milestone appropriately.
> 

Duuuh!

No, that's fine.  I'll give it a few days on trunk and then fix it on 4.3.

Cheers

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|REOPENED                    |ASSIGNED
   Last reconfirmed|2009-02-24 18:26:11         |2009-02-26 18:46:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #10 from pault at gcc dot gnu dot org  2009-03-07 15:56 -------
Subject: Bug 39292

Author: pault
Date: Sat Mar  7 15:56:37 2009
New Revision: 144694

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144694
Log:
2009-03-07  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/39292
        * trans-array.c (gfc_conv_array_initializer): Convert all
        expressions rather than ICEing.

2009-03-07  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/39292
        * gfortran.dg/initialization_22.f90: New test.

Added:
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/initialization_22.f90
Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/trans-array.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292

[Bug fortran/39292] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:3884

[pault at gcc dot gnu dot org]

------- Comment #11 from pault at gcc dot gnu dot org  2009-03-07 15:59 -------
Fixed on trunk and 4.3.

Thanks for the report.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39292