[Bug target/39327] New: Incorrect addsub patterns in sse.md

[Bug target/39327] New: Incorrect addsub patterns in sse.md

[hjl dot tools at gmail dot com]

SSE addsubpX does

Adds odd-numbered single-precision floating-point values of the first source
operand
(second operand) with the corresponding single-precision floating-point values
from
the second source operand (third operand); stores the result in the
odd-numbered
values of the destination operand (first operand). Subtracts the even-numbered
single-precision floating-point values from the second source operand from the
corresponding single-precision floating values in the first source operand;
stores the
result into the even-numbered values of the destination operand.

They are implemented as

(define_insn "sse3_addsubv4sf3"
  [(set (match_operand:V4SF 0 "register_operand" "=x")
        (vec_merge:V4SF
          (plus:V4SF
            (match_operand:V4SF 1 "register_operand" "0")
            (match_operand:V4SF 2 "nonimmediate_operand" "xm"))
          (minus:V4SF (match_dup 1) (match_dup 2))
          (const_int 5)))]
  "TARGET_SSE3"
  "addsubps\t{%2, %0|%0, %2}"
  [(set_attr "type" "sseadd")
   (set_attr "prefix_rep" "1")
   (set_attr "mode" "V4SF")])

We have

@item (vec_merge:@var{m} @var{vec1} @var{vec2} @var{items})
This describes a merge operation between two vectors.  The result is a vector
of mode @var{m}; its elements are selected from either @var{vec1} or
@var{vec2}.  Which elements are selected is described by @var{items}, which
is a bit mask represented by a @code{const_int}; a zero bit indicates the
corresponding element in the result vector is taken from @var{vec2} while
a set bit indicates it is taken from @var{vec1}.

Is item bit reversed?


-- 
           Summary: Incorrect addsub patterns in sse.md
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl dot tools at gmail dot com]

------- Comment #1 from hjl dot tools at gmail dot com  2009-02-28 18:27 -------
Item selectors in 256bit unpck patterns are also incorrect.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Incorrect addsub patterns in|Incorrect addsub/unpck
                   |sse.md                      |patterns in sse.md


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl dot tools at gmail dot com]

-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl dot tools at gmail dot com]

------- Comment #2 from hjl dot tools at gmail dot com  2009-02-28 18:40 -------
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2009-02/msg01268.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2009-
                   |                            |02/msg01268.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl at gcc dot gnu dot org]

------- Comment #3 from hjl at gcc dot gnu dot org  2009-02-28 22:29 -------
Subject: Bug 39327

Author: hjl
Date: Sat Feb 28 22:29:25 2009
New Revision: 144498

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144498
Log:
2009-02-28  H.J. Lu  <hongjiu.lu@intel.com>

        PR target/39327
        * config/i386/sse.md (avx_addsubv8sf3): Correct item bits.
        (avx_addsubv4df3): Likewise.
        (*avx_addsubv4sf3): Likewise.
        (sse3_addsubv4sf3): Likewise.
        (*avx_addsubv2df3): Likewise.
        (sse3_addsubv2df3): Likewise.
        (avx_unpckhps256): Correct item selectors.
        (avx_unpcklps256): Likewise.
        (avx_unpckhpd256): Likewise.
        (avx_unpcklpd256): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/sse.md


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl at gcc dot gnu dot org]

------- Comment #4 from hjl at gcc dot gnu dot org  2009-03-12 17:43 -------
Subject: Bug 39327

Author: hjl
Date: Thu Mar 12 17:43:14 2009
New Revision: 144819

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144819
Log:
2009-03-12  H.J. Lu  <hongjiu.lu@intel.com>

        PR target/39327
        * config/i386/sse.md (avx_addsubv8sf3): Correct item bits.
        (avx_addsubv4df3): Likewise.
        (*avx_addsubv4sf3): Likewise.
        (sse3_addsubv4sf3): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/sse.md


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl at gcc dot gnu dot org]

------- Comment #5 from hjl at gcc dot gnu dot org  2009-03-12 17:50 -------
Subject: Bug 39327

Author: hjl
Date: Thu Mar 12 17:50:02 2009
New Revision: 144820

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144820
Log:
2009-03-12  H.J. Lu  <hongjiu.lu@intel.com>

        Backport from mainline:
        2009-03-12  H.J. Lu  <hongjiu.lu@intel.com>

        PR target/39327
        * config/i386/sse.md (sse3_addsubv4sf3): Correct item bits.
        (sse3_addsubv2df3): Likewise.

Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/config/i386/sse.md


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327

[Bug target/39327] Incorrect addsub/unpck patterns in sse.md

[hjl dot tools at gmail dot com]

------- Comment #6 from hjl dot tools at gmail dot com  2009-03-12 22:44 -------
Fixed.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39327