public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ktietz at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/39356] assembler isn't called
Date: Mon, 16 Mar 2009 09:16:00 -0000 [thread overview]
Message-ID: <20090316091548.18139.qmail@sourceware.org> (raw)
In-Reply-To: <bug-39356-11564@http.gcc.gnu.org/bugzilla/>
------- Comment #9 from ktietz at gcc dot gnu dot org 2009-03-16 09:15 -------
(In reply to comment #8)
> (In reply to comment #7)
> > The following patch solves this problem and prevents the name collision for 32
> > and 64 bits win32 systems.
> >
> > ChangeLog
> >
> > * config/i386/i386.md (allocate_stack_worker_32): Use
> > ___gnu_chkstk.
> > (allocate_stack_worker_64): Likewise.
> > * config/i386/cygwin.asm (__alloca): Renamed to __gnu_alloca.
> > (___chkstk): Renamed to ___gnu_chkstk.
> >
> No. This breaks backward compatibility. Static libraries and objects built
> with current and older versions of gcc will not be able to resolve references
> to __alloca or ___chkstk. Why not add labels with the new names as aliases
> rather than replace.
>
> Danny
>
Ok, for 32-bits this makes sense to keep the old symbol names. Beside there is
still a chance that a user uses the manually the chkstk.o file, which can lead
to undefined behaviour (at least if the user code references __chkstk).
For 64-bit I prefer to avoid those old names and simply rename it.
Is this ok for you? I'll file then a patch for it?
Kai
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39356
next prev parent reply other threads:[~2009-03-16 9:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 14:03 [Bug driver/39356] New: " r dot emrich at de dot tecosim dot com
2009-03-03 16:57 ` [Bug driver/39356] " rguenth at gcc dot gnu dot org
2009-03-04 9:07 ` r dot emrich at de dot tecosim dot com
2009-03-06 15:12 ` ktietz at gcc dot gnu dot org
2009-03-07 10:46 ` ktietz at gcc dot gnu dot org
2009-03-09 15:07 ` r dot emrich at de dot tecosim dot com
2009-03-15 20:08 ` ktietz at gcc dot gnu dot org
2009-03-15 20:13 ` ktietz at gcc dot gnu dot org
2009-03-16 2:13 ` dannysmith at users dot sourceforge dot net
2009-03-16 9:16 ` ktietz at gcc dot gnu dot org [this message]
2009-03-19 14:33 ` ktietz at gcc dot gnu dot org
2009-03-20 5:29 ` nightstrike at gmail dot com
2009-06-22 1:11 ` xenofears at gmail dot com
2009-06-22 1:42 ` pinskia at gcc dot gnu dot org
2009-06-22 1:43 ` pinskia at gcc dot gnu dot org
2009-07-22 12:24 ` rainer at emrich-ebersheim dot de
2009-07-22 16:07 ` ktietz at gcc dot gnu dot org
2009-08-30 8:35 ` ktietz at gcc dot gnu dot org
2009-08-31 8:11 ` rainer at emrich-ebersheim dot de
2009-09-01 16:16 ` ktietz at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316091548.18139.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).