public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dodji at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/39471] DW_TAG_imported_module should be used (not DW_TAG_imported_declaration)
Date: Tue, 17 Mar 2009 10:02:00 -0000	[thread overview]
Message-ID: <20090317100212.5859.qmail@sourceware.org> (raw)
In-Reply-To: <bug-39471-12292@http.gcc.gnu.org/bugzilla/>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]



------- Comment #8 from dodji at gcc dot gnu dot org  2009-03-17 10:02 -------
Subject: Re:  DW_TAG_imported_module should be used (not
 DW_TAG_imported_declaration)

jakub at gcc dot gnu dot org a écrit :
> ------- Comment #7 from jakub at gcc dot gnu dot org  2009-03-17 08:52 -------
> Created an attachment (id=17472)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17472&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17472&action=view)
> gcc44-local-imported-decl.patch
> 
> Incremental patch to emit DW_TAG_imported_declaration DIEs (other than
> namespace aliases) in the right lexical blocks.
>

I am wondering what happens when cp_emit_debug_info_for_using is called
for a using declaration that appears at global scope. Once we are in the
USING_STMT case of cp_gimplify_expr, will there be an enclosing
GIMPLE_BIND for the USING_STMT generated for the global using declaration ?

For the record, cp_parser_using_declaration calls either
do_local_using_decl or do_toplevel_using_decl, depending on if we are at
local or global scope. Both do_local_using_decl and
do_toplevel_using_decl end up calling cp_parser_using_declaration.


> 
> Concerning:
> "We won't be going through the USING_STMT code path in case of We won't be
> going through the USING_STMT code path in case of namespace aliases, sorry. My
> last comment was irrelevant."
> we really should be going through USING_STMT or something similar for namespace
> aliases as well, see PR37890.  Given that namespace aliases are just emitted
> using gen_namespace_die, perhaps just adding the NAMESPACE_DECL to BLOCK_VARS

Yeah I should try something like that in cp_gimplify_expr whenever we
are handed BIND_EXPR. In that case, I can wall the BIND_EXPR_VARS of the
of the BIND_EXPR and add any NAMESPACE_DECL to the BLOCK_VARS of the
matching block. Would that make sense ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39471


  parent reply	other threads:[~2009-03-17 10:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 14:42 [Bug debug/39471] New: " jan dot kratochvil at redhat dot com
2009-03-16 20:56 ` [Bug debug/39471] " jakub at gcc dot gnu dot org
2009-03-16 21:38 ` jan dot kratochvil at redhat dot com
2009-03-17  7:46 ` jakub at gcc dot gnu dot org
2009-03-17  7:54 ` dodji at redhat dot com
2009-03-17  7:59 ` dodji at redhat dot com
2009-03-17  8:09 ` dodji at redhat dot com
2009-03-17  8:52 ` jakub at gcc dot gnu dot org
2009-03-17 10:02 ` dodji at redhat dot com [this message]
2009-03-17 10:05 ` jan dot kratochvil at redhat dot com
2009-03-17 12:24 ` jan dot kratochvil at redhat dot com
2009-03-17 12:28 ` jakub at gcc dot gnu dot org
2009-03-17 15:18 ` swagiaal at redhat dot com
2009-03-17 17:50 ` jakub at gcc dot gnu dot org
2009-03-17 17:56 ` jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090317100212.5859.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).