public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "danglin at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/39355] [4.4 Regression] Revision 144529: ICE due to missing or incorrectly relocated DECL_VALUE_EXPR in PCH header for PARM_DECL
Date: Mon, 23 Mar 2009 20:39:00 -0000	[thread overview]
Message-ID: <20090323203941.24488.qmail@sourceware.org> (raw)
In-Reply-To: <bug-39355-276@http.gcc.gnu.org/bugzilla/>



------- Comment #47 from danglin at gcc dot gnu dot org  2009-03-23 20:39 -------
I hate PCH!

The reason a small change inhibits PCH file loading is the following:

  /* If the text segment was not loaded at the same address as it was
     when the PCH file was created, function pointers loaded from the
     PCH will not be valid.  We could in theory remap all the function
     pointers, but no support for that exists at present.
     Since we have the same executable, it should only be necessary to
     check one function.  */
  if (v.pch_init != &pch_init)
    {
      if (cpp_get_options (pfile)->warn_invalid_pch)
        cpp_error (pfile, CPP_DL_WARNING,
                   "%s: had text segment at different address", name);
      return 2;
    }

Since I wasn't rebuilding the libstdc++ PCH files when I hacked expr.c and
rebuilt cc1plus, I was effectively disabling PCH.

As a side note, the comparison of v.pch_init and &pch_init is dangerous
on targets that use function descriptors.  The value v.pch_init was
recorded by a different binary, so it could point to garbage in the binary
performing the check.

So, we are left with the original PCH bug.  Is the missing DECL_VALUE_EXPR
expected for PCH data?   


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39355


  parent reply	other threads:[~2009-03-23 20:39 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03  2:05 [Bug debug/39355] New: [4.4 Regression] ICE at dwarf2out.c:10353 in loc_descriptor_from_tree_1 danglin at gcc dot gnu dot org
2009-03-03  2:09 ` [Bug debug/39355] " dave at hiauly1 dot hia dot nrc dot ca
2009-03-03 13:04 ` rguenth at gcc dot gnu dot org
2009-03-04 12:13 ` rguenth at gcc dot gnu dot org
2009-03-04 17:26 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-04 19:14 ` jakub at gcc dot gnu dot org
2009-03-04 20:46 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-05  8:07 ` jakub at gcc dot gnu dot org
2009-03-05 11:18 ` hubicka at ucw dot cz
2009-03-07 16:52 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-08 17:40 ` hjl dot tools at gmail dot com
2009-03-10  1:47 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-10  3:53 ` hjl dot tools at gmail dot com
2009-03-10  6:32 ` steven at gcc dot gnu dot org
2009-03-10  8:05 ` jakub at gcc dot gnu dot org
2009-03-14 15:02 ` hjl dot tools at gmail dot com
2009-03-14 15:52 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-14 16:15 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-14 21:31 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-15  2:22 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-15 17:37 ` [Bug debug/39355] [4.4 Regression] Revision 144529 miscompiled libcpp/expr.c hjl dot tools at gmail dot com
2009-03-15 18:08 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-15 18:48 ` hjl dot tools at gmail dot com
2009-03-15 19:51 ` rguenth at gcc dot gnu dot org
2009-03-16  7:52 ` jakub at gcc dot gnu dot org
2009-03-16 17:20 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-16 17:26 ` hjl dot tools at gmail dot com
2009-03-17 10:42 ` jakub at gcc dot gnu dot org
2009-03-20  1:30 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-20 13:18 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-20 17:22 ` [Bug tree-optimization/39355] " jason at gcc dot gnu dot org
2009-03-20 17:29 ` rguenth at gcc dot gnu dot org
2009-03-20 18:04 ` hjl dot tools at gmail dot com
2009-03-20 19:07 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-20 19:10 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-21  0:54 ` danglin at gcc dot gnu dot org
2009-03-21 16:13 ` hjl dot tools at gmail dot com
2009-03-21 17:25 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-21 18:05 ` hjl dot tools at gmail dot com
2009-03-21 18:08 ` hjl dot tools at gmail dot com
2009-03-21 18:32 ` dave at hiauly1 dot hia dot nrc dot ca
2009-03-21 18:53 ` danglin at gcc dot gnu dot org
2009-03-21 21:59 ` danglin at gcc dot gnu dot org
2009-03-22 18:34 ` [Bug tree-optimization/39355] [4.4 Regression] Revision 144529: ICE due to missing or incorrectly relocated DECL_VALUE_EXPR in PCH header for PARM_DECL danglin at gcc dot gnu dot org
2009-03-22 19:38 ` danglin at gcc dot gnu dot org
2009-03-23 20:39 ` danglin at gcc dot gnu dot org [this message]
2009-03-24 16:32 ` danglin at gcc dot gnu dot org
2009-03-25  7:30 ` jakub at gcc dot gnu dot org
2009-03-29 18:49 ` [Bug tree-optimization/39355] [4.4/4.5 " danglin at gcc dot gnu dot org
2009-04-21 16:01 ` jakub at gcc dot gnu dot org
2009-07-22 10:32 ` jakub at gcc dot gnu dot org
2009-07-27 15:11 ` danglin at gcc dot gnu dot org
2009-07-30  3:55 ` danglin at gcc dot gnu dot org
2009-10-15 12:58 ` jakub at gcc dot gnu dot org
2010-01-21 13:19 ` jakub at gcc dot gnu dot org
2010-04-30  8:56 ` [Bug tree-optimization/39355] [4.4/4.5/4.6 " jakub at gcc dot gnu dot org
     [not found] <bug-39355-4@http.gcc.gnu.org/bugzilla/>
2010-12-06 10:46 ` [Bug tree-optimization/39355] [4.4 " jakub at gcc dot gnu.org
2011-04-16 11:13 ` jakub at gcc dot gnu.org
2012-03-13 16:52 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090323203941.24488.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).