public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/38573]  New: Missing markers for translation
@ 2008-12-18 22:18 goeran at uddeborg dot se
  2008-12-18 23:47 ` [Bug fortran/38573] " schwab at suse dot de
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: goeran at uddeborg dot se @ 2008-12-18 22:18 UTC (permalink / raw)
  To: gcc-bugs

In the function gfc_check_intrinsic_standard in gcc/fortran/intrinsic.c there
is a message written:

        gfc_warning ("Intrinsic '%s' (is %s) is used at %L",
                     isym->name, _(symstd_msg), &where);

The string pointed to by sysstd_msg is sent for translation.  But the values
this string can get are not marked for translation.  It looks like this:

      symstd_msg = "available since Fortran 77";

Nothing tells xgettext to extract this to the po files so it can be translated.
 This needs to be changed to

      symstd_msg = N_("available since Fortran 77");

Similarily for the other possible values of symstd_msg.


-- 
           Summary: Missing markers for translation
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: goeran at uddeborg dot se


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38573


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/38573] Missing markers for translation
  2008-12-18 22:18 [Bug fortran/38573] New: Missing markers for translation goeran at uddeborg dot se
@ 2008-12-18 23:47 ` schwab at suse dot de
  2008-12-20 11:27 ` goeran at uddeborg dot se
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: schwab at suse dot de @ 2008-12-18 23:47 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from schwab at suse dot de  2008-12-18 23:45 -------
It needs to be rephrased anyway to be i18n friendly.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38573


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/38573] Missing markers for translation
  2008-12-18 22:18 [Bug fortran/38573] New: Missing markers for translation goeran at uddeborg dot se
  2008-12-18 23:47 ` [Bug fortran/38573] " schwab at suse dot de
@ 2008-12-20 11:27 ` goeran at uddeborg dot se
  2009-01-03 23:59 ` dfranke at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: goeran at uddeborg dot se @ 2008-12-20 11:27 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from goeran at uddeborg dot se  2008-12-20 11:26 -------
That's true.  Simply including the "is" in the symstd_msg, so the entire
message within the parenthesis would be translated as a unit, would be a
significant improvement.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38573


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/38573] Missing markers for translation
  2008-12-18 22:18 [Bug fortran/38573] New: Missing markers for translation goeran at uddeborg dot se
  2008-12-18 23:47 ` [Bug fortran/38573] " schwab at suse dot de
  2008-12-20 11:27 ` goeran at uddeborg dot se
@ 2009-01-03 23:59 ` dfranke at gcc dot gnu dot org
  2009-03-28 15:26 ` fxcoudert at gcc dot gnu dot org
  2009-03-28 15:31 ` fxcoudert at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2009-01-03 23:59 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from dfranke at gcc dot gnu dot org  2009-01-03 23:58 -------
Also translation related: PR36161.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38573


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/38573] Missing markers for translation
  2008-12-18 22:18 [Bug fortran/38573] New: Missing markers for translation goeran at uddeborg dot se
                   ` (2 preceding siblings ...)
  2009-01-03 23:59 ` dfranke at gcc dot gnu dot org
@ 2009-03-28 15:26 ` fxcoudert at gcc dot gnu dot org
  2009-03-28 15:31 ` fxcoudert at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2009-03-28 15:26 UTC (permalink / raw)
  To: gcc-bugs



-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-03-28 15:26:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38573


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/38573] Missing markers for translation
  2008-12-18 22:18 [Bug fortran/38573] New: Missing markers for translation goeran at uddeborg dot se
                   ` (3 preceding siblings ...)
  2009-03-28 15:26 ` fxcoudert at gcc dot gnu dot org
@ 2009-03-28 15:31 ` fxcoudert at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2009-03-28 15:31 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from fxcoudert at gcc dot gnu dot org  2009-03-28 15:31 -------
Created an attachment (id=17555)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17555&action=view)
Proposed patch to fix the main issue

Here's the patch I propose to fix this issue and a few similar ones that grep
revealed. It makes sure the strings can be gathered by xgettext. 

It does not make the logic in intrinsic.c more localization-friendly, because I
think it's far from trivial to do: consider that the string is also returned
from the function where it's emitted, to be used in another error message in
the callee.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38573


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-03-28 15:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-18 22:18 [Bug fortran/38573] New: Missing markers for translation goeran at uddeborg dot se
2008-12-18 23:47 ` [Bug fortran/38573] " schwab at suse dot de
2008-12-20 11:27 ` goeran at uddeborg dot se
2009-01-03 23:59 ` dfranke at gcc dot gnu dot org
2009-03-28 15:26 ` fxcoudert at gcc dot gnu dot org
2009-03-28 15:31 ` fxcoudert at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).