[Bug fortran/35095] New: DATA with implied-do: Improve bounds checking

[Bug fortran/35095] New: DATA with implied-do: Improve bounds checking

[burnus at gcc dot gnu dot org]

This is a follow-up from PR 32315.

The following accesses valid data, but the array bounds are wrong:

program chkdata
    character(len=20), dimension(4,4) :: string
    data ( string(i,1),i=1,5) / 'A', 'B', 'C', 'D', 'E' /
end program chkdata

Since PR 32315 all invalid memory accesses are detected, but here the problem
is that  string(5,1) is invalid (upper bound is 4) while the memory accessed it
part of string (i.e. "string(1,2)").

Expected:
- gfortran rejects this with -std=f95 or at least warns
- The error message should include the bound [e.g. "(5 > 4)"]
  and the dimension ("in dimension 1").

NAG has:
Error: a.f90, line 3: First subscript (5) is greater than upper bound (4) for
array STRING

gfortran has:
Error: Data element above array upper bound at (1)


-- 
           Summary: DATA with implied-do: Improve bounds checking
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35095

[Bug fortran/35095] DATA with implied-do: Improve bounds checking

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-03-29 08:23:20
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35095

[Bug fortran/35095] DATA with implied-do: Improve bounds checking

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35095

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from anlauf at gcc dot gnu.org ---
Fixed after 15 years...

[Bug fortran/35095] DATA with implied-do: Improve bounds checking

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35095

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:4024ddbe50c2d1cb54c75304c72817d3fc63cdb6

commit r14-3484-g4024ddbe50c2d1cb54c75304c72817d3fc63cdb6
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Aug 24 23:16:25 2023 +0200

    Fortran: improve bounds checking for DATA with implied-do [PR35095]

    gcc/fortran/ChangeLog:

            PR fortran/35095
            * data.cc (get_array_index): Add bounds-checking code and return
error
            status.  Overindexing will be allowed as an extension for
-std=legacy
            and generate an error in standard-conforming mode.
            (gfc_assign_data_value): Use error status from get_array_index for
            graceful error recovery.

    gcc/testsuite/ChangeLog:

            PR fortran/35095
            * gfortran.dg/data_bounds_1.f90: Adjust options to disable
warnings.
            * gfortran.dg/data_bounds_2.f90: New test.

[Bug fortran/35095] DATA with implied-do: Improve bounds checking

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35095

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |anlauf at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Patch submitted: https://gcc.gnu.org/pipermail/fortran/2023-August/059711.html