[Bug c/28755] New: duplicate members of arrays

[Bug c/28755] New: duplicate members of arrays

[dwmw2 at infradead dot org]

See attached test case. Observe the number of times certain lines of the
'vesa_modes' array are emitted. This isn't particularly optimal, especially as
it happens even with -Os.

 $ make
cc -Os -c -o fbmon.o fbmon.i -save-temps
grep 39682 fbmon.s
        .long   39682
        .long   39682


-- 
           Summary: duplicate members of arrays
           Product: gcc
           Version: 4.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dwmw2 at infradead dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug c/28755] duplicate members of arrays

[dwmw2 at infradead dot org]

------- Comment #1 from dwmw2 at infradead dot org  2006-08-16 17:29 -------
Created an attachment (id=12084)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12084&action=view)
test case


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] duplicate members of arrays

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-08-16 17:36 -------
This is an expand/middle-end issue as get:
  *mode = vesa_modes[0];
in the final_cleanup.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |middle-end
           Keywords|                            |missed-optimization


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] duplicate members of arrays

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-08-16 17:37 -------
Confirmed, here is the testcase for lazy people (like me) who really don't want
to download the tar file:
struct fb_videomode {
 const char *name;
 unsigned refresh;
 unsigned xres;
 unsigned yres;
 unsigned pixclock;
 unsigned left_margin;
 unsigned right_margin;
 unsigned upper_margin;
 unsigned lower_margin;
 unsigned hsync_len;
 unsigned vsync_len;
 unsigned sync;
 unsigned vmode;
 unsigned flag;
};

const struct fb_videomode vesa_modes[] = {

 { ((void *)0), 60, 640, 480, 39682, 48, 16, 33, 10, 96, 2,
   0, 0, 4 },
};

void get_est_timing(unsigned char *block, struct fb_videomode *mode)
{
        mode[0] = vesa_modes[0];
}
-------
Oh this is not a regression as far as I can tell.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |3.3.5 4.2.0
   Last reconfirmed|0000-00-00 00:00:00         |2006-08-16 17:37:29
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2 Regression] duplicate members of arrays

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-08-16 17:39 -------
Actually it is a regression from 2.95.3, I just had to go back in time enough
to get find that.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|3.3.5 4.2.0                 |3.3.5 4.2.0 3.2.3 3.3.3
                   |                            |3.0.4
      Known to work|                            |2.95.3
            Summary|duplicate members of arrays |[4.0/4.1/4.2 Regression]
                   |                            |duplicate members of arrays
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2 Regression] duplicate members of arrays

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |08/msg00601.html
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-08-16 17:37:29         |2006-08-17 11:17:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2 Regression] duplicate members of arrays

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2 Regression] duplicate members of arrays

[patchapp at dberlin dot org]

------- Comment #5 from patchapp at dberlin dot org  2006-08-21 04:29 -------
Subject: Bug number PR middle-end/28755

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-08/msg00601.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2/4.3 Regression] duplicate members of arrays

[gdr at gcc dot gnu dot org]

------- Comment #6 from gdr at gcc dot gnu dot org  2007-02-03 18:56 -------
Won't fix in GCC-4.0.x.  Adjusting milestone.


-- 

gdr at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.4                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2/4.3 Regression] duplicate members of arrays

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.3                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2/4.3 Regression] duplicate members of arrays

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2/4.3 Regression] duplicate members of arrays

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2007-09-23 09:34 -------
Subject: Bug 28755

Author: jakub
Date: Sun Sep 23 09:34:28 2007
New Revision: 128685

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128685
Log:
        PR middle-end/28755
        * expr.c (expand_constructor): New function.
        (expand_expr_real_1) <case CONSTRUCTOR>: Call it.
        (expand_expr_real_1) <case ARRAY_REF>: Call it if VALUE is
        CONSTRUCTOR.

        * gcc.dg/pr28755.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr28755.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/expr.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2 Regression] duplicate members of arrays

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2007-09-24 06:36 -------
Fixed on the trunk.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|2.95.3                      |2.95.3 4.3.0
            Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2 Regression]
                   |duplicate members of arrays |duplicate members of arrays


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.0/4.1/4.2 Regression] duplicate members of arrays

[alexandre dot nunes at gmail dot com]

------- Comment #9 from alexandre dot nunes at gmail dot com  2008-01-15 18:12 -------
(In reply to comment #8)
> Fixed on the trunk.
> 

For anyone else wondering, this is still reproductible on vanilla gcc 4.2.2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.2 Regression] duplicate members of arrays

[jsm28 at gcc dot gnu dot org]

------- Comment #10 from jsm28 at gcc dot gnu dot org  2008-07-04 21:27 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 Regression]        |[4.2 Regression] duplicate
                   |duplicate members of arrays |members of arrays
   Target Milestone|4.1.3                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755

[Bug middle-end/28755] [4.2 Regression] duplicate members of arrays

[jsm28 at gcc dot gnu dot org]

------- Comment #11 from jsm28 at gcc dot gnu dot org  2009-03-30 17:03 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|3.3.5 4.2.0 3.2.3 3.3.3     |3.3.5 4.2.0 3.2.3 3.3.3
                   |3.0.4 4.0.4                 |3.0.4 4.0.4 4.2.5
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28755