[Bug libstdc++/39546] New: parallel mode doesn't support implicit string conversion

[Bug libstdc++/39546] New: parallel mode doesn't support implicit string conversion

[suokkos at gmail dot com]

In parallel mode automatic conversion from string literal to std::string
doesn't work when passing literal as parameter to std::find.

Woring compiler parameters:
g++ test.cpp -o test

Failing compiler line:
g++ -D_GLIBCXX_PARALLEL -fopenmp -lgomp test.cpp -o test


Simple work around is making explicit temporary std::string object.


-- 
           Summary: parallel mode doesn't support implicit string conversion
           Product: gcc
           Version: 4.3.3
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: suokkos at gmail dot com
 GCC build triplet: x86_64-linux-gnu
  GCC host triplet: x86_64-linux-gnu
GCC target triplet: x86_64-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[suokkos at gmail dot com]

------- Comment #1 from suokkos at gmail dot com  2009-03-24 16:43 -------
Created an attachment (id=17533)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17533&action=view)
g++ -v output when trying to compiling in parallel mode


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[suokkos at gmail dot com]

------- Comment #2 from suokkos at gmail dot com  2009-03-24 16:46 -------
Created an attachment (id=17534)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17534&action=view)
--save-temps test.ii from failed compilation in parallel mode


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[suokkos at gmail dot com]

------- Comment #3 from suokkos at gmail dot com  2009-03-24 16:48 -------
Created an attachment (id=17535)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17535&action=view)
Source for the simple test case


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #4 from paolo dot carlini at oracle dot com  2009-03-24 17:25 -------
Johannes, can you have a look? To be honest, I'm not sure that using those
binders (with all the known limitations which led to deprecation for C++0x) in
dispatching functions really can be made to work also in the corner cases...
Maybe we can deal somehow easily with this specific case?


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |singler at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-03-24 17:26:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #5 from singler at gcc dot gnu dot org  2009-03-31 09:52 -------
I have two patches, each of which should fix the problem.  Both take the value
to compare against as const ref, which solves the array passing problem.  The
first one is more general, introducing a new variant of binder2nd, while the
second is more specific, having a new variant of equal_to.
Which approach would you like better?
(Formatting and comments of patches is not yet final).


-- 

singler at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |singler at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-03-24 17:26:00         |2009-03-31 09:52:55
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #6 from singler at gcc dot gnu dot org  2009-03-31 09:53 -------
Created an attachment (id=17568)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17568&action=view)
Patch adding new variant of binder2nd.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #7 from singler at gcc dot gnu dot org  2009-03-31 09:53 -------
Created an attachment (id=17569)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17569&action=view)
Patch adding new variant of equal_to.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #8 from paolo dot carlini at oracle dot com  2009-03-31 11:34 -------
I'm not sure to have all the elements to make a meaningful choice. Could you
please explain in some detail what's going on? Also, could you please remind me
why we have those duplicated binders in parallel/base.h? Thanks.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #9 from singler at gcc dot gnu dot org  2009-03-31 16:41 -------
We have duplicated binders because they have a changed parametrization, as
needed for parallel mode usage:


/**
  *  @brief Similar to std::binder2nd, but giving the argument types
  *  explicitly.
  */
template<typename _Operation, typename first_argument_type,
         typename second_argument_type, typename result_type>
  class binder2nd


/** @brief Similar to std::binder1st,
  *  but giving the argument types explicitly. */
template<typename _Predicate, typename argument_type>
  class unary_negate


/** @brief Similar to std::equal_to, but allows two different types. */
template<typename T1, typename T2>
  struct equal_to : std::binary_function<T1, T2, bool>


and so on.  We could give them more different names to avoid conflicts, but at
least they are encapsulated in __gnu_parallel (uglifying the names would also
help).  Basically, both patches change things by taking the argument by const
reference, instead of by value.  The first one has the indirection of
binder2nd, while the second directly uses an adapted version of equal_to.


-- 

singler at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo dot carlini at oracle
                   |                            |dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #10 from paolo dot carlini at oracle dot com  2009-04-01 09:49 -------
To be honest, I don't like such tentative fixes. We are adding even more code
for essentially the same kind of work. There must be a better way to deal with
the issue.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #11 from singler at gcc dot gnu dot org  2009-04-07 09:09 -------
I found a shorter solution:  Just parametrize equal_to with const T& instead of
T.  Better?

In general, passing the element to find as const ref is the safest we can do,
isn't it?  AFAIK the other option is to not pass it at all.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #12 from singler at gcc dot gnu dot org  2009-04-07 09:10 -------
Created an attachment (id=17598)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17598&action=view)
Patch differently parametrizing equal_to. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #13 from paolo dot carlini at oracle dot com  2009-04-15 13:09 -------
Hi, and sorry about my delay. I think we should definitely resolve this in time
for 4.4.0.

I agree, the new proposed fix looks much better. Still, I must admit, there is
something I do not understand completely about this dispatching machinery, I'm
under the impression there is something ad-hoc about it and I'm not confident
we don't have other problems lurking somewhere... Want to look closer into it.
Benjamin, do you have an opinion?


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkoz at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #14 from paolo dot carlini at oracle dot com  2009-04-15 13:56 -------
Probably it's too late anyway for 4.4.0...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[bkoz at gcc dot gnu dot org]

------- Comment #15 from bkoz at gcc dot gnu dot org  2009-04-16 21:59 -------

Patch in #12 seems fine to me for 4.4.1.


I remain interested in trying to use C++0x for some of the parallel mode bits,
including but not limited to cstdint, type_traits, functional, atomic, etc.

I hope to get back to the exception-testing bits summer 2009

-benjamin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #16 from singler at gcc dot gnu dot org  2009-04-20 14:44 -------
I'm currently regression testing find_cstring_constify_equal_to.patch.
Shall I do a new test case for this PR with a non-copyable object
(generalization)?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[bkoz at gcc dot gnu dot org]

------- Comment #17 from bkoz at gcc dot gnu dot org  2009-04-29 19:42 -------

Eh, i'm ok with keeping the same bug report for the generalized case. Suggest
trying to get something in on mainline, test it out for a couple of days, and
then move to gcc-4_4-branch for 4.4.1.

best,
benjamin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #18 from paolo dot carlini at oracle dot com  2009-04-29 20:08 -------
Agreed, Benjamin.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #19 from singler at gcc dot gnu dot org  2009-05-06 11:21 -------
Subject: Bug 39546

Author: singler
Date: Wed May  6 11:20:35 2009
New Revision: 147169

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147169
Log:
2009-05-06  Johannes Singler  <singler@ira.uka.de>

        PR libstdc++/39546
        * include/parallel/algo.h (find_switch):
        Parametrize binder2nd with const T& instead of T.
        * testsuite/25_algorithms/find/39546.cc: new test case


Added:
    trunk/libstdc++-v3/testsuite/25_algorithms/find/39546.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/parallel/algo.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #20 from singler at gcc dot gnu dot org  2009-05-07 09:19 -------
Fixed in mainline.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #21 from paolo dot carlini at oracle dot com  2009-05-07 09:39 -------
As agreed with Benjamin, please apply it to the branch too and close the PR in
two days or so. Thanks!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[singler at gcc dot gnu dot org]

------- Comment #22 from singler at gcc dot gnu dot org  2009-05-12 14:57 -------
Subject: Bug 39546

Author: singler
Date: Tue May 12 14:57:35 2009
New Revision: 147439

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147439
Log:
2009-05-12  Johannes Singler  <singler@ira.uka.de>

        PR libstdc++/39546
        * include/parallel/algo.h (find_switch):
        Parametrize binder2nd with const T& instead of T.
        * testsuite/25_algorithms/find/39546.cc: new test case


Added:
    branches/gcc-4_4-branch/libstdc++-v3/testsuite/25_algorithms/find/39546.cc
Modified:
    branches/gcc-4_4-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_4-branch/libstdc++-v3/include/parallel/algo.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546

[Bug libstdc++/39546] parallel mode doesn't support implicit string conversion

[paolo dot carlini at oracle dot com]

------- Comment #23 from paolo dot carlini at oracle dot com  2009-05-12 15:27 -------
Fixed for 4.4.1.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39546