public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled
@ 2009-04-06 15:41 hjl dot tools at gmail dot com
2009-04-06 15:43 ` [Bug libfortran/39664] " hjl dot tools at gmail dot com
` (15 more replies)
0 siblings, 16 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 15:41 UTC (permalink / raw)
To: gcc-bugs
On Linux/ia32 and Linux/x86-64, revision 145573 gave:
Running 436.cactusADM ref base o2 default
Error with
'/export/gnu/import/svn/gcc-test/spec/2006/x86_64/spec/bin/specinvoke
-E -d
/export/gnu/import/svn/gcc-test/spec/2006/x86_64/spec/benchspec/CPU2006/4
36.cactusADM/run/run_base_ref_o2.0000 -c 1 -e compare.err -o compare.stdout -f
c
ompare.cmd': check file
'/export/gnu/import/svn/gcc-test/spec/2006/x86_64/spec/b
enchspec/CPU2006/436.cactusADM/run/run_base_ref_o2.0000/.err'
*** Miscompare of benchADM.out, see
/export/gnu/import/svn/gcc-test/spec/2006/x8
6_64/spec/benchspec/CPU2006/436.cactusADM/run/run_base_ref_o2.0000/benchADM.out.
mis
--
Summary: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is
miscompiled
Product: gcc
Version: 4.5.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: hjl dot tools at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
@ 2009-04-06 15:43 ` hjl dot tools at gmail dot com
2009-04-06 19:49 ` burnus at gcc dot gnu dot org
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 15:43 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from hjl dot tools at gmail dot com 2009-04-06 15:42 -------
It may be caused by revision 145571:
http://gcc.gnu.org/ml/gcc-cvs/2009-04/msg00193.html
--
hjl dot tools at gmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |d at domob dot eu, jvdelisle
| |at gcc dot gnu dot org
Component|fortran |libfortran
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
2009-04-06 15:43 ` [Bug libfortran/39664] " hjl dot tools at gmail dot com
@ 2009-04-06 19:49 ` burnus at gcc dot gnu dot org
2009-04-06 19:53 ` [Bug libfortran/39664] [4.5 Regression] Revision 145571 caused 436.cactusADM in SPEC CPU 2006 to fail hjl dot tools at gmail dot com
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: burnus at gcc dot gnu dot org @ 2009-04-06 19:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from burnus at gcc dot gnu dot org 2009-04-06 19:49 -------
Could you try to reduce the problem - as SPEC is not publicly available it is a
bit hard to debug (by far most gfortraners do not have access to SPEC).
(In reply to comment #1)
> It may be caused by revision 145571:
> http://gcc.gnu.org/ml/gcc-cvs/2009-04/msg00193.html
Could you confirm that it was indeed caused by that patch?
(You wrote "may" ... ;-)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 caused 436.cactusADM in SPEC CPU 2006 to fail
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
2009-04-06 15:43 ` [Bug libfortran/39664] " hjl dot tools at gmail dot com
2009-04-06 19:49 ` burnus at gcc dot gnu dot org
@ 2009-04-06 19:53 ` hjl dot tools at gmail dot com
2009-04-06 21:34 ` hjl dot tools at gmail dot com
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 19:53 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from hjl dot tools at gmail dot com 2009-04-06 19:52 -------
(In reply to comment #2)
> Could you try to reduce the problem - as SPEC is not publicly available it is a
> bit hard to debug (by far most gfortraners do not have access to SPEC).
I am working on it.
> (In reply to comment #1)
> > It may be caused by revision 145571:
> > http://gcc.gnu.org/ml/gcc-cvs/2009-04/msg00193.html
>
> Could you confirm that it was indeed caused by that patch?
> (You wrote "may" ... ;-)
Yes, revision 145571 is the cause.
--
hjl dot tools at gmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.5 Regression] |[4.5 Regression] Revision
|436.cactusADM in SPEC CPU |145571 caused 436.cactusADM
|2006 is miscompiled |in SPEC CPU 2006 to fail
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 caused 436.cactusADM in SPEC CPU 2006 to fail
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (2 preceding siblings ...)
2009-04-06 19:53 ` [Bug libfortran/39664] [4.5 Regression] Revision 145571 caused 436.cactusADM in SPEC CPU 2006 to fail hjl dot tools at gmail dot com
@ 2009-04-06 21:34 ` hjl dot tools at gmail dot com
2009-04-06 22:15 ` hjl dot tools at gmail dot com
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 21:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from hjl dot tools at gmail dot com 2009-04-06 21:34 -------
It is very hard to extract a small testcase. However, you can
download Cactus from
http://www.cactuscode.org/
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 caused 436.cactusADM in SPEC CPU 2006 to fail
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (3 preceding siblings ...)
2009-04-06 21:34 ` hjl dot tools at gmail dot com
@ 2009-04-06 22:15 ` hjl dot tools at gmail dot com
2009-04-06 22:20 ` [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio hjl dot tools at gmail dot com
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 22:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from hjl dot tools at gmail dot com 2009-04-06 22:15 -------
cactusADM has both C and Fortran. The following code
printf("--------------------------------------------------------------------------------\n");
printf("Done.\n");
in C won't show up when the output is redirected to a file.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (4 preceding siblings ...)
2009-04-06 22:15 ` hjl dot tools at gmail dot com
@ 2009-04-06 22:20 ` hjl dot tools at gmail dot com
2009-04-06 22:22 ` pinskia at gcc dot gnu dot org
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 22:20 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from hjl dot tools at gmail dot com 2009-04-06 22:20 -------
Revision 145571 breaks stdio when the output was redirected to a file:
[h[hjl@gnu-16 pr39664]$ cat foo.c
#include <stdio.h>
int
main ()
{
printf("--------------------------------------------------------------------------------\n");
printf("Done.\n");
return 0;
}
jl@gnu-16 pr39664]$ /export/gnu/import/rrs/145571/usr/bin/gcc -O2 -c -o foo.o
foo.c
[hjl@gnu-16 pr39664]$ /export/gnu/import/rrs/145571/usr/bin/gfortran -o foo
foo.o
[hjl@gnu-16 pr39664]$ LD_LIBRARY_PATH=/export/gnu/import/rrs/145571/usr/lib64
./foo > 1
[hjl@gnu-16 pr39664]$ cat 1
[hjl@gnu-16 pr39664]$ LD_LIBRARY_PATH=/export/gnu/import/rrs/145571/usr/lib64
./foo
--------------------------------------------------------------------------------
Done.
[hjl@gnu-16 pr39664]$
--
hjl dot tools at gmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.5 Regression] Revision |[4.5 Regression] Revision
|145571 caused 436.cactusADM |145571 breaks stdio
|in SPEC CPU 2006 to fail |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (5 preceding siblings ...)
2009-04-06 22:20 ` [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio hjl dot tools at gmail dot com
@ 2009-04-06 22:22 ` pinskia at gcc dot gnu dot org
2009-04-06 22:41 ` hjl dot tools at gmail dot com
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2009-04-06 22:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pinskia at gcc dot gnu dot org 2009-04-06 22:22 -------
I don't know if this is really a bug. The interaction between Fortran I/O and
C FILE I/O is not defined anywhere.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (6 preceding siblings ...)
2009-04-06 22:22 ` pinskia at gcc dot gnu dot org
@ 2009-04-06 22:41 ` hjl dot tools at gmail dot com
2009-04-06 22:44 ` hjl dot tools at gmail dot com
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 22:41 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from hjl dot tools at gmail dot com 2009-04-06 22:41 -------
(In reply to comment #7)
> I don't know if this is really a bug. The interaction between Fortran I/O and
> C FILE I/O is not defined anywhere.
Does it mean that gcc doesn't support mixing C codes which contain stdio with
Fortran I/O?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (7 preceding siblings ...)
2009-04-06 22:41 ` hjl dot tools at gmail dot com
@ 2009-04-06 22:44 ` hjl dot tools at gmail dot com
2009-04-06 22:46 ` kargl at gcc dot gnu dot org
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 22:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from hjl dot tools at gmail dot com 2009-04-06 22:43 -------
This patch seems to work for the small testcase:
Index: io/unix.c
===================================================================
--- io/unix.c (revision 145571)
+++ io/unix.c (working copy)
@@ -344,7 +344,12 @@ raw_close (unix_stream * s)
{
int retval;
- retval = close (s->fd);
+ if (s->fd != STDOUT_FILENO
+ && s->fd != STDERR_FILENO
+ && s->fd != STDIN_FILENO)
+ retval = close (s->fd);
+ else
+ retval = SUCCESS;
free_mem (s);
return retval;
}
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (8 preceding siblings ...)
2009-04-06 22:44 ` hjl dot tools at gmail dot com
@ 2009-04-06 22:46 ` kargl at gcc dot gnu dot org
2009-04-06 22:48 ` pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu dot org @ 2009-04-06 22:46 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from kargl at gcc dot gnu dot org 2009-04-06 22:46 -------
(In reply to comment #6)
> Revision 145571 breaks stdio when the output was redirected to a file:
>
> [h[hjl@gnu-16 pr39664]$ cat foo.c
> #include <stdio.h>
>
> int
> main ()
> {
>
> printf("--------------------------------------------------------------------------------\n");
> printf("Done.\n");
>
> return 0;
> }
> jl@gnu-16 pr39664]$ /export/gnu/import/rrs/145571/usr/bin/gcc -O2 -c -o foo.o
> foo.c
> [hjl@gnu-16 pr39664]$ /export/gnu/import/rrs/145571/usr/bin/gfortran -o foo
> foo.o
> [hjl@gnu-16 pr39664]$ LD_LIBRARY_PATH=/export/gnu/import/rrs/145571/usr/lib64
> ./foo > 1
> [hjl@gnu-16 pr39664]$ cat 1
> [hjl@gnu-16 pr39664]$ LD_LIBRARY_PATH=/export/gnu/import/rrs/145571/usr/lib64
> ./foo
> --------------------------------------------------------------------------------
> Done.
> [hjl@gnu-16 pr39664]$
>
Works for me.
troutmask:sgk[204] ~/work/4x/bin/gcc -c g.c
troutmask:sgk[205] gfc4x -o z g.o
troutmask:sgk[206] ./z > zxc
troutmask:sgk[207] cat zxc
--------------------------------------------------------------------------------
Done.
troutmask:sgk[208] gfc4x --version
GNU Fortran (GCC) 4.5.0 20090406 (experimental)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (9 preceding siblings ...)
2009-04-06 22:46 ` kargl at gcc dot gnu dot org
@ 2009-04-06 22:48 ` pinskia at gcc dot gnu dot org
2009-04-06 22:53 ` hjl dot tools at gmail dot com
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2009-04-06 22:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from pinskia at gcc dot gnu dot org 2009-04-06 22:47 -------
(In reply to comment #9)
> This patch seems to work for the small testcase:
This patch looks correct based on the old code:
- if (s->fd != STDOUT_FILENO && s->fd != STDERR_FILENO && s->fd !=
STDIN_FILENO)
- {
- if (close (s->fd) < 0)
- return FAILURE;
- }
-
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (10 preceding siblings ...)
2009-04-06 22:48 ` pinskia at gcc dot gnu dot org
@ 2009-04-06 22:53 ` hjl dot tools at gmail dot com
2009-04-06 22:57 ` hjl dot tools at gmail dot com
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 22:53 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from hjl dot tools at gmail dot com 2009-04-06 22:53 -------
A patch is posted at
http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00464.html
--
hjl dot tools at gmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/gcc-
| |patches/2009-
| |04/msg00464.html
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (11 preceding siblings ...)
2009-04-06 22:53 ` hjl dot tools at gmail dot com
@ 2009-04-06 22:57 ` hjl dot tools at gmail dot com
2009-04-06 23:08 ` hjl at gcc dot gnu dot org
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 22:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from hjl dot tools at gmail dot com 2009-04-06 22:57 -------
(In reply to comment #10)
>
> Works for me.
> troutmask:sgk[204] ~/work/4x/bin/gcc -c g.c
> troutmask:sgk[205] gfc4x -o z g.o
> troutmask:sgk[206] ./z > zxc
> troutmask:sgk[207] cat zxc
> --------------------------------------------------------------------------------
> Done.
Did you try it on Linux? libgfortran closes FDs which are the parts of
C library.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (12 preceding siblings ...)
2009-04-06 22:57 ` hjl dot tools at gmail dot com
@ 2009-04-06 23:08 ` hjl at gcc dot gnu dot org
2009-04-06 23:16 ` hjl dot tools at gmail dot com
2009-05-27 1:23 ` jvdelisle at gcc dot gnu dot org
15 siblings, 0 replies; 17+ messages in thread
From: hjl at gcc dot gnu dot org @ 2009-04-06 23:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from hjl at gcc dot gnu dot org 2009-04-06 23:08 -------
Subject: Bug 39664
Author: hjl
Date: Mon Apr 6 23:07:51 2009
New Revision: 145636
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=145636
Log:
2009-04-06 H.J. Lu <hongjiu.lu@intel.com>
PR libgfortran/39664
* io/unix.c (raw_close): Don't close STDOUT_FILENO,
STDERR_FILENO nor STDIN_FILENO.
Modified:
trunk/libgfortran/ChangeLog
trunk/libgfortran/io/unix.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (13 preceding siblings ...)
2009-04-06 23:08 ` hjl at gcc dot gnu dot org
@ 2009-04-06 23:16 ` hjl dot tools at gmail dot com
2009-05-27 1:23 ` jvdelisle at gcc dot gnu dot org
15 siblings, 0 replies; 17+ messages in thread
From: hjl dot tools at gmail dot com @ 2009-04-06 23:16 UTC (permalink / raw)
To: gcc-bugs
------- Comment #15 from hjl dot tools at gmail dot com 2009-04-06 23:16 -------
Fixed.
--
hjl dot tools at gmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
` (14 preceding siblings ...)
2009-04-06 23:16 ` hjl dot tools at gmail dot com
@ 2009-05-27 1:23 ` jvdelisle at gcc dot gnu dot org
15 siblings, 0 replies; 17+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2009-05-27 1:23 UTC (permalink / raw)
To: gcc-bugs
------- Comment #16 from jvdelisle at gcc dot gnu dot org 2009-05-27 01:22 -------
Subject: Bug 39664
Author: jvdelisle
Date: Wed May 27 01:21:22 2009
New Revision: 147887
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147887
Log:
2009-05-23 Jerry DeLisle <jvdelisle@gcc.gnu.org>
Backport from mainline:
PR libfortran/37754
* io/write_float.def: Simplify format calculation.
2009-05-23 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Backport from mainline:
PR fortran/22423
* io/transfer.c (read_block_direct): Avoid warning.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
PR libfortran/39667
* io/file_pos.c (st_rewind): Don't truncate or flush.
* io/intrinsics.c (fgetc): Flush if switching mode.
(fputc): Likewise.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
PR libfortran/39782
* io/transfer.c (data_transfer_init): Don't flush before seek.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
* io/io.h (is_preconnected): Remove prototype.
* io/unix.c (is_preconnected): Remove function.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
PR libfortran/38668
* io/transfer.c (finalize_transfer): Don't flush for advance='no'.
2009-05-23 Danny Smith <dannysmith@clear.net.nz>
Backport from mainline:
* io/write.c (itoa) : Rename back to gfc_itoa.
(write_i): Adjust call to write_decimal.
(write_integer): Use gfc_itoa.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
* io/io.h (move_pos_offset): Remove prototype.
* io/transfer.c (formatted_transfer_scalar_read): Use sseek
instead of move_pos_offset.
* io/unix.c (move_pos_offset): Remove.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
PR libfortran/39665 libfortran/39702 libfortran/39709
* io/io.h (st_parameter_dt): Revert aligned attribute from u.p.value.
* io/list_read.c (read_complex): Read directly into user pointer.
(read_real): Likewise.
(list_formatted_read_scalar): Update read_complex and read_real calls.
(nml_read_obj): Read directly into user pointer.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
PR libfortran/39665
* io/io.h (st_parameter_dt): Add aligned attribute to u.p.value.
* io/read.c (convert_real): Add note about alignment requirements.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
* io/open.c (already_open): Test for POSIX close return value.
* io/unit.c (close_unit_1): Likewise.
* io/unix.c (raw_close): Return 0 for success for preconnected units.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
* runtime/error.c (gfc_itoa): Move to io/write.c
(xtoa): Rename to gfc_xtoa.
* runtime/backtrace.c (show_backtrace): Call gfc_xtoa.
* libgfortran.h (gfc_itoa): Remove prototype.
(xtoa): Rename prototype to gfc_xtoa.
* io/list_read.c (nml_read_obj): Use size_t for string length.
* io/transfer.c (read_block_direct): Change nbytes arg from
pointer to value.
(unformatted_read): Minor cleanup, call read_block_directly properly.
(skip_record): Use ssize_t.
(next_record_w_unf): Avoid stell() call by calling sseek with SEEK_CUR.
(iolength_transfer): Make sure to multiply before cast.
* io/intrinsics.c (fgetc): Remove unnecessary variable.
* io/format.c (format_hash): Use gfc_charlen_type.
* io/write.c (itoa): Move from runtime/error.c:gfc_itoa, rename,
make static.
(write_i): Call with pointer to itoa.
(write_z): Call with pointer to gfc_xtoa.
(write_integer): Pointer to itoa.
(nml_write_obj): Type cleanup, don't call strlen in loop.
2009-05-23 H.J. Lu <hongjiu.lu@intel.com>
Backport from mainline:
PR libgfortran/39664
* io/unix.c (raw_close): Don't close STDOUT_FILENO,
STDERR_FILENO nor STDIN_FILENO.
2009-05-23 David Edelsohn <edelsohn@gnu.org>
Backport from mainline:
* io/io.h (struct stream): Rename truncate to trunc.
(struncate): Same.
* io/unix.c (raw_init): Rename truncate to trunc.
(buf_init): Same.
(open_internal): Same.
2009-05-23 Daniel Kraft <d@domob.eu>
Backport from mainline:
PR fortran/38654
* io/read.c (read_f): Reworked to speed up floating point parsing.
(convert_real): Use pointer-casting instead of memcpy and temporaries.
2009-05-23 Jerry DeLisle <jvdelisle@gcc.gnu.org>
Backport from mainline:
PR libfortran/37754
* io/io.h (format_hash_entry): New structure for hash table.
(format_hash_table): The hash table itself.
(free_format_data): Revise function prototype.
(free_format_hash_table, init_format_hash,
free_format_hash): New function prototypes.
* io/unit.c (close_unit_1): Use free_format_hash_table.
* io/transfer.c (st_read_done, st_write_done): Free format data if
internal unit.
* io/format.c (free_format_hash_table): New function that frees any
memory allocated previously for cached format data.
(reset_node): New static helper function to reset the format counters
for a format node.
(reset_fnode_counters): New static function recursively calls
reset_node
to traverse the fnode tree.
(format_hash): New simple hash function based on XOR, probabalistic,
tosses collisions.
(save_parsed_format): New static function to save the parsed format
data to use again.
(find_parsed_format): New static function searches the hash table
looking for a match.
(free_format_data): Revised to accept pointer to format data rather
than
the dtp pointer so that the function can be used in more places.
(format_lex): Editorial.
(parse_format_list): Set flag used to determine of format data hashing
is to be used. Internal units are not persistent enough for this.
(revert): Move to ne location in file.
(parse_format): Use new functions to look for previously parsed
format strings and use them rather than re-parse. If not found, saves
the parsed format data for later use.
2009-05-23 Jerry DeLisle <jvdelisle@gcc.gnu.org>
Backport from mainline:
PR libfortran/37754
* io/transfer.c (formatted_transfer_scalar): Remove this function by
factoring it into two new functions, one for read and one for write,
eliminating all the conditionals for read or write mode.
(formatted transfer_scalar_read): New function.
(formatted transfer_scalar_write): New function.
(formatted_transfer): Use new functions.
2009-05-23 Janne Blomqvist <jb@gcc.gnu.org>
Backport from mainline:
PR libfortran/25561 libfortran/37754
* io/io.h (struct stream): Define new stream interface function
pointers, and inline functions for accessing it.
(struct fbuf): Use int instead of size_t, remove flushed element.
(mem_alloc_w): New prototype.
(mem_alloc_r): New prototype.
(stream_at_bof): Remove prototype.
(stream_at_eof): Remove prototype.
(file_position): Remove prototype.
(flush): Remove prototype.
(stream_offset): Remove prototype.
(unit_truncate): New prototype.
(read_block_form): Change to return pointer, int* argument.
(hit_eof): New prototype.
(fbuf_init): Change prototype.
(fbuf_reset): Change prototype.
(fbuf_alloc): Change prototype.
(fbuf_flush): Change prototype.
(fbuf_seek): Change prototype.
(fbuf_read): New prototype.
(fbuf_getc_refill): New prototype.
(fbuf_getc): New inline function.
* io/fbuf.c (fbuf_init): Use int, get rid of flushed.
(fbuf_debug): New function.
(fbuf_reset): Flush, and return position offset.
(fbuf_alloc): Simplify, don't flush, just realloc.
(fbuf_flush): Make usable for read mode, salvage remaining bytes.
(fbuf_seek): New whence argument.
(fbuf_read): New function.
(fbuf_getc_refill): New function.
* io/file_pos.c (formatted_backspace): Use new stream interface.
(unformatted_backspace): Likewise.
(st_backspace): Make sure format buffer is reset, use new stream
interface, use unit_truncate.
(st_endfile): Likewise.
(st_rewind): Likewise.
* io/intrinsics.c: Use new stream interface.
* io/list_read.c (push_char): Don't use u.p.scratch, use realloc
to resize.
(free_saved): Don't check u.p.scratch.
(next_char): Use new stream interface, use fbuf_getc() for external
files.
(finish_list_read): flush format buffer.
(nml_query): Update to use modified interface:s
* io/open.c (test_endfile): Use new stream interface.
(edit_modes): Likewise.
(new_unit): Likewise, set bytes_left to 1 for stream files.
* io/read.c (read_l): Use new read_block_form interface.
(read_utf8): Likewise.
(read_utf8_char1): Likewise.
(read_default_char1): Likewise.
(read_utf8_char4): Likewise.
(read_default_char4): Likewise.
(read_a): Likewise.
(read_a_char4): Likewise.
(read_decimal): Likewise.
(read_radix): Likewise.
(read_f): Likewise.
* io/transfer.c (read_sf): Use fbuf_read and mem_alloc_r, remove
usage of u.p.line_buffer.
(read_block_form): Update interface to return pointer, use
fbuf_read for direct access.
(read_block_direct): Update to new stream interface.
(write_block): Use mem_alloc_w for internal I/O.
(write_buf): Update to new stream interface.
(formatted_transfer_scalar): Don't use u.p.line_buffer, use
fbuf_seek for external files.
(us_read): Update to new stream interface.
(us_write): Likewise.
(data_transfer_init): Always check if we switch modes and flush.
(skip_record): Use new stream interface, fix comparison.
(next_record_r): Check for and reset u.p.at_eof, use new stream
interface, use fbuf_getc for spacing.
(write_us_marker): Update to new stream interface, don't inline.
(next_record_w_unf): Likewise.
(sset): New function.
(next_record_w): Use new stream interface, use fbuf for printing
newline.
(next_record): Use new stream interface.
(finalize_transfer): Remove sfree call, use new stream interface.
(st_iolength_done): Don't use u.p.scratch.
(st_read): Don't check for end of file.
(st_read_done): Don't use u.p.scratch, use unit_truncate.
(hit_eof): New function.
* io/unit.c (init_units): Always init fbuf for formatted units.
(update_position): Use new stream interface.
(unit_truncate): New function.
(finish_last_advance_record): Use fbuf to print newline.
* io/unix.c: Remove unused SSIZE_MAX macro.
(BUFFER_SIZE): Make static const variable rather than macro.
(struct unix_stream): Remove dirty_offset, len, method,
small_buffer. Order elements by decreasing size.
(struct int_stream): Remove.
(move_pos_offset): Remove usage of dirty_offset.
(reset_stream): Remove.
(do_read): Rename to raw_read, update to match new stream
interface.
(do_write): Rename to raw_write, update to new stream interface.
(raw_seek): New function.
(raw_tell): New function.
(raw_truncate): New function.
(raw_close): New function.
(raw_flush): New function.
(raw_init): New function.
(fd_alloc): Remove.
(fd_alloc_r_at): Remove.
(fd_alloc_w_at): Remove.
(fd_sfree): Remove.
(fd_seek): Remove.
(fd_truncate): Remove.
(fd_sset): Remove.
(fd_read): Remove.
(fd_write): Remove.
(fd_close): Remove.
(fd_open): Remove.
(fd_flush): Rename to buf_flush, update to new stream interface
and unix_stream.
(buf_read): New function.
(buf_write): New function.
(buf_seek): New function.
(buf_tell): New function.
(buf_truncate): New function.
(buf_close): New function.
(buf_init): New function.
(mem_alloc_r_at): Rename to mem_alloc_r, change prototype.
(mem_alloc_w_at): Rename to mem_alloc_w, change prototype.
(mem_read): Change to match new stream interface.
(mem_write): Likewise.
(mem_seek): Likewise.
(mem_tell): Likewise.
(mem_truncate): Likewise.
(mem_close): Likewise.
(mem_flush): New function.
(mem_sfree): Remove.
(empty_internal_buffer): Cast to correct type.
(open_internal): Use correct type, init function pointers.
(fd_to_stream): Test whether to open file as buffered or raw.
(output_stream): Remove mode set.
(error_stream): Likewise.
(flush_all_units_1): Use new stream interface.
(flush_all_units): Likewise.
(stream_at_bof): Remove.
(stream_at_eof): Remove.
(file_position): Remove.
(file_length): Update logic to use stream interface.
(flush): Remove.
(stream_offset): Remove.
* io/write.c (write_utf8_char4): Use int instead of size_t.
(write_x): Extra safety check.
(namelist_write_newline): Use new stream interface.
Modified:
branches/gcc-4_4-branch/libgfortran/ChangeLog
branches/gcc-4_4-branch/libgfortran/io/fbuf.c
branches/gcc-4_4-branch/libgfortran/io/file_pos.c
branches/gcc-4_4-branch/libgfortran/io/format.c
branches/gcc-4_4-branch/libgfortran/io/intrinsics.c
branches/gcc-4_4-branch/libgfortran/io/io.h
branches/gcc-4_4-branch/libgfortran/io/list_read.c
branches/gcc-4_4-branch/libgfortran/io/open.c
branches/gcc-4_4-branch/libgfortran/io/read.c
branches/gcc-4_4-branch/libgfortran/io/transfer.c
branches/gcc-4_4-branch/libgfortran/io/unit.c
branches/gcc-4_4-branch/libgfortran/io/unix.c
branches/gcc-4_4-branch/libgfortran/io/write.c
branches/gcc-4_4-branch/libgfortran/io/write_float.def
branches/gcc-4_4-branch/libgfortran/libgfortran.h
branches/gcc-4_4-branch/libgfortran/runtime/backtrace.c
branches/gcc-4_4-branch/libgfortran/runtime/error.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39664
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2009-05-27 1:23 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-06 15:41 [Bug fortran/39664] New: [4.5 Regression] 436.cactusADM in SPEC CPU 2006 is miscompiled hjl dot tools at gmail dot com
2009-04-06 15:43 ` [Bug libfortran/39664] " hjl dot tools at gmail dot com
2009-04-06 19:49 ` burnus at gcc dot gnu dot org
2009-04-06 19:53 ` [Bug libfortran/39664] [4.5 Regression] Revision 145571 caused 436.cactusADM in SPEC CPU 2006 to fail hjl dot tools at gmail dot com
2009-04-06 21:34 ` hjl dot tools at gmail dot com
2009-04-06 22:15 ` hjl dot tools at gmail dot com
2009-04-06 22:20 ` [Bug libfortran/39664] [4.5 Regression] Revision 145571 breaks stdio hjl dot tools at gmail dot com
2009-04-06 22:22 ` pinskia at gcc dot gnu dot org
2009-04-06 22:41 ` hjl dot tools at gmail dot com
2009-04-06 22:44 ` hjl dot tools at gmail dot com
2009-04-06 22:46 ` kargl at gcc dot gnu dot org
2009-04-06 22:48 ` pinskia at gcc dot gnu dot org
2009-04-06 22:53 ` hjl dot tools at gmail dot com
2009-04-06 22:57 ` hjl dot tools at gmail dot com
2009-04-06 23:08 ` hjl at gcc dot gnu dot org
2009-04-06 23:16 ` hjl dot tools at gmail dot com
2009-05-27 1:23 ` jvdelisle at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).