public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "steven at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/35452] erasing uncessary warning for basic block frequency computation Date: Sat, 18 Apr 2009 20:01:00 -0000 [thread overview] Message-ID: <20090418200128.27088.qmail@sourceware.org> (raw) In-Reply-To: <bug-35452-14209@http.gcc.gnu.org/bugzilla/> ------- Comment #2 from steven at gcc dot gnu dot org 2009-04-18 20:01 ------- Similar as what is said in commen #0, the detailed vrp1 dump of trunk today has: Removing basic block 3 ;; basic block 3, loop depth 0, count 0 ;; prev block 7, next block 4 ;; pred: ;; succ: 8 [100.0%] (fallthru,exec) Invalid sum of incoming frequencies 0, should be 5000 goto <bb 8>; Note the *Removing* basic block. The CFG branch probabilities have already been updated at this point. The edge redirection functions do not take care of this (often only the caller knows how the profile/predictions should be updated). You can see in the dump at the end what the function looks like after vrp1, and you'll notice the branch probabilities are OK. So there is no bug -> INVALID. But thanks for the report. It took me a little while to figure out what is going on. We should probably not dump this "Invalid sum" blah-blah for blocks that we are about to remove. -- steven at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35452
prev parent reply other threads:[~2009-04-18 20:01 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-04 3:34 [Bug tree-optimization/35452] New: " zhouyi04 at ios dot cn 2008-03-05 7:03 ` [Bug tree-optimization/35452] " zhouyi04 at ios dot cn 2009-04-18 20:01 ` steven at gcc dot gnu dot org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090418200128.27088.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).