[Bug c/19771] VLA deallocation

[Bug c/19771] VLA deallocation

[steven at gcc dot gnu dot org]

------- Comment #3 from steven at gcc dot gnu dot org  2009-03-29 22:36 -------
Created an attachment (id=17557)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17557&action=view)
Always create a new BIND_EXPR for VLA decls

I tried to make use of scopes: If a label is defined in a parent scope, start a
new BIND_EXPR.  This did not work.

So the attached patch takes the brute-force approach.  When optimizing, this
_should_ not hurt, but we get two __builtin_stack_restore calls now. 
Apparently Jakub's PR23848 fix doesn't work for our case.

Anyway, this patch does, of course, make the test case of comment #0 run.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19771

[Bug c/19771] VLA deallocation

[steven at gcc dot gnu dot org]

------- Comment #4 from steven at gcc dot gnu dot org  2009-03-29 22:38 -------
Jakub, this is what we discussed last night.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu dot org
  BugsThisDependsOn|                            |23848


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19771

[Bug c/19771] VLA deallocation

[jsm28 at gcc dot gnu dot org]

------- Comment #5 from jsm28 at gcc dot gnu dot org  2009-04-19 20:20 -------
Subject: Bug 19771

Author: jsm28
Date: Sun Apr 19 20:19:54 2009
New Revision: 146358

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146358
Log:
        PR c/19771
        * c-semantics.c (pop_stmt_list): Propagate
        STATEMENT_LIST_HAS_LABEL to parent statement list.

testsuite:
        * gcc.c-torture/execute/vla-dealloc-1.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/vla-dealloc-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-semantics.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19771

[Bug c/19771] VLA deallocation

[jsm28 at gcc dot gnu dot org]

------- Comment #6 from jsm28 at gcc dot gnu dot org  2009-04-19 20:21 -------
Fixed for 4.5.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to work|                            |4.5.0
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19771

[Bug c/19771] VLA deallocation

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2005-02-12 00:09 -------
The problem here is that the C front end is not creating a new BIND_EXPR
for the scope starting at the declaration for X.  Insert one by hand and
you'll see that the tree optimizers are doing the right thing.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2005-02-03 02:35:43         |2005-02-12 00:09:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19771