[Bug testsuite/39807] New: [4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[Bug testsuite/39807] New: [4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[pinskia at gcc dot gnu dot org]

When running dg-extract-results on powerpc-darwin (I have not tried on other
targets), I get the following error message from awk:
awk: /tmp/dg-combine-results-13477-nUnyyO/list27 makes too many open files
 input record number 11671, file 
 source line number 40

So only the summary of the how many failed is generated and what actual failed.


-- 
           Summary: [4.4/4.5 Regression] Reporting of testsuite failures are
                    messed up when using -j
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[ebotcazou at gcc dot gnu dot org]

------- Comment #1 from ebotcazou at gcc dot gnu dot org  2009-04-18 15:17 -------
Same on Solaris.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-04-18 15:17:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2009-04-20 08:09 -------
AFAIK this has been backported to branches/gcc-4_3-branch as well by Janis.

You haven't said on which tool this triggers (gcc, or libstdc++, or something
else), e.g. on gcc there are around 164 different Running lines, so your number
of opened files limit would be extremely low.

In any case, I'll try to play with close in some spots of guts.awk, but will
need testing on the targets with unusable awk.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4/4.5 Regression]        |[4.3/4.4/4.5 Regression]
                   |Reporting of testsuite      |Reporting of testsuite
                   |failures are messed up when |failures are messed up when
                   |using -j                    |using -j


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2009-04-20 09:37 -------
Created an attachment (id=17655)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17655&action=view)
gcc45-pr39807.patch

Please try this patch.  So far I've just tested that it generates the
same results as before the patch for
dg-extract-results.sh testsuite/gcc*/*.sum.sep
dg-extract-results.sh -L testsuite/gcc*/*.log.sep
dg-extract-results.sh testsuite/ada/*/*.sum.sep
dg-extract-results.sh -L testsuite/ada/*/*.log.sep
and am doing a full bootstrap/regtest on x86_64-linux and i686-linux.
But given that I can't reproduce the original problem, this is just a guess
what might be a problem, so testing on darwin and/or solaris is needed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2009-04-20 11:02 -------
It bootstrapped/regtested on x86_64-linux and i686-linux just fine (both with
-j48), results were merged correctly.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2009-04-20 17:36 -------
(In reply to comment #3)
> and am doing a full bootstrap/regtest on x86_64-linux and i686-linux.
> But given that I can't reproduce the original problem, this is just a guess
> what might be a problem, so testing on darwin and/or solaris is needed.

This works for powerpc-darwin.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2009-04-20 22:01 -------
And it works correctly on i386-darwin too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.0                       |4.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Target Milestone|4.4.1                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[ebotcazou at gcc dot gnu dot org]

------- Comment #7 from ebotcazou at gcc dot gnu dot org  2009-04-25 19:02 -------
Another nit on Solaris 9:

                === acats Summary ===
# of expected passes            773
# of unexpected failures        0
gmake[1]: Leaving directory
`/nfs/nile/nile.build/botcazou/gcc-head/sparc-sun-solaris2.9/gcc'
nawk: syntax error at source line 5
 context is
         >>> /= <<<
nawk: bailing out at source line 5
nawk: syntax error at source line 5
 context is
         >>> /= <<<
nawk: bailing out at source line 5

so no results are reported for ACATS.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2009-04-25 19:22 -------
Very useful awk implementation.  Not.
Anyway, can you try
sed -i -e 's,/==,/.=,' contrib/dg-extract-results.sh
or
sed -i -e 's,/==,/[=]=,' contrib/dg-extract-results.sh
or
sed -i -e 's,/==,/^.*==,' contrib/dg-extract-results.sh
?  I guess the last one would be best.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[ebotcazou at gcc dot gnu dot org]

------- Comment #9 from ebotcazou at gcc dot gnu dot org  2009-04-25 20:27 -------
> Anyway, can you try
> sed -i -e 's,/==,/.=,' contrib/dg-extract-results.sh
> or
> sed -i -e 's,/==,/[=]=,' contrib/dg-extract-results.sh
> or
> sed -i -e 's,/==,/^.*==,' contrib/dg-extract-results.sh
> ?  I guess the last one would be best.

Thanks, the last one works.  But then nawk chokes on

  print > "${TMP}/chapter-"chapter

so I additionally need:

/^Running chapter / {
  if (chapter) close ("${TMP}/chapter-"chapter)
  chapter=\$3
  file="${TMP}/chapter-"chapter
  print >> file
  next
}

and

{
  if (print_prologue) { print; next }
  if (chapter) {
    file="${TMP}/chapter-"chapter
    print >> file
  }
}

With all the changes I get a correct ACATS log file (at least manually).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #10 from jakub at gcc dot gnu dot org  2009-04-25 22:47 -------
Created an attachment (id=17693)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17693&action=view)
gcc45-pr39807.patch

Does this work too?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[ebotcazou at gcc dot gnu dot org]

------- Comment #11 from ebotcazou at gcc dot gnu dot org  2009-04-25 22:57 -------
> Does this work too?

Yes, it does, thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #12 from jakub at gcc dot gnu dot org  2009-04-27 19:11 -------
Subject: Bug 39807

Author: jakub
Date: Mon Apr 27 19:11:23 2009
New Revision: 146850

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146850
Log:
        PR testsuite/39807
        * dg-extract-results.sh: Close open files and use >> instead of >
        to decrease number of concurrently open files from awk.  Avoid
        = at the beginning of a regexp and redirect to a file determined
        by curfile variable rather than concatenated strings to workaround
        Solaris nawk bug.

Modified:
    trunk/contrib/ChangeLog
    trunk/contrib/dg-extract-results.sh


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3/4.4/4.5 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #13 from jakub at gcc dot gnu dot org  2009-04-27 19:13 -------
Subject: Bug 39807

Author: jakub
Date: Mon Apr 27 19:13:16 2009
New Revision: 146851

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146851
Log:
        PR testsuite/39807
        * dg-extract-results.sh: Close open files and use >> instead of >
        to decrease number of concurrently open files from awk.  Avoid
        = at the beginning of a regexp and redirect to a file determined
        by curfile variable rather than concatenated strings to workaround
        Solaris nawk bug.

Modified:
    branches/gcc-4_4-branch/contrib/ChangeLog
    branches/gcc-4_4-branch/contrib/dg-extract-results.sh


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3 Regression] Reporting of testsuite failures are messed up when using -j

[jakub at gcc dot gnu dot org]

------- Comment #14 from jakub at gcc dot gnu dot org  2009-04-27 21:17 -------
Fixed for 4.4/4.5 so far.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.3/4.4/4.5 Regression]    |[4.3 Regression] Reporting
                   |Reporting of testsuite      |of testsuite failures are
                   |failures are messed up when |messed up when using -j
                   |using -j                    |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3 Regression] Reporting of testsuite failures are messed up when using -j

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2009-08-04 12:30 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807

[Bug testsuite/39807] [4.3 Regression] Reporting of testsuite failures are messed up when using -j

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2010-05-22 18:13 -------
GCC 4.3.5 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.5                       |4.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39807