[Bug tree-optimization/39806] New: incorrect pointer hashing in ipa-struct-reorg.c

[Bug tree-optimization/39806] New: incorrect pointer hashing in ipa-struct-reorg.c

[bonzini at gnu dot org]

The way the new_local_vars hash table is hashed in ipa-struct-reorg.c causes
spurious code differences across runs of GCC.  I saw this, for example, in
gcc.dg/struct/wo_prof_two_strs.c:

--- base-mn10300-gcc-build/gcc/cc1 -mam33
+++ mn10300-gcc-build/gcc/cc1 -mam33
@@ -117,12 +117,12 @@
        .comm   _p2,4,4
        .local  _num
        .comm   _num,4,4
-       .local  _p1___0
-       .comm   _p1___0,4,4
-       .local  _p1___1
-       .comm   _p1___1,4,4
        .local  _p2___0
        .comm   _p2___0,4,4
        .local  _p2___1
        .comm   _p2___1,4,4
+       .local  _p1___0
+       .comm   _p1___0,4,4
+       .local  _p1___1
+       .comm   _p1___1,4,4
        .ident  "GCC: (GNU) 4.4.0 20090314 (experimental)"


-- 
           Summary: incorrect pointer hashing in ipa-struct-reorg.c
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bonzini at gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[bonzini at gnu dot org]

-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-04-18 11:12:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[steven at gcc dot gnu dot org]

------- Comment #1 from steven at gcc dot gnu dot org  2009-04-18 19:24 -------
Spurious differences fall in the "wrong code" category.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2009-04-21 18:00 -------
new_var_hash should be changed to use DECL_UID since we know that these are all
going to be decls.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[olga at il dot ibm dot com]

------- Comment #3 from olga at il dot ibm dot com  2009-11-26 15:35 -------
Potential patch (as Andew suggested). Please check for your platform.

http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01467.html

Thanks,
Olga


-- 

olga at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bonzini at gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[olga at gcc dot gnu dot org]

------- Comment #4 from olga at gcc dot gnu dot org  2009-11-30 14:43 -------
Subject: Bug 39806

Author: olga
Date: Mon Nov 30 14:42:54 2009
New Revision: 154811

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154811
Log:
2009-11-30  Olga Golovanevsky  <olga@il.ibm.com>

        PR middle-end/39806
        * ipa-struct-reorg.c (new_var_eq): Use DECL_UID to hash new variables.
        (new_var_hash): Likewise.
        (is_in_new_vars_htab): Likewise.
        (add_to_new_vars_htab): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-struct-reorg.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[steven at gcc dot gnu dot org]

------- Comment #5 from steven at gcc dot gnu dot org  2010-02-18 19:48 -------
Olga, is this fixed?


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806

[Bug tree-optimization/39806] incorrect pointer hashing in ipa-struct-reorg.c

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2010-02-19 10:09 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39806