[Bug bootstrap/39929] New: [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9

[Bug bootstrap/39929] New: [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9

[dominiq at lps dot ens dot fr]

Bootstrapping revision 146838 fails at stage 1 on powerpc-apple-darwin9 with:

...
/opt/gcc/darwin_buildw/./gcc/xgcc -B/opt/gcc/darwin_buildw/./gcc/
-B/opt/gcc/gcc4.5w/powerpc-apple-darwin9/bin/
-B/opt/gcc/gcc4.5w/powerpc-apple-darwin9/lib/ -isystem
/opt/gcc/gcc4.5w/powerpc-apple-darwin9/include -isystem
/opt/gcc/gcc4.5w/powerpc-apple-darwin9/sys-include -g -O2 -m64 -O2  -g -O2
-DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
-Wcast-qual -Wold-style-definition  -isystem ./include 
-Wa,-force_cpusubtype_ALL -pipe -mmacosx-version-min=10.4 -g
-DHAVE_GTHR_DEFAULT -DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED   -I. -I.
-I../../.././gcc -I../../../../gcc-4.5-work/libgcc
-I../../../../gcc-4.5-work/libgcc/. -I../../../../gcc-4.5-work/libgcc/../gcc
-I../../../../gcc-4.5-work/libgcc/../include  -DHAVE_CC_TLS -o _floatdisf.o -MT
_floatdisf.o -MD -MP -MF _floatdisf.dep -DL_floatdisf -c
../../../../gcc-4.5-work/libgcc/../gcc/libgcc2.c \
          -fvisibility=hidden -DHIDE_EXPORTS
{standard input}:194:non-relocatable subtraction expression, "LC1" minus
"L00000000001$pb"
{standard input}:194:symbol: "L00000000001$pb" can't be undefined in a
subtraction expression
{standard input}:193:non-relocatable subtraction expression, "LC1" minus
"L00000000001$pb"
{standard input}:193:symbol: "L00000000001$pb" can't be undefined in a
subtraction expression
{standard input}:175:non-relocatable subtraction expression, "LC0" minus
"L00000000001$pb"
{standard input}:175:symbol: "L00000000001$pb" can't be undefined in a
subtraction expression
{standard input}:174:non-relocatable subtraction expression, "LC0" minus
"L00000000001$pb"
{standard input}:174:symbol: "L00000000001$pb" can't be undefined in a
subtraction expression
{standard input}:135:non-relocatable subtraction expression, "LC2" minus
"L00000000001$pb"
{standard input}:135:symbol: "L00000000001$pb" can't be undefined in a
subtraction expression
{standard input}:131:non-relocatable subtraction expression, "LC2" minus
"L00000000001$pb"
{standard input}:131:symbol: "L00000000001$pb" can't be undefined in a
subtraction expression
{standard input}:unknown:Undefined local symbol L00000000001$pb
make[5]: *** [_floatdisf.o] Error 1
make[4]: *** [multi-do] Error 1
make[3]: *** [all-multi] Error 2
make[2]: *** [all-stage1-target-libgcc] Error 2
make[1]: *** [stage1-bubble] Error 2
make: *** [all] Error 2


-- 
           Summary: [4.5 Regression] Bootstrapping fails at stage 1 on
                    powerpc-apple-darwin9
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: powerpc-apple-darwin9
  GCC host triplet: powerpc-apple-darwin9
GCC target triplet: powerpc-apple-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9

[dominiq at lps dot ens dot fr]

------- Comment #1 from dominiq at lps dot ens dot fr  2009-04-27 13:11 -------
I have forgotten to add that this is probably the same failure as reported at

http://gcc.gnu.org/ml/gcc-regression/2009-04/msg00196.html

and occurring between revisions 146801 and 146817.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[dje at gcc dot gnu dot org]

------- Comment #2 from dje at gcc dot gnu dot org  2009-04-27 13:54 -------
This also fails on AIX.  On AIX, the error appears as a failure while compiling
libobjc/linking.m.

A function in cgraphunit.c is being mis-compiled, possibly build_cdtor().  This
causes cgraph_build_static_cdtor() to be called with an invalid priority of
"-1", instead of 65535.  The priority should not be negative.  This negative
priority value generates an invalid global file function name:

_GLOBAL__I_-00001_0___objc_linking

A function name should not contain a minus sign, which is a syntax error. 
Recompiling cgarphunit.c without optimization fixes the miscompilation.  An
incorrect priority is calculated from decl_fini_priority_lookup(), but
recompiling tree.c does not change the failure.


-- 

dje at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|powerpc-apple-darwin9       |powerpc-apple-
                   |                            |darwin9,powerpc-ibm-aix
   GCC host triplet|powerpc-apple-darwin9       |powerpc-apple-
                   |                            |darwin9,powerpc-ibm-aix
 GCC target triplet|powerpc-apple-darwin9       |powerpc-apple-
                   |                            |darwin9,powerpc-ibm-aix
           Priority|P3                          |P1
   Last reconfirmed|0000-00-00 00:00:00         |2009-04-27 13:54:23
               date|                            |
            Summary|[4.5 Regression]            |[4.5 Regression]
                   |Bootstrapping fails at stage|Bootstrapping fails at stage
                   |1 on powerpc-apple-darwin9  |1 on powerpc-apple-darwin9
                   |                            |and powerpc-ibm-aix


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[dje at gcc dot gnu dot org]

------- Comment #3 from dje at gcc dot gnu dot org  2009-04-27 14:19 -------
This probably is related to the promoted parameter problem that has appeared on
other architectures as well.


-- 

dje at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matz at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2009-04-27 19:06 -------
Here is a reduced testcase for the PPC-darwin failure:
float f(int a) { return a ? 1.0f : 2.0f ; }


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |assemble-failure, build,
                   |                            |wrong-code
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2009-04-27 19:11 -------
(In reply to comment #4)
> Here is a reduced testcase for the PPC-darwin failure:
> float f(int a) { return a ? 1.0f : 2.0f ; }

This looks like how constants are expanded in PHIs, looking into it further.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2009-04-27 19:24 -------
This patch fixes the ppc-darwin failure:
Index: cfgexpand.c
===================================================================
--- cfgexpand.c (revision 146848)
+++ cfgexpand.c (working copy)
@@ -2503,11 +2503,11 @@ gimple_expand_cfg (void)
       gcc_assert (crtl->parm_stack_boundary <= INCOMING_STACK_BOUNDARY);
     }

-  expand_phi_nodes (&SA);
-
   /* Register rtl specific functions for cfg.  */
   rtl_register_cfg_hooks ();

+  expand_phi_nodes (&SA);
+
   init_block = construct_init_block ();

   /* Clear EDGE_EXECUTABLE on the entry edge(s).  It is cleaned from the

--- CUT ---
expand_phi_nodes can and will create RTL code so we need to register the RTL
CFG hooks before calling it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2009-04-27 19:44 -------
This is the correct fix as in darwin.c we have:
      /* Play games to avoid marking the function as needing pic if we
         are being called as part of the cost-estimation process.  */
      if (current_ir_type () != IR_GIMPLE)
        crtl->uses_pic_offset_table = 1;




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[matz at gcc dot gnu dot org]

------- Comment #8 from matz at gcc dot gnu dot org  2009-04-28 00:37 -------
> expand_phi_nodes can and will create RTL code so we need to register the RTL
> CFG hooks before calling it.

Nope, that won't fly (for the moment).  expand_phi_nodes also split edges
and it's necessary that this is done while the tree hooks are still
registered (only those can redirect EH edges).

This whole pass crossover (tree-ssa -> RTL) is a tough problem, and there's a
variable to say that we're inside of it (currently_expanding_to_rtl).
Obviously it would be nicer to make darwin.c not depend on the current IR
mode to set or not set random flags.  If somebody can explain why it's
necessary to let the generated RTL code depend on the IR mode, we could
possibly find a good way around this limitation.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2009-04-28 01:04 -------
(In reply to comment #8)
>  If somebody can explain why it's
> necessary to let the generated RTL code depend on the IR mode, we could
> possibly find a good way around this limitation.

Because we don't want to mark uses_pic_offset_table as being needed when
dealing with IV-opts.
See http://gcc.gnu.org/ml/gcc-patches/2008-09/msg01535.html .  Sounds like the
arm back-end does the same thing.

The MIPS back-end does:
      && (current_ir_type () != IR_GIMPLE || currently_expanding_to_rtl))

While the ARM back-end (and darwin.c) does:
          if (current_ir_type () != IR_GIMPLE)


So the MIPS back-end will work but the arm back-end should change to be include
|| currently_expanding_to_rtl.

Fixing darwin.c that way instead of the other patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2009-04-28 14:19 -------
Subject: Bug 39929

Author: pinskia
Date: Tue Apr 28 14:19:00 2009
New Revision: 146894

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146894
Log:
2009-04-28  Andrew Pinski  <pinskia@gmail.com>

        PR target/39929
        * config/darwin.c (machopic_gen_offset): Check
        currently_expanding_to_rtl if current_ir_type returns IR_GIMPLE.
        * config/arm/arm.c (require_pic_register): Likewise.




Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/darwin.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2009-04-28 14:21 -------
The darwin part of this bug report should have been fixed.  The AIX bug was
unrelated to the darwin bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[jules at gcc dot gnu dot org]

------- Comment #12 from jules at gcc dot gnu dot org  2009-04-28 22:31 -------
FYI: the above patch seems to have caused ARM Linux (cross) builds to break,
e.g.:

/scratch/julian/arm-mainline/src/gcc-mainline/libgcc/../gcc/config/arm/unwind-arm.c:589:
internal compiler error: Segmentation fault

Program received signal SIGSEGV, Segmentation fault.
0x08253611 in emit_insn_after_1 (first=0xf7cd7798, after=0xf7c744f8,
    bb=0xf7c74540)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/emit-rtl.c:4129
4129          if (BB_END (bb) == after)

Backtrace:

#0  0x08253611 in emit_insn_after_1 (first=0xf7cd7798, after=0xf7c744f8,
    bb=0xf7c74540)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/emit-rtl.c:4129
#1  0x082544ac in emit_insn_after (pattern=0x0, after=0xf7c744f8)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/emit-rtl.c:4335
#2  0x0862b3c6 in require_pic_register ()
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/config/arm/arm.c:3590
#3  legitimize_pic_address (orig=0xf7ca2ccc, mode=SImode, reg=0x0)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/config/arm/arm.c:3607
#4  0x086f32ed in gen_movsi (operand0=0x0, operand1=0xf7ca2ccc)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/config/arm/arm.md:4966
#5  0x0828ef94 in emit_move_insn_1 (x=0xf7cca0a0, y=0xf7ca2ccc)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/expr.c:3337
#6  0x0828f282 in emit_move_insn (x=0xf7cca0a0, y=0xf7ca2ccc)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/expr.c:3425
#7  0x0881e7ea in insert_value_copy_on_edge (src=<value optimized out>,
    dest=<value optimized out>, e=<value optimized out>)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/tree-outof-ssa.c:190
#8  eliminate_phi (g=<value optimized out>, e=<value optimized out>)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/tree-outof-ssa.c:594
#9  expand_phi_nodes (sa=0x8d125b4)
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/tree-outof-ssa.c:756
#10 0x08795c2f in gimple_expand_cfg ()
    at /scratch/julian/arm-mainline/src/gcc-mainline/gcc/cfgexpand.c:2506
...

(gdb) print *bb
$1 = {preds = 0xf7e57a8c, succs = 0xf7e2e390, aux = 0x0,
  loop_father = 0xf7e57ab0, dom = {0x0, 0xf7c74558}, prev_bb = 0xf7e2a5b0,
  next_bb = 0x0, il = {gimple = 0x0, rtl = 0x0}, count = -584888453233663636,
  index = -136179944, loop_depth = -137911904, frequency = 0,
  flags = -136126440}

Maybe there's some significant difference between the behaviour of
mips16_gp_pseudo_reg() and require_pic_register() which causes this, or maybe
MIPS is broken too?


-- 

jules at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jules at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2009-04-28 22:50 -------
(In reply to comment #12)
> Maybe there's some significant difference between the behaviour of
> mips16_gp_pseudo_reg() and require_pic_register() which causes this, or maybe
> MIPS is broken too?

Hmm,
ARM uses emit_insn_after (seq, entry_of_function ()); while mips uses 
push_topmost_sequence/pop_topmost_sequence.

Maybe this is more broken and was broken with SSA to RTL patch after all.

The darwin back-end delays emitting of the branch for the PIC register until
the prologue.  Maybe both mips and ARM back-end should do the same thing. 
Actually the arm back-end already does most of them.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[matz at gcc dot gnu dot org]

------- Comment #14 from matz at gcc dot gnu dot org  2009-04-29 17:37 -------
Subject: Bug 39929

Author: matz
Date: Wed Apr 29 17:36:21 2009
New Revision: 146982

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146982
Log:
        PR middle-end/39927
        PR bootstrap/39929
        * tree-outof-ssa.c (emit_partition_copy): New function.
        (insert_partition_copy_on_edge, insert_rtx_to_part_on_edge,
        insert_part_to_rtx_on_edge): Perform the partition base var
        copy using emit_partition_copy.
        (insert_value_copy_on_edge): Convert constants to the right mode.
        (insert_rtx_to_part_on_edge): Add UNSIGNEDSRCP parameter.
        (elim_create): Pass the sign of the src to insert_rtx_to_part_on_edge.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-outof-ssa.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-apple-darwin9 and powerpc-ibm-aix

[dominiq at lps dot ens dot fr]

------- Comment #15 from dominiq at lps dot ens dot fr  2009-05-04 11:45 -------
This pr is fixed as long as *-apple-darwin9 is concerned. Due to comments #11
to
#13, I don't close it as fixed. If someone wants to keep this PR open, (s)he
should change subject, platform, and priority.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-ibm-aix

[mmitchel at gcc dot gnu dot org]

------- Comment #16 from mmitchel at gcc dot gnu dot org  2009-05-05 15:13 -------
Jules, is the ARM GNU/Linux build still broken?

David, how about AIX?

Thanks,

-- Mark


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.5 Regression]            |[4.5 Regression]
                   |Bootstrapping fails at stage|Bootstrapping fails at stage
                   |1 on powerpc-apple-darwin9  |1 on powerpc-ibm-aix
                   |and powerpc-ibm-aix         |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-ibm-aix

[jules at gcc dot gnu dot org]

------- Comment #17 from jules at gcc dot gnu dot org  2009-05-05 16:07 -------
This still seems to be broken as of r147126 for ARM Linux.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-ibm-aix

[pinskia at gcc dot gnu dot org]

------- Comment #18 from pinskia at gcc dot gnu dot org  2009-05-05 19:15 -------
(In reply to comment #16)
> Jules, is the ARM GNU/Linux build still broken?

Yes it is still broken; I filed a seperate bug for that though, see PR 40031.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-ibm-aix

[bonzini at gnu dot org]

------- Comment #19 from bonzini at gnu dot org  2009-05-06 15:33 -------
ARM moved to PR40031 (and PR39978?).

What about AIX?


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929

[Bug bootstrap/39929] [4.5 Regression] Bootstrapping fails at stage 1 on powerpc-ibm-aix

[matz at gcc dot gnu dot org]

------- Comment #20 from matz at gcc dot gnu dot org  2009-05-06 15:48 -------
Bootstrap on AIX was already working on April 29:
http://gcc.gnu.org/ml/gcc-patches/2009-04/msg02342.html

I just left this open for the other (ARM/Mips) problem.  As that now moved
somewhere else, this here is fixed.


-- 

matz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39929