[Bug c/40022] New: 4.4 regression breaks "reply to all" in alpine

[Bug c/40022] New: 4.4 regression breaks "reply to all" in alpine

[joshuadfranklin at yahoo dot com]

Hello, I have to admit I'm clueless about how to debug this. 
On Fedora 11 preview release with gcc-4.4.0 alpine "reply to all"
does not include the list of cc'd addresses. Linus found that if
you compile the pith/reply.cc without optimizations it works 
properly (see Fedora bug report at 
http://bugzilla.redhat.com/show_bug.cgi?id=496400 ).

Here is how to reproduce:

mkdir alpinetest
cd alpinetest
svn checkout https://svn.cac.washington.edu/public/alpine/snapshots/
cd snapshots
_sysconfdir=/etc/
touch imap/ip6
./configure \  --enable-debug=no \
  --without-tcl \
  --with-c-client-target=lfd \
  --with-passfile=.alpine.passfile \
  --with-spellcheck-prog=aspell \
  --with-system-pinerc=%{_sysconfdir}/pine.conf \
  --with-system-fixed-pinerc=%{_sysconfdir}/pine.conf.fixed

make

alpine/alpine # try "Reply to all" and see bug

cd pith
make clean && make CFLAGS=-O0
cd ..
make
alpine/alpine # try "Reply to all" and see it working


-- 
           Summary: 4.4 regression breaks "reply to all" in alpine
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: joshuadfranklin at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2009-05-04 23:16 -------
Hmm, so -fwrapv and -fno-strict-aliasing fixes the problem which case it might
be a bug in the source.

Can you provide the preprocessed source of pith/reply.cc?  


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
          Component|c                           |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[joshuadfranklin at yahoo dot com]

------- Comment #2 from joshuadfranklin at yahoo dot com  2009-05-04 23:36 -------
Created an attachment (id=17798)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17798&action=view)
alpine pith/reply.c compiled with O0 and save-temps


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[joshuadfranklin at yahoo dot com]

-- 

joshuadfranklin at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joshuadfranklin at yahoo dot
                   |                            |com
             Status|WAITING                     |UNCONFIRMED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2009-05-04 23:55 -------
That is the assembler that is produced not the preprocessed source, use
-save-temps and attach the .ii file. 

Thanks,
Andrew Pinski


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[joshuadfranklin at yahoo dot com]

------- Comment #4 from joshuadfranklin at yahoo dot com  2009-05-05 00:00 -------
Created an attachment (id=17799)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17799&action=view)
alpine pith/reply.c compiled with save-temps


'
My compile line:

gcc -c -save-temps -std=gnu99 -DHAVE_CONFIG_H   -I../include -I../include
-I/etc/pki/tls/include   -c -o reply.o reply.c

Make output:

cc -save-temps -std=gnu99 -DHAVE_CONFIG_H   -I../include -I../include
-I/etc/pki/tls/include   -O0 -MT reply.o -MD -MP -MF .deps/reply.Tpo -c -o
reply.o reply.c


-- 

joshuadfranklin at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17798|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[joshuadfranklin at yahoo dot com]

------- Comment #5 from joshuadfranklin at yahoo dot com  2009-05-05 00:01 -------
(In reply to comment #3)
> That is the assembler that is produced not the preprocessed source, use
> -save-temps and attach the .ii file. 

Sorry. Does this one look right? It's actually .c I typo'd the .cc.


-- 

joshuadfranklin at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |UNCONFIRMED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] 4.4 regression breaks "reply to all" in alpine

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2009-05-05 09:02 -------
Reduced testcase:
extern void abort (void);

struct A
{
  struct A *a;
};

struct B
{
  struct A *b;
};

__attribute__((noinline))
struct A *
foo (struct A *x)
{
  asm volatile ("" : : "g" (x) : "memory");
  return x;
}

__attribute__((noinline))
void
bar (struct B *w, struct A *x, struct A *y, struct A *z)
{
  struct A **c;
  c = &w->b;
  *c = foo (x);
  while (*c)
    c = &(*c)->a;
  *c = foo (y);
  while (*c)
    c = &(*c)->a;
  *c = foo (z);
}

struct B d;
struct A e, f, g;

int
main (void)
{
  f.a = &g;
  bar (&d, &e, &f, 0);
  if (d.b == 0
      || d.b->a == 0
      || d.b->a->a == 0
      || d.b->a->a->a != 0)
    abort ();
  return 0;
}

Looking into it.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-05-05 09:02:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] breaks "reply to all" in alpine

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|4.4 regression breaks "reply|[4.4 Regression] breaks
                   |to all" in alpine           |"reply to all" in alpine
   Target Milestone|---                         |4.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4/4.5 Regression] Alpine miscompilation

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2009-05-05 10:01 -------
Introduced during tuples merge apparently (haven't bisected the tuples branch
though).
To me this looks like a phiprop bug.
In *.alias (trunk, -O2) we have:
  # BLOCK 3 freq:9100
  # PRED: 4 [91.0%]  (true,exec)
  # VUSE <.MEMD.2716_19>
  D.1614_8 = *cD.1606_1;
  cD.1606_9 = &D.1614_8->aD.1593;
  # SUCC: 4 [100.0%]  (fallthru,dfs_back,exec)

  # BLOCK 4 freq:10000
  # PRED: 2 [100.0%]  (fallthru,exec) 3 [100.0%]  (fallthru,dfs_back,exec)
  # cD.1606_1 = PHI <cD.1606_4(2), cD.1606_9(3)>
  # VUSE <.MEMD.2716_19>
  D.1614_7 = *cD.1606_1;
  if (D.1614_7 != 0B)
    goto <bb 3>;
  else
    goto <bb 5>;
  # SUCC: 3 [91.0%]  (true,exec) 5 [9.0%]  (false,exec)

  # BLOCK 5 freq:900
  # PRED: 4 [9.0%]  (false,exec)
  # .MEMD.2716_20 = VDEF <.MEMD.2716_19>
  D.1615_11 = fooD.1597 (yD.1602_10(D));
  # .MEMD.2716_21 = VDEF <.MEMD.2716_20>
  *cD.1606_1 = D.1615_11;
  goto <bb 7>;
  # SUCC: 7 [100.0%]  (fallthru,exec)

  # BLOCK 6 freq:9100
  # PRED: 7 [91.0%]  (true,exec)
  # VUSE <.MEMD.2716_21>
  D.1614_13 = *cD.1606_2;
  cD.1606_14 = &D.1614_13->aD.1593;
  # SUCC: 7 [100.0%]  (fallthru,dfs_back,exec)

  # BLOCK 7 freq:10000
  # PRED: 5 [100.0%]  (fallthru,exec) 6 [100.0%]  (fallthru,dfs_back,exec)
  # cD.1606_2 = PHI <cD.1606_1(5), cD.1606_14(6)>
  # VUSE <.MEMD.2716_21>
  D.1614_12 = *cD.1606_2;
  if (D.1614_12 != 0B)
    goto <bb 6>;
  else
    goto <bb 8>;
  # SUCC: 6 [91.0%]  (true,exec) 8 [9.0%]  (false,exec)

Note that the D.1614_12 = *cD.1606_2 read depends on the *cD.1606_1 =
D.1615_11;
store.  In phiprop we have though:

  # BLOCK 3 freq:9100
  # PRED: 4 [91.0%]  (true,exec)
  cD.1606_9 = &D.1614_8->aD.1593;
  # VUSE <.MEMD.2716_19>
  D.2745_25 = D.1614_8->aD.1593;
  # SUCC: 4 [100.0%]  (fallthru,dfs_back,exec)

  # BLOCK 4 freq:10000
  # PRED: 2 [100.0%]  (fallthru,exec) 3 [100.0%]  (fallthru,dfs_back,exec)
  # cD.1606_1 = PHI <cD.1606_4(2), cD.1606_9(3)>
  # D.1614_8 = PHI <D.2744_24(2), D.2745_25(3)>
  D.1614_7 = D.1614_8;
  if (D.1614_7 != 0B)
    goto <bb 3>;
  else
    goto <bb 5>;
  # SUCC: 3 [91.0%]  (true,exec) 5 [9.0%]  (false,exec)

  # BLOCK 5 freq:900
  # PRED: 4 [9.0%]  (false,exec)
  # .MEMD.2716_20 = VDEF <.MEMD.2716_19>
  D.1615_11 = fooD.1597 (yD.1602_10(D));
  # .MEMD.2716_21 = VDEF <.MEMD.2716_20>
  *cD.1606_1 = D.1615_11;
  goto <bb 7>;
  # SUCC: 7 [100.0%]  (fallthru,exec)

  # BLOCK 6 freq:9100
  # PRED: 7 [91.0%]  (true,exec)
  cD.1606_14 = &D.1614_13->aD.1593;
  # VUSE <.MEMD.2716_21>
  D.2746_26 = D.1614_13->aD.1593;
  # SUCC: 7 [100.0%]  (fallthru,dfs_back,exec)

  # BLOCK 7 freq:10000
  # PRED: 5 [100.0%]  (fallthru,exec) 6 [100.0%]  (fallthru,dfs_back,exec)
  # cD.1606_2 = PHI <cD.1606_1(5), cD.1606_14(6)>
  # D.1614_13 = PHI <D.1614_8(5), D.2746_26(6)>
  D.1614_12 = D.1614_13;
  if (D.1614_12 != 0B)
    goto <bb 6>;
  else
    goto <bb 8>;
  # SUCC: 6 [91.0%]  (true,exec) 8 [9.0%]  (false,exec)

Note that the D.1614_13 PHI now uses D.1614_8, which is correct *c content
only if the *cD.1606_1 = D.1615_11; store wasn't performed.  This store
obviously can change what *c contains.  Later passes then find out that
D.1614_8 must be 0 to reach BB5 and BB7, so the whole second while loop is
removed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4 Regression] breaks     |[4.4/4.5 Regression] Alpine
                   |"reply to all" in alpine    |miscompilation


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4/4.5 Regression] Alpine miscompilation

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2009-05-05 10:10 -------
Mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |wrong-code
   Last reconfirmed|2009-05-05 09:02:11         |2009-05-05 10:10:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4/4.5 Regression] Alpine miscompilation

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2009-05-05 16:10 -------
Subject: Bug 40022

Author: rguenth
Date: Tue May  5 16:09:46 2009
New Revision: 147128

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147128
Log:
2009-05-05  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/40022
        * tree-ssa-phiprop.c (struct phiprop_d): Exchange vop_stmt for
        the only vuse.
        (phivn_valid_p): Fix tuplification error, simplify.
        (phiprop_insert_phi): Add dumps.
        (propagate_with_phi): Simplify.

        * gcc.c-torture/execute/pr40022.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/pr40022.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-phiprop.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] Alpine miscompilation

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2009-05-05 16:10 -------
Fixed for trunk.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.5.0
            Summary|[4.4/4.5 Regression] Alpine |[4.4 Regression] Alpine
                   |miscompilation              |miscompilation


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] Alpine miscompilation

[mmitchel at gcc dot gnu dot org]

------- Comment #11 from mmitchel at gcc dot gnu dot org  2009-05-05 16:11 -------
Richard, can this be closed now?


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org, mmitchel at gcc dot gnu
                   |                            |dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] Alpine miscompilation

[jakub at gcc dot gnu dot org]

------- Comment #12 from jakub at gcc dot gnu dot org  2009-05-05 16:53 -------
It hasn't been fixed on the 4.4 branch yet, so it can't.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] Alpine miscompilation

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] Alpine miscompilation

[rguenth at gcc dot gnu dot org]

------- Comment #13 from rguenth at gcc dot gnu dot org  2009-05-06 08:32 -------
Fixed now.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |4.4.0
      Known to work|4.5.0                       |4.4.1 4.5.0
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022

[Bug middle-end/40022] [4.4 Regression] Alpine miscompilation

[rguenth at gcc dot gnu dot org]

------- Comment #14 from rguenth at gcc dot gnu dot org  2009-05-06 08:33 -------
Subject: Bug 40022

Author: rguenth
Date: Wed May  6 08:32:24 2009
New Revision: 147153

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147153
Log:
2009-05-06  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/40022
        * tree-ssa-phiprop.c (phivn_valid_p): Fix tuplification error.

        * gcc.c-torture/execute/pr40022.c: New testcase.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr40022.c
Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_4-branch/gcc/tree-ssa-phiprop.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40022