public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "dave dot korn dot cygwin at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/40068] GCC fails to apply dllexport attribute to typeinfo. Date: Sun, 10 May 2009 11:18:00 -0000 [thread overview] Message-ID: <20090510111752.12282.qmail@sourceware.org> (raw) In-Reply-To: <bug-40068-9431@http.gcc.gnu.org/bugzilla/> ------- Comment #5 from dave dot korn dot cygwin at gmail dot com 2009-05-10 11:17 ------- (In reply to comment #4) > Hello Dave, Hi Danny! > Rather than use DLL linkage (and so force client to resort to auto-import > magic) > why not just always emit the RTTI with one-only comdat linkage. I have your patch in the cygwin distro compiler where it works fine, but I am concerned about what unforeseeable problems could arise by violating ODR in this way. I don't have any concrete evidence of any problem yet, it is just a worry. Also, I don't think this is necessarily an either-or situation; we could add my patch and have the typeinfo exported from the DLL, and also add yours so that clients could link a comdat copy (which would override the import stub) until we have a better solution for importing from the DLL. Or I could follow up with another patch that propagates dllimport attributes from class to typeinfo. There is of course this: /* We leave typeinfo tables alone. We can't mark TI objects as dllimport, since the address of a secondary VTT may be needed for static initialization of a primary VTT. VTT's of dllimport'd classes should always be link-once COMDAT. */ /* Do not import tinfo nodes if the class has dllimport attribute. Dllimports do not have a constant address at compile time, so static initialization of tables with RTTI fields is a problem. Set to comdat instead. */ ... but I do not see why this should be a problem in these days of auto-import and pseudo-relocs; do you know more about what the actual problem is (or was) here? Is this not basically the same situation as something like ----dll_A.c---- int foo; int __attribute__ ((dllexport)) * bar = &foo; ----dll_B.c---- extern int __attribute__ ((dllexport)) * bar; int __attribute__ ((dllexport)) * baz = &bar; --------------- the example above? If it's possible to solve either in the compiler or further down the toolchain, I would very much like to do so. Also, how come emitting the typeinfo .linkonce as we currently do isn't the same as COMDAT for these purposes? cheers, DaveK -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40068
next prev parent reply other threads:[~2009-05-10 11:18 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-08 11:52 [Bug c++/40068] New: " dave dot korn dot cygwin at gmail dot com 2009-05-08 11:53 ` [Bug c++/40068] " dave dot korn dot cygwin at gmail dot com 2009-05-08 11:56 ` dave dot korn dot cygwin at gmail dot com 2009-05-10 1:11 ` [Bug target/40068] " dave dot korn dot cygwin at gmail dot com 2009-05-10 5:01 ` dannysmith at users dot sourceforge dot net 2009-05-10 11:18 ` dave dot korn dot cygwin at gmail dot com [this message] 2009-05-13 8:12 ` dannysmith at users dot sourceforge dot net 2009-06-25 15:37 ` dave dot korn dot cygwin at gmail dot com [not found] <bug-40068-4@http.gcc.gnu.org/bugzilla/> 2012-02-02 21:01 ` ktietz at gcc dot gnu.org 2012-02-07 10:47 ` ktietz at gcc dot gnu.org 2012-02-07 10:49 ` ktietz at gcc dot gnu.org 2012-02-07 11:49 ` ktietz at gcc dot gnu.org 2013-09-13 7:52 ` mattyclarkson at gmail dot com 2013-09-13 7:54 ` mattyclarkson at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090510111752.12282.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).