[Bug bootstrap/40082] New: Power bootstrap is broken in building libstdc++

[Bug bootstrap/40082] New: Power bootstrap is broken in building libstdc++

[meissner at linux dot vnet dot ibm dot com]

I synced up to the current tree, and did a bootstrap build, and it fails in
building libstdc++:
/home/meissner/fsf-src/trunk/libstdc++-v3/src/compatibility-ldbl.cc:77: error:
inlined_to pointer is wrong
void std::basic_string<_CharT, _Traits, _Alloc>::_M_leak() [with _CharT =
wchar_t, _Traits = std::char_traits<wchar_t>, _Alloc =
std::allocator<wchar_t>]/608(-1) [0x4000183b500]: (inline copy in _OutIter
std::money_put<_CharT, _OutIter>::_M_insert(iter_type, std::ios_base&,
char_type, const std::money_put<_CharT, _OutIter>::string_type&) const [with
bool _Intl = true, _CharT = wchar_t, _OutIter =
std::ostreambuf_iterator<wchar_t>, iter_type =
std::ostreambuf_iterator<wchar_t>, char_type = wchar_t, std::money_put<_CharT,
_OutIter>::string_type = std::basic_string<wchar_t>]/568) (clone of void
std::basic_string<_CharT, _Traits, _Alloc>::_M_leak() [with _CharT = wchar_t,
_Traits = std::char_traits<wchar_t>, _Alloc = std::allocator<wchar_t>]/648)
availability:available 16 insns body finalized inlinable
  called by: std::basic_string<_CharT, _Traits, _Alloc>::reference
std::basic_string<_CharT, _Traits,
_Alloc>::operator[](std::basic_string<_CharT, _Traits, _Alloc>::size_type)
[with _CharT = wchar_t, _Traits = std::char_traits<wchar_t>, _Alloc =
std::allocator<wchar_t>, std::basic_string<_CharT, _Traits, _Alloc>::reference
= wchar_t&, std::basic_string<_CharT, _Traits, _Alloc>::size_type = long
unsigned int]/246 (1.00 per call) (inlined) (can throw external) 
  calls: void std::basic_string<_CharT, _Traits, _Alloc>::_M_leak_hard() [with
_CharT = wchar_t, _Traits = std::char_traits<wchar_t>, _Alloc =
std::allocator<wchar_t>]/858 (0.63 per call) (can throw external) 
/home/meissner/fsf-src/trunk/libstdc++-v3/src/compatibility-ldbl.cc:77:
internal compiler error: verify_cgraph_node failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions


-- 
           Summary: Power bootstrap is broken in building libstdc++
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: meissner at linux dot vnet dot ibm dot com
 GCC build triplet: powerpc64-unknown-linux-gnu
  GCC host triplet: powerpc64-unknown-linux-gnu
GCC target triplet: powerpc64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] Power bootstrap is broken in building libstdc++

[meissner at linux dot vnet dot ibm dot com]

------- Comment #1 from meissner at linux dot vnet dot ibm dot com  2009-05-09 12:36 -------
Created an attachment (id=17836)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17836&action=view)
.ii file of file in libstdc++ that causes the failure

The options needed to show this bug are:
-O2 -mlong-double-64 -fno-implicit-templates


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] [4.5 Regression] Power bootstrap is broken in building libstdc++

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2009-05-09 12:53 -------
Bah.  Honza?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
           Keywords|                            |ice-checking, ice-on-valid-
                   |                            |code
            Summary|Power bootstrap is broken in|[4.5 Regression] Power
                   |building libstdc++          |bootstrap is broken in
                   |                            |building libstdc++
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] [4.5 Regression] Power bootstrap is broken in building libstdc++

[hubicka at ucw dot cz]

------- Comment #3 from hubicka at ucw dot cz  2009-05-09 14:44 -------
Subject: Re:  [4.5 Regression] Power bootstrap is broken in building libstdc++

Hi,
I am testing the attached patch.  It makes testcase to compile, does it
solve bootstrap issues too?

Index: ipa.c
===================================================================
--- ipa.c       (revision 147317)
+++ ipa.c       (working copy)
@@ -92,6 +92,21 @@ cgraph_postorder (struct cgraph_node **o
   return order_pos;
 }

+/* Look for all functions inlined to NODE and update their inlined_to pointers
+   to INLINED_TO.  */
+
+static void
+update_inlined_to_pointer (struct cgraph_node *node, struct cgraph_node
*inlined_to)
+{
+  struct cgraph_edge *e;
+  for (e = node->callees; e; e = e->next_callee)
+    if (e->callee->global.inlined_to)
+      {
+        e->callee->global.inlined_to = inlined_to;
+       update_inlined_to_pointer (e->callee, inlined_to);
+      }
+}
+
 /* Perform reachability analysis and reclaim all unreachable nodes.
    If BEFORE_INLINING_P is true this function is called before inlining
    decisions has been made.  If BEFORE_INLINING_P is false this function also 
@@ -214,7 +229,8 @@ cgraph_remove_unreachable_nodes (bool be
          && !node->callers)
        {
          gcc_assert (node->clones);
-         node->global.inlined_to = false;
+         node->global.inlined_to = NULL;
+         update_inlined_to_pointer (node, node);
        }
       node->aux = NULL;
     }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] [4.5 Regression] Power bootstrap is broken in building libstdc++

[meissner at linux dot vnet dot ibm dot com]

------- Comment #4 from meissner at linux dot vnet dot ibm dot com  2009-05-09 15:56 -------
Subject: Re:  [4.5 Regression] Power bootstrap is broken in building libstdc++

On Sat, May 09, 2009 at 02:44:29PM -0000, hubicka at ucw dot cz wrote:
> 
> 
> ------- Comment #3 from hubicka at ucw dot cz  2009-05-09 14:44 -------
> Subject: Re:  [4.5 Regression] Power bootstrap is broken in building libstdc++
> 
> Hi,
> I am testing the attached patch.  It makes testcase to compile, does it
> solve bootstrap issues too?

I just fired off a bootstrap, and will let you know when I get back to the
computer in a few hours.

Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] [4.5 Regression] Power bootstrap is broken in building libstdc++

[hubicka at gcc dot gnu dot org]

------- Comment #5 from hubicka at gcc dot gnu dot org  2009-05-09 18:31 -------
Subject: Bug 40082

Author: hubicka
Date: Sat May  9 18:31:32 2009
New Revision: 147319

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147319
Log:
        PR bootstrap/40082
        * ipa.c (update_inlined_to_pointer): New function.
        (cgraph_remove_unreachable_nodes): Use it.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] [4.5 Regression] Power bootstrap is broken in building libstdc++

[meissner at linux dot vnet dot ibm dot com]

------- Comment #6 from meissner at linux dot vnet dot ibm dot com  2009-05-10 01:05 -------
Subject: Re:  [4.5 Regression] Power bootstrap is broken in building libstdc++

On Sat, May 09, 2009 at 02:44:29PM -0000, hubicka at ucw dot cz wrote:
> 
> 
> ------- Comment #3 from hubicka at ucw dot cz  2009-05-09 14:44 -------
> Subject: Re:  [4.5 Regression] Power bootstrap is broken in building libstdc++
> 
> Hi,
> I am testing the attached patch.  It makes testcase to compile, does it
> solve bootstrap issues too?

It does solve the bootstrap issue.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082

[Bug bootstrap/40082] [4.5 Regression] Power bootstrap is broken in building libstdc++

[hubicka at gcc dot gnu dot org]

------- Comment #7 from hubicka at gcc dot gnu dot org  2009-05-10 17:06 -------
Fixed.


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40082