public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/39782] [4.3/4.4 Regression] IO depends on uninitialised value
Date: Wed, 13 May 2009 13:47:00 -0000 [thread overview]
Message-ID: <20090513134708.3080.qmail@sourceware.org> (raw)
In-Reply-To: <bug-39782-6642@http.gcc.gnu.org/bugzilla/>
------- Comment #10 from burnus at gcc dot gnu dot org 2009-05-13 13:47 -------
For 4.4 the equivalent diff should be the following (untested). I don't see ad
hoc whether the "sfree" can be removed as well or not.
Index: libgfortran/io/transfer.c
===================================================================
--- libgfortran/io/transfer.c (revision 147470)
+++ libgfortran/io/transfer.c (working copy)
@@ -2148,7 +2148,6 @@ data_transfer_init (st_parameter_dt *dtp
if (dtp->pos != dtp->u.p.current_unit->strm_pos)
{
fbuf_flush (dtp->u.p.current_unit, 1);
- flush (dtp->u.p.current_unit->s);
if (sseek (dtp->u.p.current_unit->s, dtp->pos - 1) == FAILURE)
{
generate_error (&dtp->common, LIBERROR_OS, NULL);
@@ -2951,10 +2950,7 @@ finalize_transfer (st_parameter_dt *dtp)
if (dtp->u.p.current_unit->flags.form == FORM_UNFORMATTED
&& file_position (dtp->u.p.current_unit->s) >= dtp->rec)
- {
- flush (dtp->u.p.current_unit->s);
- sfree (dtp->u.p.current_unit->s);
- }
+ sfree (dtp->u.p.current_unit->s);
return;
}
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39782
next prev parent reply other threads:[~2009-05-13 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 7:29 [Bug fortran/39782] New: " jv244 at cam dot ac dot uk
2009-04-16 7:31 ` [Bug fortran/39782] " jv244 at cam dot ac dot uk
2009-04-16 12:56 ` [Bug fortran/39782] [4.5/4.4/4.3 Regression] " jv244 at cam dot ac dot uk
2009-04-16 12:59 ` [Bug fortran/39782] [4.3/4.4/4.5 " jv244 at cam dot ac dot uk
2009-04-16 18:37 ` pinskia at gcc dot gnu dot org
2009-04-16 19:10 ` pinskia at gcc dot gnu dot org
2009-04-17 1:47 ` jvdelisle at gcc dot gnu dot org
2009-04-18 10:06 ` jb at gcc dot gnu dot org
2009-04-18 17:11 ` jv244 at cam dot ac dot uk
2009-04-22 13:33 ` [Bug fortran/39782] [4.3/4.4 " rguenth at gcc dot gnu dot org
2009-04-22 21:37 ` jb at gcc dot gnu dot org
2009-04-23 14:21 ` jv244 at cam dot ac dot uk
2009-05-13 13:47 ` burnus at gcc dot gnu dot org [this message]
2009-05-15 23:50 ` jb at gcc dot gnu dot org
2009-05-16 13:38 ` jvdelisle at gcc dot gnu dot org
2009-05-27 1:23 ` jvdelisle at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513134708.3080.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).