[Bug middle-end/40123] New: [4.5 Regression] Revision 147395 failed libstc++ tests

[Bug middle-end/40123] New: [4.5 Regression] Revision 147395 failed libstc++ tests

[hjl dot tools at gmail dot com]

On Linux/x86-64, with checking enabled, revision 147395

http://gcc.gnu.org/ml/gcc-cvs/2009-05/msg00369.html

caused

FAIL: 26_numerics/random/independent_bits_engine/operators/equal.cc execution
test
FAIL: 26_numerics/random/independent_bits_engine/operators/serialize.cc
execution test

with -m32.


-- 
           Summary: [4.5 Regression]  Revision 147395 failed libstc++ tests
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug middle-end/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug middle-end/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo dot carlini at oracle dot com]

------- Comment #1 from paolo dot carlini at oracle dot com  2009-05-14 08:21 -------
Assigning to Honza basing on a comment on the mailing list...


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo dot carlini at oracle
                   |                            |dot com
         AssignedTo|unassigned at gcc dot gnu   |hubicka at gcc dot gnu dot
                   |dot org                     |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug middle-end/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo dot carlini at oracle dot com]

------- Comment #2 from paolo dot carlini at oracle dot com  2009-05-14 08:54 -------
I tried to reproduce the equal.cc fail, for example, and it happens only at -O1
or above, as a "Floating point exception"...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug libstdc++/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo dot carlini at oracle dot com]

------- Comment #3 from paolo dot carlini at oracle dot com  2009-05-14 09:07 -------
Before dealing with this a middle-end, let me double check the implementation,
because I'm seeing something fishy...


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|hubicka at gcc dot gnu dot  |paolo dot carlini at oracle
                   |org                         |dot com
          Component|middle-end                  |libstdc++


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug libstdc++/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo dot carlini at oracle dot com]

------- Comment #4 from paolo dot carlini at oracle dot com  2009-05-14 17:12 -------
Indeed, very fishy: 1UL << 48. Patch forthcoming.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug libstdc++/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo dot carlini at oracle dot com]

-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-05-14 17:12:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug libstdc++/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo at gcc dot gnu dot org]

------- Comment #5 from paolo at gcc dot gnu dot org  2009-05-14 17:56 -------
Subject: Bug 40123

Author: paolo
Date: Thu May 14 17:56:17 2009
New Revision: 147538

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147538
Log:
2009-05-14  Paolo Carlini  <paolo.carlini@oracle.com>

        PR libstdc++/40123
        * random.tcc (independent_bits_engine<>::operator()()): Use
        result_type(1), not 1UL.

        * random.tcc (independent_bits_engine<>::operator()()): Use _M_b.max()
        and _M_b.min(), instead of this->max() and this->min().

        * random.h (_ShiftMin1): Remove, adjust everywhere.

        * random.tcc: Minor cosmetic changes.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/random.h
    trunk/libstdc++-v3/include/bits/random.tcc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123

[Bug libstdc++/40123] [4.5 Regression] Revision 147395 failed libstc++ tests

[paolo dot carlini at oracle dot com]

------- Comment #6 from paolo dot carlini at oracle dot com  2009-05-14 17:59 -------
Fixed.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40123