public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jv244 at cam dot ac dot uk" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/40168] missing unrolling/scalarization/reassoc/free
Date: Sat, 16 May 2009 11:19:00 -0000	[thread overview]
Message-ID: <20090516111933.8579.qmail@sourceware.org> (raw)
In-Reply-To: <bug-40168-6642@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from jv244 at cam dot ac dot uk  2009-05-16 11:19 -------
(In reply to comment #3)
> Like so:
> 
> Index: trans-expr.c
> ===================================================================
> --- trans-expr.c        (revision 147583)
> +++ trans-expr.c        (working copy)
> @@ -4430,7 +4430,8 @@ gfc_trans_zero_assign (gfc_expr * expr)
> 
>    /* Convert arguments to the correct types.  */
>    if (!POINTER_TYPE_P (TREE_TYPE (dest)))
> -    dest = gfc_build_addr_expr (pvoid_type_node, dest);
> +    return build2 (MODIFY_EXPR, void_type_node,
> +                  dest, build_constructor (TREE_TYPE (dest), NULL));
>    else
>      dest = fold_convert (pvoid_type_node, dest);
>    len = fold_convert (size_type_node, len);

this seems to speedup this case by somewhat, but not quite as much as the
hand-coded version (even with the other unroll parameters).

However, another testcase I run automatically when building gcc is much faster
with a patched trunk than unpatched trunk from a week ago. I will try to see if
this is due to this patch alone.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40168


  parent reply	other threads:[~2009-05-16 11:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  9:35 [Bug middle-end/40168] New: " jv244 at cam dot ac dot uk
2009-05-16  9:36 ` [Bug middle-end/40168] " jv244 at cam dot ac dot uk
2009-05-16  9:54 ` [Bug fortran/40168] " rguenth at gcc dot gnu dot org
2009-05-16 10:04 ` rguenth at gcc dot gnu dot org
2009-05-16 11:19 ` jv244 at cam dot ac dot uk [this message]
2009-05-16 11:20 ` rguenth at gcc dot gnu dot org
2009-05-16 11:31 ` jv244 at cam dot ac dot uk
2009-05-16 11:39 ` rguenther at suse dot de
2009-05-16 12:20 ` jv244 at cam dot ac dot uk
2009-05-16 12:39 ` jv244 at cam dot ac dot uk
2009-05-16 13:46 ` jvdelisle at gcc dot gnu dot org
2009-05-16 14:48 ` pinskia at gcc dot gnu dot org
2009-05-18  8:53 ` rguenth at gcc dot gnu dot org
2009-05-18 10:25 ` rguenth at gcc dot gnu dot org
2009-05-18 12:20 ` jv244 at cam dot ac dot uk
2009-05-27 11:01 ` rguenth at gcc dot gnu dot org
2009-06-06  7:08 ` jv244 at cam dot ac dot uk
2009-06-14 12:31 ` rguenther at suse dot de
2009-06-14 13:40 ` rguenth at gcc dot gnu dot org
2009-12-18 14:32 ` pault at gcc dot gnu dot org
2009-12-18 14:45 ` [Bug tree-optimization/40168] " rguenth at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090516111933.8579.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).