public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "meissner at linux dot vnet dot ibm dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/40172] [4.5 Regression] Revision 147596 breaks bootstrap Date: Mon, 18 May 2009 22:56:00 -0000 [thread overview] Message-ID: <20090518225627.6681.qmail@sourceware.org> (raw) In-Reply-To: <bug-40172-682@http.gcc.gnu.org/bugzilla/> ------- Comment #16 from meissner at linux dot vnet dot ibm dot com 2009-05-18 22:56 ------- Just to chime in, the warning is a useful warning, but the way rs6000 and mips define FRAME_GROWS_DOWNWARD, the test in toplev.c will never succeed. I can see a couple of ways to fix this: 1) Revert the patch that moves this warning to -Wextra. I think this is a bad idea, since the warning does seem to be useful. 2) Disable the check in toplev.c. Again, I think this is useful in general, but as an immediate palative, it can be useful. 3) Add a new macro to say not to do the test in #2, and define it in mips and rs6000. This is doable, but in general it is not a good idea to add new global macros like this. 4) Change mips and rs6000 to have a global variable that is what FRAME_GROWS_DOWNWARD should be. This is certainly doable. The test will be tested at runtime, but never invoke the error message. 5) Move FRAME_GROWS_DOWNWARD (and STACK_GROWS_DOWNWARD, etc.) into the target structure, and set the field in the target structure from the macro. I tend to like this (and eventually move backends to set the field directly and get rid of the macros). I tend to like this idea best. -- meissner at linux dot vnet dot ibm dot com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner at linux dot vnet | |dot ibm dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40172
next prev parent reply other threads:[~2009-05-18 22:56 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-16 15:16 [Bug middle-end/40172] New: [4.5 Regression] Revision 147596 breaks bootstrap ia ia64 hjl dot tools at gmail dot com 2009-05-16 15:19 ` [Bug middle-end/40172] " hjl dot tools at gmail dot com 2009-05-16 15:19 ` [Bug middle-end/40172] [4.5 Regression] Revision 147596 breaks bootstrap hjl dot tools at gmail dot com 2009-05-16 15:32 ` [Bug c/40172] " dominiq at lps dot ens dot fr 2009-05-16 16:12 ` hjl dot tools at gmail dot com 2009-05-17 3:08 ` danglin at gcc dot gnu dot org 2009-05-17 17:12 ` manu at gcc dot gnu dot org 2009-05-17 18:05 ` hjl dot tools at gmail dot com 2009-05-17 18:37 ` hjl at gcc dot gnu dot org 2009-05-17 19:25 ` hjl dot tools at gmail dot com 2009-05-17 20:02 ` pinskia at gcc dot gnu dot org 2009-05-17 20:14 ` hjl dot tools at gmail dot com 2009-05-17 20:17 ` pinskia at gcc dot gnu dot org 2009-05-17 20:20 ` rguenth at gcc dot gnu dot org 2009-05-17 20:47 ` manu at gcc dot gnu dot org 2009-05-18 21:10 ` daney at gcc dot gnu dot org 2009-05-18 22:35 ` daney at gcc dot gnu dot org 2009-05-18 22:56 ` meissner at linux dot vnet dot ibm dot com [this message] 2009-05-18 23:03 ` hjl dot tools at gmail dot com 2009-05-18 23:13 ` manu at gcc dot gnu dot org 2009-05-18 23:32 ` daney at gcc dot gnu dot org 2009-05-18 23:49 ` meissner at linux dot vnet dot ibm dot com 2009-05-19 0:02 ` pinskia at gcc dot gnu dot org 2009-05-19 0:38 ` hjl dot tools at gmail dot com 2009-05-19 2:33 ` meissner at linux dot vnet dot ibm dot com 2009-05-19 2:37 ` hjl dot tools at gmail dot com 2009-05-19 19:29 ` manu at gcc dot gnu dot org 2009-05-19 20:29 ` manu at gcc dot gnu dot org 2009-05-19 20:58 ` ddaney at caviumnetworks dot com 2009-05-19 21:17 ` hjl at gcc dot gnu dot org 2009-05-19 21:24 ` hjl at gcc dot gnu dot org 2009-05-21 11:05 ` rguenth at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090518225627.6681.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).