public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/40246] ICE on invalid SOURCE= using NULLIFY
Date: Tue, 26 May 2009 08:32:00 -0000	[thread overview]
Message-ID: <20090526083222.25077.qmail@sourceware.org> (raw)
In-Reply-To: <bug-40246-13404@http.gcc.gnu.org/bugzilla/>



------- Comment #1 from burnus at gcc dot gnu dot org  2009-05-26 08:32 -------
The following patch to gfc_match_nullify fixes it; however, I think one should
additionally add

  gfc_free_expr (new_st.expr1);
  new_st.expr1 = NULL;
  gfc_free_expr (new_st.expr2);
  new_st.expr2 = NULL;

to prevent a memory leak.

--- match.c     (revision 147861)
+++ match.c     (working copy)
@@ -2418,6 +2470,7 @@ syntax:

 cleanup:
   gfc_free_statements (new_st.next);
+  new_st.next = NULL;
   return MATCH_ERROR;
 }


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |burnus at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-05-26 08:32:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40246


  reply	other threads:[~2009-05-26  8:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25 22:24 [Bug fortran/40246] New: " burnus at gcc dot gnu dot org
2009-05-26  8:32 ` burnus at gcc dot gnu dot org [this message]
2009-05-26 14:19 ` [Bug fortran/40246] " kargl at gcc dot gnu dot org
2009-05-26 14:45 ` burnus at gcc dot gnu dot org
2009-05-26 15:11 ` kargl at gcc dot gnu dot org
2009-05-26 19:24 ` burnus at gcc dot gnu dot org
2009-05-26 19:30 ` burnus at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526083222.25077.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).