[Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug fortran/39654]  New: ABI bug: FTELL intrinsic function not capable of large files
@ 2009-04-05 17:17 jb at gcc dot gnu dot org
  2009-05-27 17:29 ` [Bug fortran/39654] " burnus at gcc dot gnu dot org
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: jb at gcc dot gnu dot org @ 2009-04-05 17:17 UTC (permalink / raw)
  To: gcc-bugs

The FTELL function in libgfortran/io/intrinsics.c has the prototype

extern size_t PREFIX(ftell) (int *);

where the return value is the file position of the unit given in the int
argument. On 32-bit platforms this will not work for files > 4 GB. The return
type should be GFC_IO_INT which is a typedef for off_t which is 64-bit on LFS
capable systems.


-- 
           Summary: ABI bug: FTELL intrinsic function not capable of large
                    files
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jb at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
@ 2009-05-27 17:29 ` burnus at gcc dot gnu dot org
  2009-05-27 17:44 ` jb at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: burnus at gcc dot gnu dot org @ 2009-05-27 17:29 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from burnus at gcc dot gnu dot org  2009-05-27 17:29 -------
See also: http://gcc.gnu.org/wiki/LibgfortranAbiCleanup


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
  2009-05-27 17:29 ` [Bug fortran/39654] " burnus at gcc dot gnu dot org
@ 2009-05-27 17:44 ` jb at gcc dot gnu dot org
  2009-07-22  0:02 ` jvdelisle at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: jb at gcc dot gnu dot org @ 2009-05-27 17:44 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from jb at gcc dot gnu dot org  2009-05-27 17:44 -------
(In reply to comment #1)
> See also: http://gcc.gnu.org/wiki/LibgfortranAbiCleanup
> 

Yes, I know; I added the note to the wiki page after I filed this bug. ;-)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
  2009-05-27 17:29 ` [Bug fortran/39654] " burnus at gcc dot gnu dot org
  2009-05-27 17:44 ` jb at gcc dot gnu dot org
@ 2009-07-22  0:02 ` jvdelisle at gcc dot gnu dot org
  2009-07-29 12:47 ` jb at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2009-07-22  0:02 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from jvdelisle at gcc dot gnu dot org  2009-07-22 00:02 -------
Is there a particular reason why we can not change this to off_t with 4.5.?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2009-07-22  0:02 ` jvdelisle at gcc dot gnu dot org
@ 2009-07-29 12:47 ` jb at gcc dot gnu dot org
  2009-12-17 21:05 ` pault at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: jb at gcc dot gnu dot org @ 2009-07-29 12:47 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from jb at gcc dot gnu dot org  2009-07-29 12:46 -------
(In reply to comment #3)
> Is there a particular reason why we can not change this to off_t with 4.5.?
> 

Yes, it would break the ABI. As it's such a minor issue, IMHO it can be
postponed until we need to break the ABI for other reasons (e.g. the new array
descriptor for 4.6 and so on).

If one really wanted to fix it, we could have a new symbol in the library with
the correct prototype, and 4.5 could use that and older releases of gfortran
keep using the existing one. That can be done with symbol versioning, or just
manually. But I'm not sure it's worth the bother.


-- 

jb at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2009-07-29 12:47 ` jb at gcc dot gnu dot org
@ 2009-12-17 21:05 ` pault at gcc dot gnu dot org
  2009-12-19 11:03 ` jb at gcc dot gnu dot org
  2010-08-27 13:28 ` fxcoudert at gcc dot gnu dot org
  6 siblings, 0 replies; 11+ messages in thread
From: pault at gcc dot gnu dot org @ 2009-12-17 21:05 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from pault at gcc dot gnu dot org  2009-12-17 21:04 -------
(In reply to comment #4)
> (In reply to comment #3)

Gentlemen,

What is the word on this? A WONTFIX?

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2009-12-17 21:05 ` pault at gcc dot gnu dot org
@ 2009-12-19 11:03 ` jb at gcc dot gnu dot org
  2010-08-27 13:28 ` fxcoudert at gcc dot gnu dot org
  6 siblings, 0 replies; 11+ messages in thread
From: jb at gcc dot gnu dot org @ 2009-12-19 11:03 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from jb at gcc dot gnu dot org  2009-12-19 11:03 -------
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> 
> Gentlemen,
> 
> What is the word on this? A WONTFIX?

Certainly this should be fixed, eventually. Whether it will be fixed for 4.5 or
sometime later remains to be seen. Personally, I don't think it's particularly
high priority.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
  2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2009-12-19 11:03 ` jb at gcc dot gnu dot org
@ 2010-08-27 13:28 ` fxcoudert at gcc dot gnu dot org
  6 siblings, 0 replies; 11+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2010-08-27 13:28 UTC (permalink / raw)
  To: gcc-bugs



-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-08-27 13:27:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654


^ permalink raw reply	[flat|nested] 11+ messages in thread

[parent not found: <bug-39654-4@http.gcc.gnu.org/bugzilla/>]

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
       [not found] <bug-39654-4@http.gcc.gnu.org/bugzilla/>
@ 2012-06-20 21:32 ` jb at gcc dot gnu.org
  2012-06-21 18:47 ` jb at gcc dot gnu.org
  2012-06-21 19:53 ` jb at gcc dot gnu.org
  2 siblings, 0 replies; 11+ messages in thread
From: jb at gcc dot gnu.org @ 2012-06-20 21:32 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2012-06/msg01378.htm
                   |                            |l
         AssignedTo|unassigned at gcc dot       |jb at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #7 from Janne Blomqvist <jb at gcc dot gnu.org> 2012-06-20 21:31:54 UTC ---
Patch here: http://gcc.gnu.org/ml/gcc-patches/2012-06/msg01378.html


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
       [not found] <bug-39654-4@http.gcc.gnu.org/bugzilla/>
  2012-06-20 21:32 ` jb at gcc dot gnu.org
@ 2012-06-21 18:47 ` jb at gcc dot gnu.org
  2012-06-21 19:53 ` jb at gcc dot gnu.org
  2 siblings, 0 replies; 11+ messages in thread
From: jb at gcc dot gnu.org @ 2012-06-21 18:47 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654

--- Comment #8 from Janne Blomqvist <jb at gcc dot gnu.org> 2012-06-21 18:47:06 UTC ---
Author: jb
Date: Thu Jun 21 18:47:01 2012
New Revision: 188858

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188858
Log:
PR 39654 FTELL intrinsic function return type.

frontend ChangeLog:

2012-06-21  Janne Blomqvist  <jb@gcc.gnu.org>

    PR fortran/39654
    * iresolve.c (gfc_resolve_ftell): Fix result kind and use new
    library function.


library ChangeLog:

2012-06-21  Janne Blomqvist  <jb@gcc.gnu.org>

    PR fortran/39654
    * io/intrinsics.c (ftell2): New function.
    * gfortran.map (_gfortran_ftell2): Export function.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/iresolve.c
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/gfortran.map
    trunk/libgfortran/io/intrinsics.c


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/39654] ABI bug: FTELL intrinsic function not capable of large files
       [not found] <bug-39654-4@http.gcc.gnu.org/bugzilla/>
  2012-06-20 21:32 ` jb at gcc dot gnu.org
  2012-06-21 18:47 ` jb at gcc dot gnu.org
@ 2012-06-21 19:53 ` jb at gcc dot gnu.org
  2 siblings, 0 replies; 11+ messages in thread
From: jb at gcc dot gnu.org @ 2012-06-21 19:53 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39654

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Janne Blomqvist <jb at gcc dot gnu.org> 2012-06-21 19:53:06 UTC ---
Fixed, closing.


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2012-06-21 19:53 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-05 17:17 [Bug fortran/39654] New: ABI bug: FTELL intrinsic function not capable of large files jb at gcc dot gnu dot org
2009-05-27 17:29 ` [Bug fortran/39654] " burnus at gcc dot gnu dot org
2009-05-27 17:44 ` jb at gcc dot gnu dot org
2009-07-22  0:02 ` jvdelisle at gcc dot gnu dot org
2009-07-29 12:47 ` jb at gcc dot gnu dot org
2009-12-17 21:05 ` pault at gcc dot gnu dot org
2009-12-19 11:03 ` jb at gcc dot gnu dot org
2010-08-27 13:28 ` fxcoudert at gcc dot gnu dot org
     [not found] <bug-39654-4@http.gcc.gnu.org/bugzilla/>
2012-06-20 21:32 ` jb at gcc dot gnu.org
2012-06-21 18:47 ` jb at gcc dot gnu.org
2012-06-21 19:53 ` jb at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).