public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jvdelisle at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/40330] [4.4, 4.5 Regression] incorrect IO
Date: Thu, 11 Jun 2009 02:25:00 -0000	[thread overview]
Message-ID: <20090611022513.15913.qmail@sourceware.org> (raw)
In-Reply-To: <bug-40330-6642@http.gcc.gnu.org/bugzilla/>



------- Comment #26 from jvdelisle at gcc dot gnu dot org  2009-06-11 02:25 -------
CP2K still fails.  However, I think I have discovered the root cause.  String
constants in formats are saved in the fnode at sting.p which is a pointer. 
When we use cached parsed string data, those constant strings are net getting
copied and saved along with the parsed format.

That "constant" string is used by write_constant_string in transfer.c.  This is
an issue with the concept because the constant string can vary with each
invocation of the IO statement, as is the case with CP2k, and it is freed at
the end of each IO operation.  The benefit of caching is lost if we have to
reparse to find the strings

This leaves the possibility of disabling the caching if a FMT_STRING token is
found while parsing the format the first time. I am going to suggest we revert
format caching from 4.4 right away and probably 4.5 if some better idea does
not pop into my head.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40330


  parent reply	other threads:[~2009-06-11  2:25 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03 15:45 [Bug libfortran/40330] New: [4.4 " jv244 at cam dot ac dot uk
2009-06-03 15:46 ` [Bug libfortran/40330] " jv244 at cam dot ac dot uk
2009-06-03 15:54 ` dominiq at lps dot ens dot fr
2009-06-03 16:08 ` jv244 at cam dot ac dot uk
2009-06-03 16:32 ` jv244 at cam dot ac dot uk
2009-06-03 16:47 ` jv244 at cam dot ac dot uk
2009-06-03 16:49 ` jv244 at cam dot ac dot uk
2009-06-03 16:58 ` jv244 at cam dot ac dot uk
2009-06-03 17:39 ` jb at gcc dot gnu dot org
2009-06-03 18:49 ` jb at gcc dot gnu dot org
2009-06-03 19:19 ` jb at gcc dot gnu dot org
2009-06-03 21:07 ` jb at gcc dot gnu dot org
2009-06-04  5:16 ` jv244 at cam dot ac dot uk
2009-06-04  5:37 ` burnus at gcc dot gnu dot org
2009-06-09 20:56 ` jb at gcc dot gnu dot org
2009-06-09 20:58 ` jb at gcc dot gnu dot org
2009-06-09 22:15 ` jv244 at cam dot ac dot uk
2009-06-10  2:18 ` jvdelisle at gcc dot gnu dot org
2009-06-10  3:11 ` jvdelisle at gcc dot gnu dot org
2009-06-10  6:45 ` burnus at gcc dot gnu dot org
2009-06-10  7:22 ` [Bug libfortran/40330] [4.4, 4.5 " jv244 at cam dot ac dot uk
2009-06-10  7:24 ` jv244 at cam dot ac dot uk
2009-06-10  9:26 ` jv244 at cam dot ac dot uk
2009-06-10 12:32 ` jvdelisle at gcc dot gnu dot org
2009-06-10 13:18 ` jv244 at cam dot ac dot uk
2009-06-10 21:18 ` jb at gcc dot gnu dot org
2009-06-11  1:29 ` jvdelisle at gcc dot gnu dot org
2009-06-11  2:25 ` jvdelisle at gcc dot gnu dot org [this message]
2009-06-11  7:04 ` jv244 at cam dot ac dot uk
2009-06-11 12:50 ` jvdelisle at gcc dot gnu dot org
2009-06-11 14:58 ` [Bug libfortran/40330] [4.5 " jvdelisle at gcc dot gnu dot org
2009-06-12  5:48 ` jv244 at cam dot ac dot uk
2009-06-26 15:50 ` jvdelisle at gcc dot gnu dot org
2009-07-05  2:12 ` jvdelisle at gcc dot gnu dot org
2009-07-05 12:25 ` jvdelisle at gcc dot gnu dot org
2009-07-09  1:20 ` jvdelisle at gcc dot gnu dot org
2009-07-09  1:55 ` jvdelisle at gcc dot gnu dot org
2009-07-09  1:59 ` jvdelisle at gcc dot gnu dot org
2009-07-12 14:49 ` jv244 at cam dot ac dot uk
2009-07-23 17:52 ` hjl at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611022513.15913.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).