[Bug middle-end/40281] New: -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[Bug middle-end/40281] New: -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[jv244 at cam dot ac dot uk]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2329 bytes --]

for the testcase to be attached (what about enhancing bugzilla with an option
to attach files at initial submit time?)

gfortran -v -c -O2  -funroll-loops -fprefetch-loop-arrays test.f90

Using built-in specs.
Target: x86_64-unknown-linux-gnu
Configured with: /data03/vondele/gcc_trunk/gcc/configure
--prefix=/data03/vondele/gcc_trunk/build --enable-languages=c,c++,fortran
--disable-multilib --with-ppl=/data03/vondele/gcc_trunk/build/
--with-cloog=/data03/vondele/gcc_trunk/build/
Thread model: posix
gcc version 4.5.0 20090527 (experimental) [trunk revision 147915] (GCC)
COLLECT_GCC_OPTIONS='-v' '-c' '-O2' '-funroll-loops' '-fprefetch-loop-arrays'
'-mtune=generic'

/data03/vondele/gcc_trunk/build/libexec/gcc/x86_64-unknown-linux-gnu/4.5.0/f951
test.f90 -quiet -dumpbase test.f90 -mtune=generic -auxbase test -O2 -version
-funroll-loops -fprefetch-loop-arrays -fintrinsic-modules-path
/data03/vondele/gcc_trunk/build/lib/gcc/x86_64-unknown-linux-gnu/4.5.0/finclude
-o /tmp/ccDzkBkL.s
GNU Fortran (GCC) version 4.5.0 20090527 (experimental) [trunk revision 147915]
(x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.5.0 20090527 (experimental) [trunk revision
147915], GMP version 4.2.2, MPFR version 2.3.1
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU Fortran (GCC) version 4.5.0 20090527 (experimental) [trunk revision 147915]
(x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.5.0 20090527 (experimental) [trunk revision
147915], GMP version 4.2.2, MPFR version 2.3.1
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
test.f90: In function ‘makedcoul’:
test.f90:7: internal compiler error: in initialize_matrix_A, at
tree-data-ref.c:1887
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at
                    tree-data-ref.c:1887
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[jv244 at cam dot ac dot uk]

------- Comment #1 from jv244 at cam dot ac dot uk  2009-05-28 04:57 -------
Created an attachment (id=17923)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17923&action=view)
testcase

compile as 

gfortran -v -c -O2  -funroll-loops -fprefetch-loop-arrays PR40281.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[pthaugen at gcc dot gnu dot org]

------- Comment #2 from pthaugen at gcc dot gnu dot org  2009-06-19 14:41 -------
Created an attachment (id=18024)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18024&action=view)
testcase

The attatched testcase is from cpu2006 component 464.h264ref and appears to
fail in the same manner on PowerPC.

work/spec_err> /home/pthaugen/install/gcc/trunk/bin/gcc -c -m32 -O2
-fprefetch-loop-arrays q_matrix.c
q_matrix.c: In function #ParseMatrix#:
q_matrix.c:5:6: internal compiler error: in initialize_matrix_A, at
tree-data-ref.c:1896
Please submit a full bug report,
with preprocessed source if appropriate.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[jv244 at cam dot ac dot uk]

-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.5.0
      Known to work|                            |4.3.1 4.4.1
            Summary|-fprefetch-loop-arrays: ICE:|[4.5 Regression] -fprefetch-
                   |in initialize_matrix_A, at  |loop-arrays: ICE: in
                   |tree-data-ref.c:1887        |initialize_matrix_A, at
                   |                            |tree-data-ref.c:1887
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2009-06-21 23:42 -------
Confirmed, reduced testcase:
void f(int, int);
int g(int);
extern char errortext[300];

void ParseMatrix (void)
{
  char items[1000];
  extern int item;
  int range;
  int i, j, type, cnt;
  for (i=0; i<item; i+=cnt)
  {
    cnt=1;
    if (!type)
      range = 16;
    else
      range = 64;
    for(j=0; j<range; j++)
      if (1 != g (items[i+cnt+j]))
        f (items[i], items[i+cnt+j]);
    cnt+=j;
  }
}


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-06-21 23:42:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2009-11-05 21:04 -------
Test case in comment 2 fails for me on x86-64-linux with 4.4.1 [gcc-4_4-branch
revision 150839] and with 4.4.3 20091105 [gcc-4_4-branch revision 153928].
Marking thus as 4.4 regression.

Maybe related: PR 41957


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.5 Regression] -fprefetch-|[4.4/4.5 Regression] -
                   |loop-arrays: ICE: in        |fprefetch-loop-arrays: ICE:
                   |initialize_matrix_A, at     |in initialize_matrix_A, at
                   |tree-data-ref.c:1887        |tree-data-ref.c:1887
   Target Milestone|4.5.0                       |4.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2009-11-09 13:48 -------
Hm.

(gdb) call debug_generic_expr (chrec)
{{1, +, {2, +, 1}_2}_1, +, 1}_2

how can this happen?  Why does evolution_function_is_affine_multivariate_p
not reject this chrec?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2009-09-28 20:52:51         |2009-11-09 13:48:47
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2009-11-09 13:59 -------
*** Bug 41957 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkoenig at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[reichelt at gcc dot gnu dot org]

------- Comment #7 from reichelt at gcc dot gnu dot org  2009-11-13 12:32 -------
Even shorter testcase (crashes with "-O -fprefetch-loop-arrays"):

=======================================
void foo(int);

void bar(int n)
{
  int a[2], i, j = 0;

  for (i = 0; i < 2; i += j+1)
    for (j = 0; j < (n ? 1 : 2); ++j)
      foo(a[i] + a[j]);
}
=======================================


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[spop at gcc dot gnu dot org]

------- Comment #8 from spop at gcc dot gnu dot org  2009-11-19 22:14 -------
Subject: Re:  [4.4/4.5 Regression] -fprefetch-loop-arrays: 
        ICE: in initialize_matrix_A, at tree-data-ref.c:1887

Hi,

Here is a fix for this one, on top of the graphite branch.
I will commit this fix to the graphite branch to run the automatic testers,
and then it will be included in the merge from graphite to trunk.

Sebastian

diff --git a/gcc/tree-scalar-evolution.c b/gcc/tree-scalar-evolution.c
index fcd3382..7321b6e 100644
--- a/gcc/tree-scalar-evolution.c
+++ b/gcc/tree-scalar-evolution.c
@@ -2215,9 +2215,21 @@ instantiate_scev_poly (basic_block instantiate_below,
   if (CHREC_LEFT (chrec) != op0
       || CHREC_RIGHT (chrec) != op1)
     {
+      unsigned var = CHREC_VARIABLE (chrec);
+
+      /* When the instantiated stride or base has an evolution in an
+        innermost loop, return chrec_dont_know, as this is not a
+        valid SCEV representation.  In the reduced testcase for
+        PR40281 we would have {0, +, {1, +, 1}_2}_1 that has no
+        meaning.  */
+      if ((tree_is_chrec (op0) && CHREC_VARIABLE (op0) > var)
+         || (tree_is_chrec (op1) && CHREC_VARIABLE (op1) > var))
+       return chrec_dont_know;
+
       op1 = chrec_convert_rhs (chrec_type (op0), op1, NULL);
-      chrec = build_polynomial_chrec (CHREC_VARIABLE (chrec), op0, op1);
+      chrec = build_polynomial_chrec (var, op0, op1);
     }
+
   return chrec;
 }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[spop at gcc dot gnu dot org]

------- Comment #9 from spop at gcc dot gnu dot org  2009-11-19 22:33 -------
Subject: Bug 40281

Author: spop
Date: Thu Nov 19 22:32:50 2009
New Revision: 154348

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154348
Log:
Fix PR40281.

2009-11-18  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/40281
        * testsuite/gcc.dg/graphite/pr40281.c: New.

        * tree-scalar-evolution.c (instantiate_scev_poly): Base and stride
        evolutions should not variate in inner loops.

Added:
    branches/graphite/gcc/testsuite/gcc.dg/graphite/pr40281.c
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/tree-scalar-evolution.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[spop at gcc dot gnu dot org]

------- Comment #10 from spop at gcc dot gnu dot org  2009-11-25 05:36 -------
Subject: Bug 40281

Author: spop
Date: Wed Nov 25 05:35:58 2009
New Revision: 154641

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154641
Log:
2009-11-18  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/40281
        * testsuite/gcc.dg/graphite/pr40281.c: New.

        * tree-scalar-evolution.c (instantiate_scev_poly): Base and stride
        evolutions should not variate in inner loops.

Modified:
    trunk/gcc/ChangeLog.graphite
    trunk/gcc/tree-scalar-evolution.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4/4.5 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[spop at gcc dot gnu dot org]

------- Comment #11 from spop at gcc dot gnu dot org  2009-11-25 05:40 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2009-11-25 10:19 -------
testcase from comment #7 still fails on the 4.4 branch.  4.4.1 doesn't work.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
      Known to fail|4.5.0                       |4.4.3
      Known to work|4.3.1 4.4.1                 |4.3.1 4.5.0
         Resolution|FIXED                       |
            Summary|[4.4/4.5 Regression] -      |[4.4 Regression] -fprefetch-
                   |fprefetch-loop-arrays: ICE: |loop-arrays: ICE: in
                   |in initialize_matrix_A, at  |initialize_matrix_A, at
                   |tree-data-ref.c:1887        |tree-data-ref.c:1887


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[spop at gcc dot gnu dot org]

------- Comment #13 from spop at gcc dot gnu dot org  2010-01-13 07:59 -------
Subject: Bug 40281

Author: spop
Date: Wed Jan 13 07:58:50 2010
New Revision: 155851

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155851
Log:
2010-01-13  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/40281
        * tree-scalar-evolution.c (instantiate_scev_1): Base and stride
        evolutions should not variate in inner loops.

        * gcc.dg/graphite/pr40281.c: New.


Added:
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/graphite/pr40281.c
Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_4-branch/gcc/tree-scalar-evolution.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281

[Bug middle-end/40281] [4.4 Regression] -fprefetch-loop-arrays: ICE: in initialize_matrix_A, at tree-data-ref.c:1887

[spop at gcc dot gnu dot org]

------- Comment #14 from spop at gcc dot gnu dot org  2010-01-13 07:59 -------
Fixed also in the 4.4 branch.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40281